From: John Garry <john.g.garry@oracle.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>,
brauner@kernel.org,
Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Subject: Re: [PATCH] bdev: make blockdev_mnt static
Date: Thu, 9 May 2024 14:29:22 +0100 [thread overview]
Message-ID: <697ccebb-ffbc-4bb3-81ed-a7fab6f5a679@oracle.com> (raw)
In-Reply-To: <2dea08f3-03c8-46aa-af57-45cbd9556df4@kernel.dk>
+
On 28/02/2024 14:21, Jens Axboe wrote:
> On 2/27/24 1:19 AM, Jiapeng Chong wrote:
>> The blockdev_mnt are not used outside the file bdev.c, so the modification
>> is defined as static.
>>
>> block/bdev.c:377:17: warning: symbol 'blockdev_mnt' was not declared. Should it be static?
>
> What is this against?
>
Please note I see this issue on your 6.9 block branch today @
fd379c13fc0 (HEAD, block/block-6.9) block: set default max segment
size in case of virt_boundary
And I think that it fixes 8f3a608827d1, so
Fixes: 8f3a608827d1 ("bdev: open block device as files")
Tested-by: John Garry <john.g.garry@oracle.com>
prev parent reply other threads:[~2024-05-09 13:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 8:19 [PATCH] bdev: make blockdev_mnt static Jiapeng Chong
2024-02-28 13:28 ` Christoph Hellwig
2024-02-28 14:21 ` Jens Axboe
2024-05-09 13:29 ` John Garry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=697ccebb-ffbc-4bb3-81ed-a7fab6f5a679@oracle.com \
--to=john.g.garry@oracle.com \
--cc=abaci@linux.alibaba.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox