From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f72.google.com (mail-oo1-f72.google.com [209.85.161.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D785332861D for ; Tue, 10 Feb 2026 13:41:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.72 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770730899; cv=none; b=FNjpzJuExp39ENmu5DFJYQ0D4NrXwjAU3svAsKDkRgumiHou54gNERik7O68T8YI7ZN2lsIZyqdZYta4IY4wmuF/oLWNU7Z7x4kOJVyuftXj5WyL/SldpZ6DjdInilEdfVhj+RWXijK0D03tWWXpBOdunhSYkpgn4m4mjkGRSno= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770730899; c=relaxed/simple; bh=j7+LW9E4xtM3bwEr/NAOevspS9H128/xAhctJXHbHis=; h=MIME-Version:Date:In-Reply-To:Message-ID:Subject:From:To: Content-Type; b=jwi5EQQiNjhS/fSIz7uuGm5scp+JciIJiV640UgPEMbSt+RMmxb1j0PBdmSelu4bsfpN9Fxmtr1Zn+gbIrdJGUL1RvqfabILzqCls4tesF6Fp18dfsXLSTCfSgESm4dV+lC8HqPIslCJStEgGv/2jmDyRs/dcqVT9DmoEP7uU1I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; arc=none smtp.client-ip=209.85.161.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com Received: by mail-oo1-f72.google.com with SMTP id 006d021491bc7-66b47c7a795so14647533eaf.2 for ; Tue, 10 Feb 2026 05:41:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770730897; x=1771335697; h=to:from:subject:message-id:in-reply-to:date:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nof7tuFbJfLj+FPwJgpHfZIM2FpXLhjyjPk8VRJZYP0=; b=jyPp8BA9yMYgsnFh7uc+H1lLUIaLdrRl7Du8dRNO1oARR11FHZHqz/Zacehh3ydL0S bVHT3YDoOQPeUkciPv5iuM7KnysjuWEL+Q0k8w97kSYU3nm+JUnHLOtYMc2JXBWTFihg A9xhOD6GY6If2DjoR+uIjF3VG19drIxjiyKzHnSpHkRyJI+fj680eVbEXjNf8djzOEBm NyBG5bx4nT4N+rQwDsWY0HssOZSwi6OBpsT81gTS2DclNx//fMKFRIK0e7XvMld+trPp 6i0+E+QtM19F5UoLjbNYCcVJbJAfKux5e4K36cWGH66Yxt0POW+fsJ3qyJLfYYA//wEF OOYw== X-Gm-Message-State: AOJu0YwbvoiqDrT4I4pi4keSirNCtlNGcWq3SLXPF+pKXdk0thlBMfNz KcJ5o8zEBsNlbYXmB8DuKILhfrULCCU+ShtW6VXdvTE6WqsqOlOvaDNOReVG15cHZ8t21VRAXbq DCBw7ANptxgU1bfi4/tdn51LG9ShH+u9jgd2NlLX/xYgl/3J7ut263big83o= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Received: by 2002:a4a:e911:0:b0:662:f898:2382 with SMTP id 006d021491bc7-672fee7939dmr937459eaf.63.1770730896818; Tue, 10 Feb 2026 05:41:36 -0800 (PST) Date: Tue, 10 Feb 2026 05:41:36 -0800 In-Reply-To: <6767d8ea.050a0220.226966.0021.GAE@google.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <698b3590.050a0220.340abe.0003.GAE@google.com> Subject: Forwarded: Testing for v4 scsi: target: fix recursive locking in __configfs_open_file() From: syzbot To: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" For archival purposes, forwarding an incoming command email to linux-kernel@vger.kernel.org. *** Subject: Testing for v4 scsi: target: fix recursive locking in __configfs_open_file() Author: activprithvi@gmail.com #syz test upstream 3a8660878839faadb4f1a6dd72c3179c1df56787 Signed-off-by: Prithvi Tambewagh --- drivers/target/target_core_configfs.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c index b19acd662726..f94c242eff97 100644 --- a/drivers/target/target_core_configfs.c +++ b/drivers/target/target_core_configfs.c @@ -108,8 +108,8 @@ static ssize_t target_core_item_dbroot_store(struct config_item *item, const char *page, size_t count) { ssize_t read_bytes; - struct file *fp; ssize_t r = -EINVAL; + struct path path = {}; mutex_lock(&target_devices_lock); if (target_devices) { @@ -131,17 +131,14 @@ static ssize_t target_core_item_dbroot_store(struct config_item *item, db_root_stage[read_bytes - 1] = '\0'; /* validate new db root before accepting it */ - fp = filp_open(db_root_stage, O_RDONLY, 0); - if (IS_ERR(fp)) { + r = kern_path(db_root_stage, LOOKUP_FOLLOW | LOOKUP_DIRECTORY, &path); + if (r) { pr_err("db_root: cannot open: %s\n", db_root_stage); + if (r == -ENOTDIR) + pr_err("db_root: not a directory: %s\n", db_root_stage); goto unlock; } - if (!S_ISDIR(file_inode(fp)->i_mode)) { - filp_close(fp, NULL); - pr_err("db_root: not a directory: %s\n", db_root_stage); - goto unlock; - } - filp_close(fp, NULL); + path_put(&path); strscpy(db_root, db_root_stage); pr_debug("Target_Core_ConfigFS: db_root set to %s\n", db_root); base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787 -- 2.34.1