From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755092AbdDMRhs (ORCPT ); Thu, 13 Apr 2017 13:37:48 -0400 Received: from resqmta-po-01v.sys.comcast.net ([96.114.154.160]:39516 "EHLO resqmta-po-01v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753113AbdDMRhp (ORCPT ); Thu, 13 Apr 2017 13:37:45 -0400 Reply-To: shuah@kernel.org Subject: Re: [PATCH] selftests/vm: Set mmap()'s fd as -1 for MAP_ANONYMOUS flag References: <20170315131926.461-1-sj38.park@gmail.com> <09a5192e-5a10-c314-4c20-55d57af40015@kernel.org> <20170328164227.95f3cc342da28b92be45e25e@linux-foundation.org> To: SeongJae Park Cc: Andrew Morton , Simon Guo , linux-kselftest@vger.kernel.org, "linux-kernel@vger.kernel.org" , Shuah Khan From: Shuah Khan Message-ID: <6996b3c5-36e5-8fa8-27a6-a95c9d856c36@kernel.org> Date: Thu, 13 Apr 2017 11:37:43 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170328164227.95f3cc342da28b92be45e25e@linux-foundation.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfFyJwFav3ILytjOou4thcu3DOu3qP7bg1iYbcQtb7WiCFFpWvKQG0KbyKcP0QHnuwJt97t2gBdEiuxRqk9TL6GgpB6EJurVtHmZabZx31daBXb5qDItI UMsji4F3ReQ4Nq126d9nXae7ih3MRYpm7Lzp7FOZkxe/CYBuXUMGTXWBmU7S7QT9VLba5+J6fRtlyjjCnOZRq2FTWsdgMoZOHlGVG9butb6v5k3xD/Sw1AO0 bNw3wP7pPziPsraGPl+m/gPa5EdHByWqlG7YjbACAqiROlH0g9rk0cmzOu+WxQZF7etYBdgsBPTrGnPczOK9qg3DSKoNyN6mJ7JgnKTMgHMLsuP8Khl7V+Tw XKOI/FZ1isof9hk75oAR5r0POrQ1uA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/28/2017 05:42 PM, Andrew Morton wrote: > On Fri, 24 Mar 2017 10:47:55 -0600 Shuah Khan wrote: > >>> On Wed, Mar 15, 2017 at 10:19 PM, SeongJae Park wrote: >>>> Man page of mmap() says that portable applications should ensure fd >>>> argument to be -1 if MAP_ANONYMOUS flag is set as below: >>>> ``` >>>> The mapping is not backed by any file; its contents are initialized to >>>> zero. The fd and offset arguments are ignored; however, some >>>> implementations require fd to be -1 if MAP_ANONYMOUS (or >>>> MAP_ANON) is specified, and portable applications >>>> should ensure this. >>>> ``` >>>> >>>> However, few mmap() calls under selftests/vm/ uses 0 as fd though they >>>> use MAP_ANONYMOUS flag. This commit changes the argument to be -1 as >>>> recommended. >> >> Hi Andrew, >> >> Do you have comments on this patch? Please Ack it if you would >> like me to take it thorugh ksefltest tree. > > Acked-by: Andrew Morton > > Thanks. Applied to linux-kselftest next -- Shuah