From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755476AbdJLVwo (ORCPT ); Thu, 12 Oct 2017 17:52:44 -0400 Received: from mail-bn3nam01on0069.outbound.protection.outlook.com ([104.47.33.69]:36576 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750990AbdJLVwl (ORCPT ); Thu, 12 Oct 2017 17:52:41 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Herbert Xu , Gary Hook , Tom Lendacky , linux-crypto@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Part2 PATCH v5.2 12.2/31] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support To: Borislav Petkov References: <20171007010607.78088-1-brijesh.singh@amd.com> <20171011165030.115696-1-brijesh.singh@amd.com> <20171012140816.6siefvahj6ww7uzf@pd.tnic> <622585ce-c575-29ff-0484-404b7cf684fc@amd.com> <20171012214120.upn2set2gichsejq@pd.tnic> From: Brijesh Singh Message-ID: <69a807a3-770a-662d-9cf0-25fad035a323@amd.com> Date: Thu, 12 Oct 2017 16:52:32 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171012214120.upn2set2gichsejq@pd.tnic> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BN6PR04CA0043.namprd04.prod.outlook.com (10.174.93.160) To BY2PR12MB0147.namprd12.prod.outlook.com (10.162.82.20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2c4086d2-ad0a-4e86-d940-08d511bb8e74 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:BY2PR12MB0147; X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0147;3:T8Q9X0PO9tVW/V3mvtPXYpJv3HJpAkVMv96Zt83wY1m3K8o5dB+Rkw8/xxzvJdceekzcstPJM3l4c8XgjcjLVmSHK8TuoKpcI/nFKLly4rTIg8dYHdr7Csi8SGj5MzkxstUTvS5k0/UwIX1mW59cz8gOdMFnkttCvwliTQuQNIu0iUUQwfcK2j/Gn/q0OYgG++bX1C+bNlgeileFMTuL5ULq3LZFPfxet9EsMztZnLwB1BBpgkLQCbYec+z/EnMt;25:Yrwyh42WOukBXZ+BwhPQOaLqo4N0xD1pGoh/5Fl3LAJtuyErfgf2gcg+WjBVyYSxVvY1Wzur51o8ngbeSl+2K/ClNM3vAXr5b2BXBL3V4kgrZUSvpdyf1TcoYYQotO99ngS30ngbWoyia1zyhOJQRXVnPceg2OOEYaUaEA3pmxOyb4VKnIn/4EFSVrqP5J5w/X1VqSldYeKjtR9Dwm6Z0/+S4l5R27T+h4FDExyO07ZUwRHpWi35voi77OY7LiEZ1AslcA7KoRUSYkXgxmnv+/eGHcnIM6AqNNDa/263BeyuP5VYks8rUPz4v6tXxKNOmoe2LfdKKgAESsMOxd4w8w==;31:AJjsBJqVAajsONZGHg/KenVTKyayuU4xgtQm0+roaLc2UxBb+i7AKm/A2RLFD+nfhVkb8CsMTQqYGXhfKiz7mH146CzOsYp17fsRmbBqZ38mmv9epxtuFqLZgRW3mmHvhYC0aRmOtxUoHK7COO9mVsvNXW6csw5x6K+AWoMmmMAVQuqm4+Sp1kKHSNO/oOQDmU57jEex89QxQyJcgYlRSpybBHP6QgzeSqhkeZuj3Zc= X-MS-TrafficTypeDiagnostic: BY2PR12MB0147: X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0147;20:r1JbpH5N3yt1NzihLFvIWAp3EI5jVIEaj4pr/+smvqnK+asN9TO/BPm65nFEs1sVjNCu0/p9Wa4SGlL/nSYX6RVYOAfTaUF+Tuj9aiEMw4J1ZfCF9MMHkAD041E4RJJlSTXXuCjFeZYRgKhMlaaGtNvd6ezxMKAFLe0bKs/IG6WDvaCvIp5VfVC+9PhcYJInXeWUH0nE73WPdtJujiqKOz2QzhpRU0mOy0ZbJuWc/u8StE+XOohPJ1Cxo4BWGhBooNPL2VSJtDiKPkUR/OhQcjpFhuIWF7VSfaIVP+tYIW6lLl3GTOCLOR3QxyrWHiXlf49jWvJuftMSsg7jLd561Q++WNH1psu3kU2ke3NqhJCXH5VDSnVYR/hUqk1zVsOBOj1axboip1VloEPRroxZS5PPuFHnjq8TehBZgusKXzUmUJ8H2VCkTOu9b0lzYMDGxyO3J201zJgjRn2lDLl5UkER3f3RNMvmS5WLyrgwsN4vxy73aI8wFIIhAk6t5eNY;4:s5Eu8wKcx+Z+6xKDBqZRfdWnbTzM0IJXymXOX0NN2ph3ssp/TDL97nRsBaOtp5anpdGl4Gi0yK0zdBxdt/+RdBGTmrQgDKe/eak0FQgd0yt0+VMZ7PPMdrHBVeZWe4LGPtW9Py5ZahVfDMdLGVazP8Qej9BLpUPVE59SGsg/9UDpwI6dfdf2dz19/w3rmszqdQNTYapn9VPH//nGmYxBKSZr/JbZphPX8wKE5xSkd0+xd34e50uJmDZlHPTEfUQN X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(20161123558100)(20161123564025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BY2PR12MB0147;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BY2PR12MB0147; X-Forefront-PRVS: 04583CED1A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(376002)(39860400002)(346002)(377454003)(5423002)(199003)(24454002)(189002)(23676002)(105586002)(66066001)(54906003)(65956001)(6666003)(16526018)(68736007)(6486002)(65826007)(33646002)(58126008)(8676002)(4326008)(5660300001)(316002)(54356999)(189998001)(478600001)(65806001)(36756003)(6246003)(53546010)(50466002)(8936002)(47776003)(305945005)(50986999)(101416001)(2906002)(81156014)(64126003)(76176999)(106356001)(31686004)(2870700001)(93886005)(31696002)(97736004)(83506001)(25786009)(7736002)(81166006)(3846002)(6916009)(86362001)(6116002)(229853002)(53936002)(53416004)(2950100002);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR12MB0147;H:wsp094352wss.amd.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTJQUjEyTUIwMTQ3OzIzOlp6L0MraTJBbHJFZEJFWEVzY3R1M0RLUm1O?= =?utf-8?B?cE81S2hGcFBDRHVYaVBtOHlacEFXcWlkR3VodTcyNXFLOERRKys0WGJhRStZ?= =?utf-8?B?aDY5SWJVdHVyVVBDbE1jVDVqZENJRHFmT1p4VnFJMXg0STBEd0NCR1JhVFZn?= =?utf-8?B?cHc1OHNlQ1poZS9ubzNiaE1zbHJBUkk3QkRzc0M5YysvSkNwOHJUWVUrVWxE?= =?utf-8?B?WHVMRjZlc2lPUlFFOEZtajlTQUtRa1podVhhUXcrOWh0bit0bkNMZlhDNTVR?= =?utf-8?B?eDZaM2xqRm83aEwzb3RnaVdDNHBDMDdLNG9OdkN3TVhyMWRPRnJSWUFlS0dK?= =?utf-8?B?engxbE1sZEpNOTdvc3VadHRZdW1WL1RTamtQSDJWWXlFTzJEcnh0dFZiY2pO?= =?utf-8?B?TWw4aHg3LzlNbTdFaExuc0l6dGhSMTd4dmdKWW5OMnNvUURGWVdScXFSTE1W?= =?utf-8?B?emhpbUIvaEp0Y2pZMzJDMDB0c3Q1aEFVRThScjl2eDh3N2xLcTRzSE1RbVp2?= =?utf-8?B?V3FsSi93RTN2NG0zZ3gxZTJuaFV1RHhvTW1CTHFoNEsrRUZza3lnMjRjdVFO?= =?utf-8?B?anRuUlV4UE9TWDEvT1djeUFtbmdCMUJDTTA1TzM1SUlQd0tsYXYrVCtjN3o5?= =?utf-8?B?cGJucjkyNE5PQjFOVC8xeEdrZkJZNFYzczJVbkR2NjdTZG5kV3lHUlVmSWpZ?= =?utf-8?B?VjR3M2xvSVhMMlNCaEtyMlY4VWpKMWhLS0RCajR1NVEzamVsMXlkUW1nODNX?= =?utf-8?B?S3JZUFpRV3ZUN1lCcGZSUjZORkZ1VGwwd1FaWkx2enA5ckcxNWlaZFZMSFI4?= =?utf-8?B?ejF2ZHpHSVM0WFpmbjJOTCtSVlY1RTBpcnFPbk9rajk2UFFWc2ZkRDlaSlNu?= =?utf-8?B?VGhiYnc0QndGWHduN1JHRHBYendTdUhMdGtvWGZxRGVXN1NPSFJHRkx3S0Vl?= =?utf-8?B?bDRuV2NQZEhaWFlvcmVpYXUzOGlEMmlxQXBYaXRBaGtlYXNvamJuN2tyRllw?= =?utf-8?B?MmVQNFV6Wk5RU004TnRsL2VIdnJiczN5WjhTb0ZEK1c1THpNMWxtcHRxNXh0?= =?utf-8?B?NnpOK0ZYNzV5dEszZnc1cTZLTE1xM3I5emlSbWF4bGNhbFM1MGlhUGhRNmZV?= =?utf-8?B?cUY2UlJPN09CUmlKa050YUxHUC84UXVEcGFodkVlT01pamsrdnJubXZ6Ny8z?= =?utf-8?B?b25NTW5UbFluYnh3RC9FVGljWE9mekUyUWFkVHAvMkpLbFdtbHNtSVFPc2hY?= =?utf-8?B?elR5ekhWNHRJcWF3bEJPR1Npc1pJS2dBblQydUUrYlprb0RYOFo2ZndWYlZj?= =?utf-8?B?YlF4TjN4M0dRU2VjSytVeEVtSXduUkpNSTFFUmZZdDg5OUZUTHBYMmFRUEtL?= =?utf-8?B?MzlGNitFTTFxaDU3WDZJVWpBUGlPRk9GeXRVMWd2MlF5aHlwU2xhTDVLV0tE?= =?utf-8?B?ODJOVkQ3OWs1akhrZW9MYjJpL2pFNVdnUVk2MWxtR0trWkdvcGc4eGUzSm10?= =?utf-8?B?b3dXSzVxT3hreDJzQ0xEZXl0M1ExNEV0eXpFRk8zU1RoeTRaY3FpUE11WGJy?= =?utf-8?B?UGgyQ1ZkKzIycTBHb3MwNUlrSzJIVkhrZnA0VTJXTUY2dWQ4UnJVNVNUWXR3?= =?utf-8?B?SUxjL20xR05rSm1peGZFNFBLejhJZHNCVmxKMklFQ24zOGNyRkZDQUZ6U1dY?= =?utf-8?B?bnZDRWRwbGE0dXpNOW13ejNaVjQ5ZGhvNFNFaHU3eFlsREI2aW0zT2UyUXNs?= =?utf-8?B?U0pCb2g5OU05VHc3SndPdTB5cnAxbVJKWEJuTDR1bitFMkRteXhZaWRwelha?= =?utf-8?B?Ty8xWlZkTlIrek1QU0tiaERJbkJEOW03WmtFd0RlOUVZYlAvaDQ0SHoxNXhP?= =?utf-8?Q?22zb1H+t0XZPx+4K6f1P1wmrwd0qIuYK?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0147;6:RCxUOzRdqR6vN7Wy+MIT9LTmZJvHZzLY3TAETp7FuH/hwi+qxcrOr+F7Uwi9FZ4JrZviDyiqmBVlRSq4LElAf1gLcTU5SCPj/K0jm4Pnq+Bw4jA1LFwHV9vGL/XmCoQLhN28KkqyN/5kH81iubNdpaLY4mr1C1aDTJkrWCy5XphzLL7dC6X9HvkhptMQGQu6YLsrjhQobBYvD0MC8qROofjUyuJh9GZwDh/LhOetdKw0sEmhkUo6KZvZXGtuXnhPRn7vNm2SwGAxfmYgaHYQ8JrlA0FXsMzxN6Jxg6NWZS6Z+lYVMpfwMomAEaxI/aina1x3WhyWj0+dphuMMeCAfQ==;5:AZbuJjpeKpZlQE9vAuzTpL216Khe5fTEBdxGZs07s20Bw+7/cgG4Y03d9DRbCTFJuuZTrfohOz/5WUR9xn2VAFLhp7CLAljrU/JVnu6cX0ThEvUN/BqK8pqLzkdM5ET2ufXTZsFStHvqk0FDy0X4LQ==;24:OtpyyMCdCzyqVAi9+6oabGFEIAVY+uyD4gTkEHYw095g0TY7jYR8FReTpkj5iEQA8EzHp8pBDWQzkkerkqEiLAtJCmyhBfR8QjsBEYLP358=;7:Lwy3LwiAGJVfvAyic67J08Y7qXcKf2lfLdjvylVwg6Kbbpex9oZzRPx7a02BUtHs9lzEWIoNNFqz5DH/fzbsefAy70wIO91hT4ZYQrsghGRy7JsBw//Gbps1eGOIzVcuvlqEwvBIRhLm0DkIEWJ7kIAkylcwMGa2U+FenkzWFO4La9DMmJ8/fNXtTHeETHvsc/RIF50du/nydo7/LEisI1A0dPEewjF7QveCT15N+TE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0147;20:UXDtwrsTX5tflZIjtBiGXhKPQ9U0QTZtTbC/klu9tW82LM88HytZ5mvpWfqIhsizM9h4gRep2Dyu3LtZJEvHvzSJGBrp7ijW/XJpEEDAsigYV7VS5I/DgdRSnKLzfmCQRI2eLRXXxQ/2V1Hcvg+2YmhlPQIetmUimUcYQcyBAWMmA8G8Ou++wvTrqwqz8HkJEkVK63mwqlS9nfNKokgXwu3rRPLmFSBSlDYrp1UHVYvfcl3A2IMrbWOof/2JGuGY X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2017 21:52:37.2028 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR12MB0147 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/12/17 4:41 PM, Borislav Petkov wrote: > On Thu, Oct 12, 2017 at 04:11:18PM -0500, Brijesh Singh wrote: >> The sev_exit() will be called for all the psp_device instance. we need >> to set psp_misc_dev = NULL after deregistering the device. >> >> if (psp_misc_dev) { >>   misc_deregister(psp_misc_dev); >>    psp_misc_dev = NULL; > Right, except we assign that misc device to every psp device: > > psp->sev_misc = psp_misc_dev; > > so the question now is, how do you want this to work: the misc device > should be destroyed after the last psp device is destroyed or how? We don't know when the last psp device is getting destroyed. Since we are  making the sev_misc_dev as a global variable then there is no reason for 'sev_misc' field in the psp_device. > Because after the first: > > psp_misc_dev = NULL; > > the respective psp->sev_misc will still keep references to that device > but the device itself will be already deregistered. And that sounds > strange. See my above comment, I think the simplest solution is remove psp->sev_misc