From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C64C02E8B71 for ; Wed, 8 Apr 2026 02:34:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775615645; cv=none; b=mmLQdA8uCWkF2AfM1NiET7TrjoZDAi695b6vOeMfTqtKdNZ8m9V+sN1sDiD2l6PEl5ovjvXrfeHspvVDkIl3+PcZJAwiu1l0rJ62i9yOxJSfMFpaA6xLYsKHJT/1VulSA9Y0ez9RJLyicvDbOF4hGCMQuNEW1X4mJN++eS02d8k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775615645; c=relaxed/simple; bh=XEQw4AiPshmaqiZhyZ4Apn5gTb8oHG3EbIzx2Ri1nAs=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=SDA4TSYfmWJSOhuTgItrR2hgS9PYLNmKwhGyAj3HMqP3OAoVSQCYw75LbeQ8p0cVJSyXub+H6vHWGn42Vh/j/fC49B+eqgl5DVK/8I77lSRfAxn/SMdXiGzb5AfNQrLnz8eDa1zGyR05oKE9UYq9q9Q/l+/ZRjffSheFIxrpbnA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GLVlbFNc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GLVlbFNc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC532C116C6; Wed, 8 Apr 2026 02:34:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775615645; bh=XEQw4AiPshmaqiZhyZ4Apn5gTb8oHG3EbIzx2Ri1nAs=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=GLVlbFNcCgdjLL+aQxRg4FNOafdiU149Y9CHP3hNIrRvRWteBBE3o+sx9SLRCj1oV d9pjtONrcO38r23ufYM5I3nxczwXHRZ7jMa+b5+SK86pON77n5S5L9g0di4+kPenI6 0CGvFA0Xo3e9/A/csoFexCB8us1MWSlX9ZSUXSek11rVJi5MZEP1Kf71UxX49Yog7J ekgkbUBxC5tZaAooI3xz8DAPrYGmEfY6Wwt5raoakHe/rmOa3Y+59NXtLH6zBvOQjF LkltRbtEIJCJe/rjEIteR7r2Glv8TxNcf6Pz1TDcBcq8Hm7aaQr1GMEUIz7v/k1aBL ubBv8nnY6Xh/g== Received: from phl-compute-09.internal (phl-compute-09.internal [10.202.2.49]) by mailfauth.phl.internal (Postfix) with ESMTP id E3BF6F40069; Tue, 7 Apr 2026 22:34:03 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-09.internal (MEProxy); Tue, 07 Apr 2026 22:34:03 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgddvvdefjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpeffhffvvefkjghfufggtgfgsehtqhertddttdejnecuhfhrohhmpeffrghnucghihhl lhhirghmshcuoegujhgsfieskhgvrhhnvghlrdhorhhgqeenucggtffrrghtthgvrhhnpe ejgefhkeefueeiuddtteetleeuveejudeluedvhedvhfffhedtuedtheegkeffleenucff ohhmrghinhepshgrshhhihhkohdruggvvhenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpegujhgsfidomhgvshhmthhprghuthhhphgvrhhsohhn rghlihhthidqudejjedvfedtgeehhedqfeeffeelgedtgeejqdgujhgsfieppehkvghrnh gvlhdrohhrghesfhgrshhtmhgrihhlrdgtohhmpdhnsggprhgtphhtthhopeejpdhmohgu vgepshhmthhpohhuthdprhgtphhtthhopegthhgrohdrghgrohesihhnthgvlhdrtghomh dprhgtphhtthhopegurghnrdhjrdifihhllhhirghmshesihhnthgvlhdrtghomhdprhgt phhtthhopehmtghgrhhofheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepuggrkhhrse hkvghrnhgvlhdrohhrghdprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghr rdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehgrhgvghhkhheslhhinhhugihfohhunh gurghtihhonhdrohhrghdprhgtphhtthhopehrrghfrggvlheskhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: i67ae4b3e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 7 Apr 2026 22:34:03 -0400 (EDT) Date: Tue, 07 Apr 2026 19:34:01 -0700 From: Dan Williams To: Chao Gao Cc: Dan Williams , mcgrof@kernel.org, dakr@kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , "Rafael J. Wysocki" Message-ID: <69d5be99ca69d_46de10093@djbw-dev.notmuch> In-Reply-To: References: <20260331214726.903274-1-dan.j.williams@intel.com> Subject: Re: [PATCH 0/3] firmware_loader: Fix shutdown ordering and reference counting Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Chao Gao wrote: > On Tue, Apr 07, 2026 at 01:24:03PM -0600, Russ Weight wrote: > >On Tue, Mar 31, 2026 at 02:47:23PM -0700, Dan Williams wrote: > >> Chao Gao raised a module reference circular dependency report result= ing > >> from *correct* usage of the firmware_upload_register() API [1]. The > >> module reference count is not necessary nor sufficient for protectin= g > >> against racing unregister against in-flight requests. After that is > >> fixed, a couple more cleanups fall out. > >> = > >> [1]: https://sashiko.dev/#/patchset/20260326084448.29947-1-chao.gao%= 40intel.com?patch=3D10705 > >> = > >> = > >> Dan Williams (3): > >> firmware_loader: Stop pinning modules on registration > >> firmware_loader: Stop pinning parent device per workqueue invocati= on > >> treewide: firmware_loader: Drop the unused @module argument > >> = > >> .../driver-api/firmware/fw_upload.rst | 2 +- > >> include/linux/firmware.h | 15 +++--- > >> drivers/base/firmware_loader/sysfs_upload.c | 48 ++++++++--------= --- > >> drivers/cxl/core/memdev.c | 4 +- > >> drivers/firmware/microchip/mpfs-auto-update.c | 2 +- > >> drivers/fpga/intel-m10-bmc-sec-update.c | 4 +- > >> drivers/greybus/gb-beagleplay.c | 2 +- > >> drivers/media/i2c/thp7312.c | 2 +- > >> drivers/net/pse-pd/pd692x0.c | 4 +- > >> lib/test_firmware.c | 3 +- > >> 10 files changed, 38 insertions(+), 48 deletions(-) > >> = > >> = > >> base-commit: f338e77383789c0cae23ca3d48adcc5e9e137e3c > > > >Hi Dan, > > > >Thanks for making these changes! Overall, the changes look good to > >me. However, when I apply these changes to the specified base-commit > >and attempt to build, I'm getting these errors: > = > (+Dan's new email) Thanks! I will note that thanks to the korgalore tool I am subscribed to = my old email, at least if someone also copies a public-inbox list. > Yes, I noticed that Sashiko reported them. Let's just say last week was "hectic". Sorry the noise. > >drivers/base/firmware_loader/sysfs_upload.c:229:24: warning: unused va= riable =E2=80=98fw_dev=E2=80=99 [-Wunused-variable] > > 229 | struct device *fw_dev =3D &fw_sysfs->dev; > > | ^~~~~~ > = > This can be fixed by applying the following diff to patch 2: [..] > the @module field should be removed in patch 3: Fixups look good.=