From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45A431E885A for ; Sat, 11 Apr 2026 17:39:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775929175; cv=none; b=lDuJfegC+Wt6hpe5/Rw7WiYXQh25AXUesNBosv7tQ7EtQu42Cax9Es/TVuquu1p7YK0YkZwXBK8gqE2qnj8VOjpJAtI0aKVKrkpp61Z1jGiYZvk5n151tvx9YlBGdUDS8sWEqARDhaZaiZy6eP1+HZSI3Ya7GtKvAGYJizWE3kw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775929175; c=relaxed/simple; bh=1Obsz5IeqIwbtrVfDCyn2N2B4nUcQpnOZSe85KEd3f0=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=LhNBTWnVvp53kfrfBesxBgwo0K1121IWVSNRciIQsAsQfmkuqNA1U/7HgcKpKW3q0uKeoCAYUiN+xvgqKqu6B+hGGvo9F0AFDv0Aap7/jeu1Y/jMgw0KqqSLhyg/Q3dYC/wfdUMeR+hq/iNGauR5FvZHWCSsDR2UJvDfFVU56oo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UUmLtI4u; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UUmLtI4u" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BDE3DC4CEF7; Sat, 11 Apr 2026 17:39:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775929174; bh=1Obsz5IeqIwbtrVfDCyn2N2B4nUcQpnOZSe85KEd3f0=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=UUmLtI4uwsAHy6EyOB04QwJuWzCHp7KUsqN17kEXtu4QmjEX1FKKQ+L3BXJqB7AZ6 t1JxP6gmfilpAiBzuZwORjk3VF7Z14G6PvAl814NUR7Sp/ilummOAEWwwpxOAFNOfG Tkn2yP/Un0NdNRq2gTBNSqvIPLa3MdwHj6zdFqS6GHy6Z8drWGcywzPDRycotuF5pM lNvRQilEy0i0Iwv/xlCmuGD8v0td6f5XGYMkPP7qzLRCA9f3i38JMxOCz9pR/sgrHW 4aeDo5+FY4mUNdhmZf2SXzOHnwSs0VLIZ2eBFeI/QoBTq/l+dkG1JCpuShBZFeiowz mPFFxEQUVJODw== Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfauth.phl.internal (Postfix) with ESMTP id B9FECF4007A; Sat, 11 Apr 2026 13:39:33 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-06.internal (MEProxy); Sat, 11 Apr 2026 13:39:33 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdefvdelkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecunecujfgurhepfffhvfevkfgjfhfugggtgfesthejredttd dtjeenucfhrhhomhepffgrnhcuhghilhhlihgrmhhsuceoughjsgifsehkvghrnhgvlhdr ohhrgheqnecuggftrfgrthhtvghrnheplefhiedugfdvieejtdelledtudeukeffjeejvd ejhfegveejfeeujeeltdelteejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepughjsgifodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhith ihqddujeejvdeftdegheehqdeffeefleegtdegjedqughjsgifpeepkhgvrhhnvghlrdho rhhgsehfrghsthhmrghilhdrtghomhdpnhgspghrtghpthhtohepuddtpdhmohguvgepsh hmthhpohhuthdprhgtphhtthhopehgohhurhhrhiesghhouhhrrhihrdhnvghtpdhrtghp thhtoheplhhinhhugidqtgiglhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtth hopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphht thhopehkvghrnhgvlhdqthgvrghmsehmvghtrgdrtghomhdprhgtphhtthhopegurghvvg esshhtghholhgrsghsrdhnvghtpdhrtghpthhtohepjhhonhgrthhhrghnrdgtrghmvghr ohhnsehhuhgrfigvihdrtghomhdprhgtphhtthhopegurghvvgdrjhhirghnghesihhnth gvlhdrtghomhdprhgtphhtthhopegrlhhishhonhdrshgthhhofhhivghlugesihhnthgv lhdrtghomhdprhgtphhtthhopehvihhshhgrlhdrlhdrvhgvrhhmrgesihhnthgvlhdrtg homh X-ME-Proxy: Feedback-ID: i67ae4b3e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 11 Apr 2026 13:39:33 -0400 (EDT) Date: Sat, 11 Apr 2026 10:39:32 -0700 From: Dan Williams To: Gregory Price Cc: linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com Message-ID: <69da8754369b4_6c31a10069@djbw-dev.notmuch> In-Reply-To: References: <20260327020203.876122-1-gourry@gourry.net> <20260327020203.876122-3-gourry@gourry.net> Subject: Re: [PATCH v5 2/3] cxl/core/region: move dax region device logic into region_dax.c Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Gregory Price wrote: > On Fri, Apr 10, 2026 at 05:02:00PM -0700, Anisa Su wrote: > > > + > > > + cxlr_dax->hpa_range.start = p->res->start; > > > + cxlr_dax->hpa_range.end = p->res->end; > > > + > > > + dev = &cxlr_dax->dev; > > > + cxlr_dax->cxlr = cxlr; > > cxlr->cxlr_dax = cxlr_dax; > > > > Running into segfaults without this ^ > > This should have been a purely non-functional change (the code is just > moving from A to B without changes). > > That would mean the original code should run into this too unless I > mucked up the move. I do not think you mucked anything up ->cxlr_dax does not exist in mainline.