From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f70.google.com (mail-oo1-f70.google.com [209.85.161.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 652B340DFD5 for ; Mon, 13 Apr 2026 06:19:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776061199; cv=none; b=V5dxQBVScCAmGofDucnW1lu8PFmhomOy/49iCp2pbCbcxC5Z85MaDxX37Ba43GYXf8CB092b5bjw9mi76pugyrLV2xGoNksjPXuhDcWvohdBK/MjmDtmfnHhgJiXsvFTDft+xDk/EnVov4cSYd5Kd2yP0GtZQ2mJRf8+0REPlnY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776061199; c=relaxed/simple; bh=EZFec7LvXoBYkjcb1yBQHfO/9srO/w0q5C6sRlmIcNk=; h=MIME-Version:Date:In-Reply-To:Message-ID:Subject:From:To: Content-Type; b=CpmodQUo3SUwQSVE0S+gKJ/cDOnOhKcN8GWhsQ1FFaJVQR5dok8NKWX6QUcPq8+ljuSNgtglLQab3lrJI6iUludunRfOhM84i7zrZz/wf8dspwu/BBaO9X5Tasc/3fyzxJ4o6YeUS6I82E4asx0bbUgzTxXYWVVIZ6JjJxi2gjc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; arc=none smtp.client-ip=209.85.161.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com Received: by mail-oo1-f70.google.com with SMTP id 006d021491bc7-68a2fa3375eso3919840eaf.0 for ; Sun, 12 Apr 2026 23:19:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776061197; x=1776665997; h=to:from:subject:message-id:in-reply-to:date:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cxvOaDiKnLwwu+4Wup4xsVYZQLwkACdHFJUdUGfe2S0=; b=rxLpkopLSfwe8Ar9TFkeAFNxuFMGYS8sKQ8Drl56qpvb1OBliphFXSLTRY5SOsn1EH OF35z4r7vA1Ss6s22o2I29cfBvVIbXBAXthi9v2et8JsgCGk//iAG/q02mn1dn7unmOT kYXMEANj6p/RyH4koh/uG98AtRSNvInqUa7KIsd0GmY9nycSSFvGNkkU2ek760sp9qnQ LJNtrIg6eFMygugAiEEDGaucytK/xARMOGcSCHfbHggeI1QgjQ9HFSZHXTWpto3z3rHx qQNZ2KOE+gyiuF+bjjH4sdcu3XQcxUYX7T85MQl5IVvKQn6yCD68BllDoB8NjY2N61yl ZyRQ== X-Gm-Message-State: AOJu0Yy8tFeNkeV+p5wArL2g7MA5a37w9o65015+AAlxp8t+RZOnkd6t OUbURhPaJcSfLjN+4quNjmv8G5dUcG5xofjM80RT8EVKKqH2N9P7wGNFzVQsDLsNg0jBj/sta2e 4v7eh6etf2EOjhOm81ykeqOrDpW8EgJqwGPC6FN94f+tTqBV0vq46mZU9unA= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Received: by 2002:a4a:da44:0:b0:687:7968:76fb with SMTP id 006d021491bc7-68a682afd11mr5671970eaf.9.1776061197504; Sun, 12 Apr 2026 23:19:57 -0700 (PDT) Date: Sun, 12 Apr 2026 23:19:57 -0700 In-Reply-To: <68e9715b.050a0220.1186a4.000e.GAE@google.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <69dc8b0d.a00a0220.475f0.0020.GAE@google.com> Subject: Forwarded: Re: [syzbot] [xfs?] INFO: task hung in xlog_force_lsn (2) From: syzbot To: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" For archival purposes, forwarding an incoming command email to linux-kernel@vger.kernel.org. *** Subject: Re: [syzbot] [xfs?] INFO: task hung in xlog_force_lsn (2) Author: ytohnuki@amazon.com #syz test diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c index f807f8f4f705..2645052042bf 100644 --- a/fs/xfs/xfs_log.c +++ b/fs/xfs/xfs_log.c @@ -426,6 +426,23 @@ xlog_state_shutdown_callbacks( struct xlog_in_core *iclog; LIST_HEAD(cb_list); + /* + * Shutdown waiters on ic_force_wait do not require callback completion. + * Once log shutdown has been established, they only need to wake, + * observe xlog_is_shutdown(), and abort with -EIO. + * + * Wake them before processing callbacks to avoid deadlock if callback + * processing blocks on a buffer lock and prevents the wakeup from being + * reached. + * + * Keep ic_write_wait wakeups ordered after callback processing so + * shutdown callback side effects still complete before teardown progresses. + */ + iclog = log->l_iclog; + do { + wake_up_all(&iclog->ic_force_wait); + } while ((iclog = iclog->ic_next) != log->l_iclog); + iclog = log->l_iclog; do { if (atomic_read(&iclog->ic_refcnt)) { @@ -439,7 +456,6 @@ xlog_state_shutdown_callbacks( spin_lock(&log->l_icloglock); wake_up_all(&iclog->ic_write_wait); - wake_up_all(&iclog->ic_force_wait); } while ((iclog = iclog->ic_next) != log->l_iclog); wake_up_all(&log->l_flush_wait); -- 2.50.1 Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855 Luxembourg, R.C.S. Luxembourg B186284 Amazon Web Services EMEA SARL, Irish Branch, One Burlington Plaza, Burlington Road, Dublin 4, Ireland, branch registration number 908705