From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A23CD35F169 for ; Mon, 13 Apr 2026 10:02:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776074572; cv=none; b=RMr/ZCQmHs33aMaHOuJc+sIFmaB8FQT5USgCG7Cvnf4/QC9YSxUKrEJUaywKUrHwRQHCGqqFR+BphqV5bt3mmvNME0tPNXE1cpwtJjqG4cZn7A5USeiVmtsqbsHSUv20A3eDHZTK8JShILuyJqC49VYeZL2M7smWU65ziH+6hiM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776074572; c=relaxed/simple; bh=/QhB53YIvyMpzYdrzNOUimUEXpIr+DIu/a6bYjSs+Fg=; h=Message-ID:Date:Content-Type:MIME-Version:From:To:Cc:Subject: In-Reply-To:References; b=rXBanrytNnX+EEmttuo2gnBJFlHrmq70rcLJcZS8RnQ4OKl+obuiK1SBxPwVAnrgkr8FKTAWl2B/7AY5arq0+0wCRIsDBVNhT93U4KT4FqalVbVhWvBCFwaXrvUFYf/BRR6s8DzRZP9LQ/duVRgnPwGtT0ph+f9XZgwFcib+1Qs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=B8b/VdKO; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B8b/VdKO" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-6712fd40860so2061293a12.1 for ; Mon, 13 Apr 2026 03:02:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776074570; x=1776679370; darn=vger.kernel.org; h=references:in-reply-to:subject:cc:to:from:content-transfer-encoding :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=/QhB53YIvyMpzYdrzNOUimUEXpIr+DIu/a6bYjSs+Fg=; b=B8b/VdKOTxUvtuTmrjMe3/P1V2azytrsZG7gfrr62bvhVpBdDVM6A/DrDOScQfC9tX K90tHVM2ZxYxT7pNFUoDmQEUtCmORda0dFid+1Rx+liNlPZ1PdlmGcVbXa5Ye8j4ZKMg MLxBMaUXlL8T/YPbzZsADKi2ieoSvpVq0DpEvOFTi0cs4LLnjwnWv17hW19EAJSqrt5D g1glkt98+ycY6qyOij1eHnNEZFsHsYYfz0poq45iw9hFPIThQCiuRPYh1iv/O62S/rhw 7enmDbnzhMJ/OkyP9Oy1RkZlGbTOwf/FPN1wJjmGTukiEAXFoUERkofRWGrcp0BQs3DE grfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776074570; x=1776679370; h=references:in-reply-to:subject:cc:to:from:content-transfer-encoding :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/QhB53YIvyMpzYdrzNOUimUEXpIr+DIu/a6bYjSs+Fg=; b=Fj+NltaFIz0cafxGQfLRwxZmOByJ2VSj9AkTQdq/BxIw3wTzoTOMUk/57lLY+28+Hd hCXWW/c5/xkPvYMPbGX+eQmqxukMRn15Mzr35rmumyiMEOHiNqAc6L+Zv/Xm5rKaEKE/ S+68/o706LQtvCZVaOQbGutZsds0hIbAxMErMR5Bli0D7BLQj1YXc8RuMUljY0rMHrrC QLLQdyUXfamo38hXrKADL7K9KqDGjfZc9xTBkojSdGZLO4R60FuqgCgY/wnJz9DTdd5k krz2D8Axq7D5Eft3bCT+qI7RiqVASqKiInQQiF4WyuwMh6RuWnzNmWQhE4xr5VmjTpHV mP1w== X-Forwarded-Encrypted: i=1; AFNElJ/tYyOt2Md4Z/mHIFLZ8t0wxbL1a0h4r3aC0gF2AS3PDGMwbo6vaX6YMafT1ackMMiBKzvcQiSwWC2dSUI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6NrmqzXOGfO9JWtPmKOte3ealFBdTsTfLZaMhApKQu6dmIGAX DMUmi5/YyoKk8XblkjaxhD6O+lBqEYj9gwjvCCBzVo0pgSJ++Sl4M5Ptkd9ihyBkAbc= X-Gm-Gg: AeBDievoM7oupYXypvpzLNYDw6PfBK6g55BZOAppMymkYoEI2MQEmYfSIghlsWwEXt0 zs2ZTuK9pNm/KTVyW6FoDprqddOnL3famYOakP/0otyRBeb8HQTykV9oKJyXD1DI+XoBwR8l/2U e3Y7vNWdT3I4RgmpCQ6ucSp9jy0HpFmxrzEyHgZBn7obN1XzdQQCiH0tYnBktlN+F2pJayz/35d LH5X93JHwcgYztnG/pZyJ2bQa7b7Cw/AgLoxsSUER22Z9hSiF2dYwAVU7NgQ0/B//6s/ulFaoHo NSu7cMMGwmhO41O79ilxNuXKC17Fb3k8YUFDBot0Ys2fJEP/MbF4SCdg/3/hxHMLrJzdXS24tiW HpNbD/O5XBjI6z/sEnB2TGXS4bGOdnGVX2RQx1W1Qn3m0TR32m8wi4W2uRSIKR7L/P1Fnsz2ZRt smZRz/o2hfE8jo86yRrm4XbJk0mJKR9zB6YCglyA6l0jOsnDFGM+O/pUbdR5C8Q9DNiZJZ3MnG4 ejmv6vMB73/Ap2FVwxZiF3F+yLNv/qhBnHnrNwScKvph1U7Y3X9gH08KxrEhw== X-Received: by 2002:a17:906:518a:10b0:b96:e11e:97c4 with SMTP id a640c23a62f3a-b9d72793974mr505593866b.20.1776074569608; Mon, 13 Apr 2026 03:02:49 -0700 (PDT) Received: from ahossu.localdomain ([88.202.160.248]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-670702eec4fsm2381250a12.6.2026.04.13.03.02.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 03:02:49 -0700 (PDT) Message-ID: <69dcbf49.a70a0220.194513.9708@mx.google.com> Date: Mon, 13 Apr 2026 03:02:49 -0700 (PDT) Content-Type: text/plain; charset="us-ascii" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Alexandru Hossu To: Dan Carpenter Cc: linux-tegra@vger.kernel.org, marvin24@gmx.de, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] staging: nvec: fix use-after-free in nvec_rx_completed() In-Reply-To: <20260412205057.386856-3-hossu.alexandru@gmail.com> References: <20260412205057.386856-3-hossu.alexandru@gmail.com> On Mon, Apr 13, 2026, Dan Carpenter wrote: > Add a Fixes tag. > Delete this comment. (Obvious). > Move this declaration to the start of the block. > Otherwise, it looks good. Thanks for the review. Will send v2 with: - Fixes: d6bdcf2e1019 ("staging: nvec: Add battery quirk to ignore incomplete responses") - Comment removed - Declaration moved to start of block Alexandru