From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC8103B7747 for ; Mon, 13 Apr 2026 10:02:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776074575; cv=none; b=ckvDR+GnWVgGa0coLNAhUWmlpqGhOtQIv/hQJd6DjBTH1CuCtgp4p2HUd5gwWBSmca2Gplyxk2us2J3gfebZzmnjOnP+n7FruqhDTvltNbFjP4l2o+WbXf8Z9+A2TNtXKh6FCXRPOjT36eQx1jWV52cDy6om8GX52Oxe97RCUuM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776074575; c=relaxed/simple; bh=jCS1ocvAKv8JD6gmGKMlriFZJ5S9rhifA0MxGTZuyqU=; h=Message-ID:Date:Content-Type:MIME-Version:From:To:Cc:Subject: In-Reply-To:References; b=en7kYTe3wJMmRlegLwvhnh19RHQtXhWNpITyCtOooHMy06CMy5F8OLonLyrwPGJIeE3LDulUjqqfx9yDL5iXSg3quQmXrRwoU/8kOeIccpxUd6jzG2ejVdQRdSz/AIXNbX5Bx+hwZGxjDx4D7jF52xMDms3k+qzoxTcYG+jHKK8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jQcsB2Am; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jQcsB2Am" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-671a827adccso503349a12.2 for ; Mon, 13 Apr 2026 03:02:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776074572; x=1776679372; darn=vger.kernel.org; h=references:in-reply-to:subject:cc:to:from:content-transfer-encoding :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=jCS1ocvAKv8JD6gmGKMlriFZJ5S9rhifA0MxGTZuyqU=; b=jQcsB2AmJ1gF6ptynG4aAp4nT2UuZUSUBocZmeMqbiaZY9WijE4C0HI1HqQ8LGlhdx CU+0M8QXUCt1QXRbC/YRFNdOXGziW/ZmUXQw/r1QQmaVIJahF3vbDqRkQHOjZyALOy7l P/xfScz6pj7kzmUhBJ4G243lVZifmnyUfpkZ2hVkXKizdUTiK531kjNhqGhvFu9IZBmS 5ljVnU6qtDrFbUBpNuSKezmvsiUKpC/rvG/A+xrqqzjnsknwpPAHYgIEsTLZJoszi2rU s5nsFyGBYm+gFxed3jcZW/onfqNL+yfoypityKuCSv4oVnHrVZedegAynusFEaoiRlgv MCjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776074572; x=1776679372; h=references:in-reply-to:subject:cc:to:from:content-transfer-encoding :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jCS1ocvAKv8JD6gmGKMlriFZJ5S9rhifA0MxGTZuyqU=; b=PrIoZ+j8EEqChXnrUgOiDDWn6CDOePjL/nMDMSDl9jeysaJ4+kn69LbnIew2Lxf+e/ aeyNQ733NFRbzYRsPr5AcxdpDODSiop60hMp92Ay5WTwGL9E9pI3f4r6b4fxS6N5Epe9 1l2KZgb9QIJwkpJZLSlsijPfV+W8JXRdryrks0J8dflBgS0FPlnbdOQwpavxEsezPtbe heMWdC0MZBux+IGkIN355pWOEs4kxqJSfamQnWK6NlEER6sSZS08Hm3gEcGJWG/EAqIS NYHqxt9gVSaGsMrxaiZyr3LHUbMC6nm5izFNYsMMQTxM36YDuZVVH0+racVkDb3aAS/O g54w== X-Forwarded-Encrypted: i=1; AFNElJ/iUtjIiF8wZUpMmjAKybuCagTnCAyp120bk5YS+YEKCOOpHa3bS+JLERSc1on/TUbyCZZxqqVqDPEsrdc=@vger.kernel.org X-Gm-Message-State: AOJu0YzSU9HfSNEXrp9Hh0xbNoSXgDbRo2QQGsnev9bMNN53YwzFecCr mV8XglH68BMDWqrVW7DHHv4vw+IxXBu/nCe9K8meDqt0kEcPLSsjN/Vp X-Gm-Gg: AeBDietG35EDmXrxo/nW0239kS9PO2YnJre9nF+iJ4b6t3ZQWCmplbhoTR2RKV0lw29 VH7j+FqysNySMB+fhDF+nnapG0AC/V7E7QV4P5zn0xc6vd25Rw2JaiwmOtEa1nj6uFnnp2XjGhA Dx4IHSeA3k2JjPKJLd5FPQKVAaSG74onVoKOr6ieoYDpqdCC5GfF1vUqCt6zYvUY+8/o2+8s4wk TaDY7+fjIKbcOdjRhHb/ccQrc5bGwjlBkg0AOXlfb2AzCnWZ4CJW8P2MteOzgVDOQOBB5HNouV1 48FEtKiDFPgBpEMtruVE1QrhwHKbcxu5RjrUmUjIimoRGqQdgYU6LgYkVqLnIHB0A0vy0LFfinF lt5KHUPWRXHCGdxQC+q/fkmHPVyCZ03+2jWtKzRt4jZKLRlFkcG5FO2U+SZZnGuevweEL4ZdsWL +9VTWxVauwuMTmifMOPgxzRENaNlv+cNH36oU0PzDtdSbf9kqoJ1Vm5bK9gq6Ef0ReW7DkUkZIO kAVQILULY+lP8CxKoofXCjeHZnK6gNRv1OKqOL2TnkqppoYQa/y3jKLV9VBa1vkhyH3uv2s X-Received: by 2002:a05:6402:50c9:b0:670:8b7b:5004 with SMTP id 4fb4d7f45d1cf-6708b7b512amr5945847a12.25.1776074571883; Mon, 13 Apr 2026 03:02:51 -0700 (PDT) Received: from ahossu.localdomain ([88.202.160.248]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-670702f071dsm2193723a12.4.2026.04.13.03.02.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 03:02:50 -0700 (PDT) Message-ID: <69dcbf4a.050a0220.1d6d81.c4df@mx.google.com> Date: Mon, 13 Apr 2026 03:02:50 -0700 (PDT) Content-Type: text/plain; charset="us-ascii" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Alexandru Hossu To: Dan Carpenter Cc: linux-tegra@vger.kernel.org, marvin24@gmx.de, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/5] staging: nvec: fix pm_power_off teardown in tegra_nvec_remove() In-Reply-To: <20260412205057.386856-4-hossu.alexandru@gmail.com> References: <20260412205057.386856-4-hossu.alexandru@gmail.com> On Mon, Apr 13, 2026, Dan Carpenter wrote: > At this point, we're unloading the driver so nvec_power_handle is > about to be freed. Is there any benefit to setting it to NULL? nvec_power_off() dereferences nvec_power_handle to send the power-off command to the EC. If pm_power_off somehow gets reassigned to nvec_power_off after our driver unloads (e.g. by a re-probe), the stale nvec_power_handle would point to freed memory. Setting it to NULL makes the potential failure mode explicit rather than a silent use-after-free. Since we are already inside the if() guard, the cost is a single pointer store. Alexandru