From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4238133EAED for ; Tue, 14 Apr 2026 06:22:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776147769; cv=none; b=TXcik/lziqXKU2KjCRIOU6CCPmMQvEkDReSzaGMqMhGRx5+c8JdENJLoD00XqMfuyYroBGE3wEA/GMPdkyuiWmXFbVFYXA6hct4exwtwHM0txnYv3zURO0DpS+4TP33nldqp9GeAhuObp2zbg2uNGOXdBwTiSfopKVZv6V+RKLE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776147769; c=relaxed/simple; bh=nKm0GbVKCHtHP0hrVGkVDigPvP6pst7c01jVOvopZME=; h=Message-ID:Date:Content-Type:MIME-Version:From:To:Cc:Subject: In-Reply-To:References; b=al++lvWUOeijMuqTw6p0ixjR7Mk86ljyoT3LoG6RMRRNN7j9cFCdA/dz1BIgTb6L/BfRge6CgPetKbjTCV4FSDII6SAVq13cdTstvFfz/nX1Oi7+gTVhZrt7aEPlkZLhAdjjp5tKQvEcPEiUlNylXcwP4dHwsoH5p/CIV2aL8yg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jvuX0ikd; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jvuX0ikd" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-66dd1b5bb6aso8182203a12.2 for ; Mon, 13 Apr 2026 23:22:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776147764; x=1776752564; darn=vger.kernel.org; h=references:in-reply-to:subject:cc:to:from:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=i7FXQ2tntyeG1C8OQfk9LnQuBp6YLBRP1mkqDhPOgr4=; b=jvuX0ikdIcfAJ8/iWbp9DgtWA2eBYzefwuygte4IUUz68hKbynEzX6357Y6U0QJAJ9 Zu7UKzSBDaMj2BW9M0pqOeH7MktNq6XsMMc3kb8nMJdjVHylP1846mUUtcmgl9StC7Y2 VvqWWddvUBYu4GQr6sxAm1MIF0XisHb+nWFjETnXJRlEAFVr1EXlN0vQt9KSlIXmHpRP cthA6I2zYi8wkCuK0hK+acvFf5u+mZssriTKlCwHnt6rGJ1JnD8xFMUllBvDjohbDJKY jAYrX8sotrAI4Ew0C2Chn2wpmzesWGUu5cWygiMG0w0+C9hAY6IoBsB7cHIXexd3adgg UteQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776147764; x=1776752564; h=references:in-reply-to:subject:cc:to:from:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=i7FXQ2tntyeG1C8OQfk9LnQuBp6YLBRP1mkqDhPOgr4=; b=pyv345T9rni2tQ1XqIF2Ih3moRwPmrwBrRNpHRPg7zqQa/C4SReTXsCED0a7KDJ6kx 3IcI1QlB/MloCrA462/dokkWQeIy3vZ/a1A16Ra2CQs6z0D2uBdc8Kf2hAvR7SSphvMM NyneL7zW51OCR819YvLLZcEGevnhHKHQGod9HD/TJxHZ+rsu4/ZipNVTOpEAMwBi+oJz 6ajl67uuVfdQaiad6TxzVwE8Q49OgRsjH34l/jWqVak5qYeuTpCCHyY9muHsJ1lDHT2W JTqMaGvDsylBoZJhJ0FBSWKRnj7BorjTcN44PTplYAe2ix8UVSlQ8vscDP7ZhSLrChn9 a+DQ== X-Forwarded-Encrypted: i=1; AFNElJ/0ir1u/C64XcQxwb+rsXPCMdTX5yK1aBAE9RZrKzIC0C92Q28cZjfJFME8tPPkITWj4XAKwl/R2SyoCOk=@vger.kernel.org X-Gm-Message-State: AOJu0YxvRoSj3O9qwR3VYo5UjkBoN/O6rjcm/6ZvwC8reJmXzdYm+SQH l4EQsyjq48dBC+lCzrXk1xiLBi0WScnxrvotCwi7+nDaC26m5tpfLW/G X-Gm-Gg: AeBDieuKHf2RyJw/yozqtYbsFBnF9tsLDd95/9mxk+r5sADFqCAcMhhLDr1uzed9RTU mFY6sPJyVbddqGnDxiZyVxcN4QUfCKlG4E4s51ILss3sn7xKmGgniB7mlc1d8W1rhg0wkz44Yyc S7jGRzLpNithOCmY5Owp0BRG//9PFeX+tvGbwi40dzttbMKLaXNu8yR66xpPYAVHtGV8lE5ghAA ZG9vazdqXG+N+4BE5/HRvkHkG0Cw7sU3m87YACUBxsKbKbdoE6cjED/6OjdPrrssm8FC9Sg9bJd 71vqN8jpTnT2FSPcmetIyXNsarRAfOnNwbDK3PfVjqRCdA9VrqhfX8m+A4ZVH0xk0Vp7wAczTF7 TZTXOz9LJzc62XFsLubLbLrfPnCz7n4pCcmPQgf56vBkgLa6ubu0gRLGqGLB76h4fzhvIiPTna0 T8pMExMzgiCFTety/0mGvG4AcYkpYGzuscTuFENQ0ynBgdFJ7UBlJp7IBuL8WgEX/3yLgPLbHCO Jzm4XeBuBp2XsGazMjCc6j0J9nBHyPI+gQgKqtf4oSED89UcjyCfRDcADo5FA== X-Received: by 2002:a17:907:c20:b0:b9c:b7c7:8a7f with SMTP id a640c23a62f3a-b9d7249947emr910336566b.1.1776147763849; Mon, 13 Apr 2026 23:22:43 -0700 (PDT) Received: from ahossu.localdomain ([88.202.160.248]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9d6e5c582fsm385453366b.31.2026.04.13.23.22.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 23:22:43 -0700 (PDT) Message-ID: <69dddd33.170a0220.e92ec.d295@mx.google.com> Date: Mon, 13 Apr 2026 23:22:43 -0700 (PDT) Content-Type: multipart/mixed; boundary="===============3219866366644994571==" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Alexandru Hossu To: dan.carpenter@linaro.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, hansg@kernel.org, stable@vger.kernel.org, hossu.alexandru@gmail.com Subject: Re: [PATCH] staging: rtl8723bs: fix heap overflow in OnAuthClient shared key path In-Reply-To: <20260413202824.740653-1-hossu.alexandru@gmail.com> References: <20260413202824.740653-1-hossu.alexandru@gmail.com> --===============3219866366644994571== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit On Tue, Apr 14, 2026 at 08:19:00AM +0000, Dan Carpenter wrote: > Looks good. > > Reviewed-by: Dan Carpenter > > p = rtw_get_ie(pframe + WLAN_HDR_A3_LEN + _AUTH_IE_OFFSET_, WLAN_EID_CHALLENGE, (int *)&len, > ^^^^^^ > Do we know that pframe has enough data? > > KTODO: check if pframe is large enough in OnAuthClient() Good catch. There's no minimum length check before the subtraction, so a frame shorter than WLAN_HDR_A3_LEN + _AUTH_IE_OFFSET_ (30 bytes) would cause pkt_len to underflow since it's unsigned. I'll send a follow-up patch adding the check. Thanks for the review. Alexandru --===============3219866366644994571==--