From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EDF23E8C65 for ; Tue, 14 Apr 2026 14:28:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776176915; cv=none; b=Rc7OW+XDF+I060XYy4061215OWtvZpI7flaj5Mzq2aRuyWHVPKPhWFhUENbfKnywF0N9YUEYIyAF4DZfmbwrhIfWQ/If3xlQEbhwtsX8oLkfbbdjGO2E94R79oFPsGtDGsC3vfRrUBi3yN7HIy8+sQ02ztKRci3Hdg0ShI9MZ9E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776176915; c=relaxed/simple; bh=U4pdr2GkpIWC2vNkg+yEuCLsbuNCTohVBAVAKaDkhlE=; h=Message-ID:Date:Content-Type:MIME-Version:From:To:Cc:Subject: In-Reply-To:References; b=DUrMYa73Bt+n/cQHPzQb/JP7+Kr2pQTpCmOXaAeBc/+6yc4tVsWJP1tXpesVUIpJJ2czJl4oxVq2S1LelB2rCSvx6uLKFyla7L7aJ5hZr9Bk5/PHoOTknhDmKwYrJ0bHWeZIFzxfkkCQ+JMT1WOl3y/SGwHJsTnM0DurN8MbL8E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K3np930U; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K3np930U" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-671c24f23b1so2325695a12.0 for ; Tue, 14 Apr 2026 07:28:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776176913; x=1776781713; darn=vger.kernel.org; h=references:in-reply-to:subject:cc:to:from:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=AmVhBhekni6akTViq7AtyVCpriJ3PfrjTpRNvwMcVvA=; b=K3np930UZzDo5kYlg7PQvQTwHNfLhn80375amyGWgjR6x3mSqCPYDNz5z6JFFzoJs6 uRKLkW/OL2yUg1YUIdHuVSqRo/xSloXlH3eyo8vNWiFinJvTyRMCU5XyNY9LpksxslQv kA/DN6lTaaBKKF1oAYUqFoyN6BywzGJFnh2xPV/8tSsNJ79i31LdR+HGyTOyyxPr/ERo jYix7ICF0Q3c7hP4tpL4xni18iS47/NKRPr0C3MKU5A2Pc76jLPGMAetqA9H1JXwJcWB L5WA7GQXeeB9g4KAoTq/gXqwsRq5DJvfR4hpUcYgBhSTzOA7jn0xm5HCmeHglMIQNZ1c XHxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776176913; x=1776781713; h=references:in-reply-to:subject:cc:to:from:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AmVhBhekni6akTViq7AtyVCpriJ3PfrjTpRNvwMcVvA=; b=Zb3O7kFAv0BBNnckxehj+8gsLGx88Ky2amzZDb8G2odoIexpC3/D+s5qSibkVCSBOQ eO5MCPoqdm/MD1IOZJVhlcP+G1p0ot5ciQ9p7RQESWUKm7zUcrjTHmELDGOEgQhrgUza 56Lq+UdJo0tYPpnFyjE45KXo+skJYFoU33bzuJdLx/itjxWl5bfkFXGnmMV6fDTjuPYp CdSmdbBFcd+eop4isp3Zf74zdM94D0gnkmAqP0he2BRKUxmnw87qQV9pzgewRlXUz8+E K/3JmOmfXynaUPxhypIZ08MWoomG79OoVCRwwFBKUORu5AiDUt8Jat80pgNe0isDX/oh kP6w== X-Forwarded-Encrypted: i=1; AFNElJ+S2XroIj1VTmw7Y1OwEq3uYaqccB81bwEY5qclI89hAhr460M+uqb3E4Uj7M1PZ1TqBUDZI7+YS13zUQE=@vger.kernel.org X-Gm-Message-State: AOJu0YxnZpWDjUGV/Zihxurb8XcPhoNnvTe/MhZzmOQRVyMiagx60loX uyaGY6JNIg2xb1xO9r7AtvF4VIXH0/YXEQdfkvUDOdNzmcA7iaGuxnP8 X-Gm-Gg: AeBDietfA8kealSRwU0CQvYpRVzVrfVHGSbH2FwP+uxZPd1TABIqKpunqg8CLTYWVPo R/wKL6fXhn6P1UqUYVQFLE9r1oaeAhwqHcYCYPNwtsv29LUTrrq38Qbf05tEWlXWVglkHhvoQlr BqzYhoffCnFogOZfthh0uCmbCXOYpxAkdJa9VpakXxG2nQcxS2TH9IUb8Hm9P+pcw97hYL/Rias 0AvMW7hHqGGvceW/tXcysO1fu/1CYpqBvOigpcUfbUtuf6viKBBV9kHQR0fCElOwHhauTqPkPfV KWVdbZrH35FNBmZVMhkF4qpcWaUAWQ0sy05Qmiz/hQOo5wOiUJckIct1b0JnpX4tZqnLOMCBtxn VFGEGvrXacUAF2GDUrhNoaqFOVnPvEmvd7mUadm3pUn7DHnMMf83y4WCoK0sjD51ZxfehBE9KfX g5+ZDZmrVrOxsoCLCy6kIVByY/aZoZeFdm3UrM5oO61kBzNGRBfVVDRfdYv8iFNZXblWm3oSk9s SgIs/6e2bm9XznS9CkW8klZ8HpsxNdO40eCSk2n8uLbYAcCptIclsSG34Fx/A== X-Received: by 2002:a05:6402:4548:b0:66e:2f86:ab1b with SMTP id 4fb4d7f45d1cf-6707903f71fmr6647756a12.8.1776176912385; Tue, 14 Apr 2026 07:28:32 -0700 (PDT) Received: from ahossu.localdomain ([145.94.221.163]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-67205b178f9sm278929a12.29.2026.04.14.07.28.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 07:28:31 -0700 (PDT) Message-ID: <69de4f0f.a70a0220.22ada8.489a@mx.google.com> Date: Tue, 14 Apr 2026 07:28:31 -0700 (PDT) Content-Type: multipart/mixed; boundary="===============1904756288140883639==" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Alexandru Hossu To: dan.carpenter@linaro.org Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, hansg@kernel.org, stable@vger.kernel.org, hossu.alexandru@gmail.com Subject: Re: [PATCH] staging: rtl8723bs: fix frame length underflow in OnAuthClient In-Reply-To: <20260414100804.871764-1-hossu.alexandru@gmail.com> References: <20260413202824.740653-1-hossu.alexandru@gmail.com> <20260414100804.871764-1-hossu.alexandru@gmail.com> --===============1904756288140883639== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit On Tue, Apr 14, 2026 at 03:02:00PM +0000, Dan Carpenter wrote: > Do we know for sure that this is within bounds? And there is earlier > code which pokes in pframe as well. This code is quite complicated. You're right, I missed that. get_da(pframe) at the top of the function already accesses pframe+4..+9, and GetPrivacy() reads the FC field, both without any length check. I'll add an early check against WLAN_HDR_A3_LEN before any pframe access and send a v2. Thanks, Alexandru --===============1904756288140883639==--