From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3BE21E5714 for ; Wed, 15 Apr 2026 06:03:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776233014; cv=none; b=ptoLAZfOTRe2Tcq4798fI3ixu26Huld33swefHAa7Z3ipN0NVzNWYtz4MqSS1e24aYbeNI0D8TBiBEENVcP5fBxc4eMrSQlZ9eTg/51RZulNXtDnPA7j/71a0X1C7/mgEhG92muoepmJbZ5GsF1MHP5kFUQBve/eV/OCpWANlyA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776233014; c=relaxed/simple; bh=cyjgq35kTUANpRors0UJ2MyAA8YEkpvyucVoJcuXyxI=; h=Message-ID:Date:Content-Type:MIME-Version:From:To:Cc:Subject: In-Reply-To:References; b=NTiN662oVyg1ZJ7pc5cnEA2vNdU3tachng3S9NKPsl21kh+a7WrJ+s53vIZj6wJZ7k5sOaz+kL+Z35hBTsIi1rrQQNICijLvzLdb8/dG2TA1mEW4smpdj/Cr5cWKkTckM6Joj6RFF00zMq9i7dxAkQTK28q9R2Brvv4IAgih9KU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FHhAr1Ss; arc=none smtp.client-ip=209.85.222.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FHhAr1Ss" Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-8cbb6d5f780so567535785a.1 for ; Tue, 14 Apr 2026 23:03:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776233013; x=1776837813; darn=vger.kernel.org; h=references:in-reply-to:subject:cc:to:from:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=cyjgq35kTUANpRors0UJ2MyAA8YEkpvyucVoJcuXyxI=; b=FHhAr1Ss3JNstmp2wN9mOKvNClfd7PuRcHwfOZSAib2HiXP+sgDVaVa2nhNOhWFBH/ qkDvNUZG/1Jbnxh2ODSxK8QLTvJVvnEKBevSovP/S6ElQt8drkJEuxeLqfLVFSKLm5+r uVEdySUvCyNJf4Ashtc9Pg/vVXPiIlqRILIxAesgIdiEUxsTETHmKaiRBC2oWMe7Ktr1 KL08VIEBiTQ9bs7q2yCuzwZpOXt4cf30eDWnN3y0Oy9v/iirCiQhGqcRWr2+7zaHRGfp j2iKxEoWp3Q1zPfoGOG+N/dSAavinIdSPlnDnwdszSq3KWQvVKMifd9tkd77HkMPCwVC 7SHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776233013; x=1776837813; h=references:in-reply-to:subject:cc:to:from:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cyjgq35kTUANpRors0UJ2MyAA8YEkpvyucVoJcuXyxI=; b=Z4GxSW+WUXXzpEiIPk9zcM5J0EsnAx1X6FJaJekFNpanGzMKL1py5Wl5dkjhpnGz4l 7I2ECgxIShZepeJOW+i+ly/1HD2VIqFZW/sqWIdOKJQBUDwINOqWtJ3v1PjrEt7aF0QM YJoYX8CLmAg8XfiafjY36byKVQpSoizz4RqwGP/CVQrzjRduGWiZnkBXVaddPML5LoK7 YxvXUWPiAtSitxV00oBnc5BrPs84bENE310AzXlF6eAbUKs4WsEQXU65Lj8ZGJDKag+F 48YbQecA8bG3Yz/bEX0R8Rv6SNvQFzC5uKLQGNi7nP3XraEPqbpu5nk5HWXI9BdFIHLz o9Tg== X-Forwarded-Encrypted: i=1; AFNElJ8aUEVa8vs8nQteWF0AV8xME0MYv/qR97v82QWRdEJ8Z1/hSBTQh0xyJdatVvuEOVFdtDTN82a/zg276P4=@vger.kernel.org X-Gm-Message-State: AOJu0YwA1yZWq/NA6CHEHhQYWlHiFzASX2aTCwmNF4vD/ZhHzwvOn9vS k8mdGB5RVkfSxvBkfTN5yu16HpPBa/17W5NudKcwZtoVwlwPz/ikAAuCwFenXP6aufHmGw== X-Gm-Gg: AeBDieuKy8K77o3tfB7TQfP2minmV8hd3KtXxmiwStY8cPBCvwFwgi7wCz9Wkh7fhy3 ibC7fqt24cfbqiB34nUgwYlag5eTRdcNbYy9URVq3ythmGyQlQUlikoG1gBUP/P/76ZAebevwKQ Gmgq8nQ1QbMMEBQe1O5SXvEQPt4jq+9fqyWryBYfo7A5WQzi7Pka16hOR93N0HDi49y/FUh9tk2 8zfVfR2iaVCRXPx0XnKSDunhHBXL7wbIjxgZ3xz+WSRZVwjnRzA0AcGD22gTeUhKEudVpFjrIun UefPAz2vO/Jkmy7m5e4Jz3+1fRxDd2U82up/xTk6WAcwD0+RL6pqagjZgW/20uxHH5ksYiZM+jD OU76alXu6trrkvWjXLjJNZdU8B2Un36iPMjxSDrCdiXNPiRXX3qvzKqWcmsfAXv1FkKFKBj4AOo N/kr+z/BhNOP1RH7j/XM/nkWs7iDsHSHZ4HLoI8FR573R218bxGBCbrh08N3zl6kCc1IR5OBl0m qbCKNJAMw== X-Received: by 2002:a05:620a:2585:b0:8dd:7919:153d with SMTP id af79cd13be357-8ddcd1195c1mr2907886285a.7.1776233012579; Tue, 14 Apr 2026 23:03:32 -0700 (PDT) Received: from tdc4045031631.internal.cloudapp.net ([20.63.37.123]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8e4f2345c3bsm53523685a.24.2026.04.14.23.03.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 23:03:32 -0700 (PDT) Message-ID: <69df2a34.050a0220.2d53f.b61c@mx.google.com> Date: Tue, 14 Apr 2026 23:03:32 -0700 (PDT) Content-Type: multipart/mixed; boundary="===============7568368645748790231==" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Ashutosh Desai To: edumazet@google.com Cc: netdev@vger.kernel.org, linux-hams@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] rose: fix OOB reads on short CLEAR REQUEST frames In-Reply-To: References: --===============7568368645748790231== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Hi Eric, On Mon, Apr 13, 2026 at 11:11 PM Eric Dumazet wrote: > rose_process_rx_frame() callers already call kfree_skb(skb) if > rose_process_rx_frame() returns a 0. Your patch would add double-frees. > > Your patch is white-space mangled. Thanks for the review. Sent v3 with all issues addressed. Best regards, Ashutosh --===============7568368645748790231==--