public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: syzbot <syzbot+fa603ae6b02658401ca7@syzkaller.appspotmail.com>
To: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Forwarded: Re: [syzbot] UBSAN: shift-out-of-bounds in dbJoin
Date: Fri, 17 Apr 2026 09:19:57 -0700	[thread overview]
Message-ID: <69e25dad.a00a0220.1bd0ca.0008.GAE@google.com> (raw)
In-Reply-To: <69345a63.a70a0220.38f243.0031.GAE@google.com>

For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com.

***

Subject: Re: [syzbot] UBSAN: shift-out-of-bounds in dbJoin
Author: tristmd@gmail.com

#syz test: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>From b3eba06211261ff42d58377c02b45bf48aae8f82 Mon Sep 17 00:00:00 2001
From: Tristan Madani <tristan@talencesecurity.com>
Date: Fri, 17 Apr 2026 16:15:14 +0000
Subject: [PATCH] jfs: fix shift-out-of-bounds in dbJoin
dbJoin() can receive a corrupted newval from on-disk metadata that
exceeds the valid range for the BUDSIZE macro's shift operation.
When newval is larger than budmin + l2nleafs, the shift produces
undefined behavior detected by UBSAN.
Add a sanity check on newval before the shift to reject corrupted
values.
Reported-by: syzbot+fa603ae6b02658401ca7@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=fa603ae6b02658401ca7
Signed-off-by: Tristan Madani <tristan@talencesecurity.com>
---
 fs/jfs/jfs_dmap.c | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/fs/jfs/jfs_dmap.c b/fs/jfs/jfs_dmap.c
index a841cf2..4ad9b34 100644
--- a/fs/jfs/jfs_dmap.c
+++ b/fs/jfs/jfs_dmap.c
@@ -2864,6 +2864,9 @@ static int dbJoin(dmtree_t *tp, int leafno, int newval, bool is_ctl)
 	if (newval >= tp->dmt_budmin) {
 		/* pickup a pointer to the leaves of the tree.
 		 */
+		if (newval > tp->dmt_budmin +
+		    le32_to_cpu(tp->dmt_l2nleafs))
+			return -EIO;
 		leaf = tp->dmt_stree + le32_to_cpu(tp->dmt_leafidx);
 
 		/* try to join the specified leaf into a large binary
-- 
2.47.3

  parent reply	other threads:[~2026-04-17 16:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-06 16:31 [syzbot] [jfs?] UBSAN: shift-out-of-bounds in dbJoin (2) syzbot
2025-12-07  3:18 ` Edward Adam Davis
2025-12-07  3:52   ` syzbot
2025-12-07  3:52 ` [PATCH] jfs: Add a sanity check for budmin Edward Adam Davis
2026-04-17 10:11 ` Forwarded: [PATCH] jfs: fix shift-out-of-bounds in dbJoin syzbot
2026-04-17 16:19 ` syzbot [this message]
2026-04-17 19:19 ` Forwarded: Re: [syzbot] [jfs?] UBSAN: shift-out-of-bounds in dbJoin (2) syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69e25dad.a00a0220.1bd0ca.0008.GAE@google.com \
    --to=syzbot+fa603ae6b02658401ca7@syzkaller.appspotmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox