From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f71.google.com (mail-oa1-f71.google.com [209.85.160.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CBE834EF03 for ; Fri, 17 Apr 2026 16:21:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.71 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776442862; cv=none; b=gbFeBytyICi3IamEddAFsbXYb6IqKC3z090F2dMBt/gMC/GJAEGEHXf1ucmWsvwNb6pc6nmsuoxJqWgVPylWD5zKoImYPZ1Vzb2S341zyQ74g7AY2MDrAGchn580LxskLQR9i2Cfvk4XtwmuRMyO0k0Zp6yVPBuvID1PML1UX1k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776442862; c=relaxed/simple; bh=OojtW2UfqwC59VOoQRfjjfhRj7w3zJjJABwGNUfbmPQ=; h=MIME-Version:Date:In-Reply-To:Message-ID:Subject:From:To: Content-Type; b=kD/BxGl9nI/DhnPfSX75zNnxcVa1QnuqlL6N1/k62Rntvf3vHll8qK9zZCnpzWk64hgXh2tU06y4nPjwJD5KR4RDzJqnF0nCLHDoTLqSYe4rjOt5ZTnLVeRhNqVY1p3l08RlipFpVizLgO0VzTxkbicVT7ieLrGDS3CC+QZO5H4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; arc=none smtp.client-ip=209.85.160.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com Received: by mail-oa1-f71.google.com with SMTP id 586e51a60fabf-40ee506cf49so1274866fac.2 for ; Fri, 17 Apr 2026 09:21:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776442860; x=1777047660; h=to:from:subject:message-id:in-reply-to:date:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XsRC4r2Z7uf5FOQWH6Ik+dtkhuyTwgXDIN1BMmLeDzw=; b=a9e7Vs6BUiryXHPtrPyTy33t13tqxEXUb43+nfL8NOcOxzKg7uw5iDMqr2H/EWWqu/ na0WbVRl0hUrfsbbR9iv+IHigr/3yDWb7c//OR5t/efhxEdqzkxtk2H4K83E2U099PK7 CfRQoSm/aESIn75iWeW/jIEpS8IZ3p/dEE7GOvQr+bGSAZTc60cp1ZX9VGIc6OeKQK8H tfWCPAntVTb8vqMJgdUXSgkuNMV8WRwuH/Lrb+P/t+rsYYplrCjrIV3Vjup+nTEBOHEQ CT9N8MG8QCjA86J3FLV6Zn2j4r8WT2+2rS3JYxT8JDQuuYZ0fC3tlFxj3llONxPBFKWk qbRg== X-Gm-Message-State: AOJu0Yysg7LorAHnT03sR0ma2B3yce00R59aOu4shdZNM+qV1V6pgpc+ 0AGshR5frJ3w8/4MIc8zdElrhNn83RQdTZ9SmWv9yJR1SjvpOiEYMo+n5CRXrExPcp/l/yTHb3Z bX9b8mpgWdq5Z6xBiszj+SB5YbtlKKIeLD57Reu+F7aupDzN20ucX5xYhKN8= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Received: by 2002:a05:6820:220d:b0:692:234a:e202 with SMTP id 006d021491bc7-69462f296dfmr1896255eaf.55.1776442860482; Fri, 17 Apr 2026 09:21:00 -0700 (PDT) Date: Fri, 17 Apr 2026 09:21:00 -0700 In-Reply-To: <683ea90b.a00a0220.d8eae.0060.GAE@google.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <69e25dec.a00a0220.1bd0ca.000b.GAE@google.com> Subject: Forwarded: Re: [syzbot] WARNING in udf_fiiter_add_entry From: syzbot To: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" For archival purposes, forwarding an incoming command email to linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com. *** Subject: Re: [syzbot] WARNING in udf_fiiter_add_entry Author: tristmd@gmail.com #syz test: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master >>From 8952d1a6c0f2ba60983d065a704e20171d843b57 Mon Sep 17 00:00:00 2001 From: Tristan Madani Date: Fri, 17 Apr 2026 16:15:18 +0000 Subject: [PATCH] udf: propagate iteration error from udf_expand_dir_adinicb() udf_expand_dir_adinicb() returns 0 unconditionally after iterating directory entries, even when the iteration fails. The WARN_ON_ONCE(ret) fires on corrupted filesystems but the error is discarded. Remove the WARN_ON_ONCE and propagate the error return value to the caller. Reported-by: syzbot+969e250fc7983fc7417c@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=969e250fc7983fc7417c Signed-off-by: Tristan Madani --- fs/udf/namei.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/fs/udf/namei.c b/fs/udf/namei.c index 9a3b7ce..2249b79 100644 --- a/fs/udf/namei.c +++ b/fs/udf/namei.c @@ -207,14 +207,9 @@ static int udf_expand_dir_adinicb(struct inode *inode, udf_pblk_t *block) udf_fiiter_write_fi(&iter, impuse); } brelse(dbh); - /* - * We don't expect the iteration to fail as the directory has been - * already verified to be correct - */ - WARN_ON_ONCE(ret); udf_fiiter_release(&iter); - return 0; + return ret; } static int udf_fiiter_add_entry(struct inode *dir, struct dentry *dentry, -- 2.47.3