public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: syzbot <syzbot+ea5aff81e35d189b9335@syzkaller.appspotmail.com>
To: tristmd@gmail.com
Cc: tristmd@gmail.com, linux-kernel@vger.kernel.org,
	 syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] kernel BUG in __ocfs2_page_mkwrite
Date: Fri, 17 Apr 2026 09:21:20 -0700	[thread overview]
Message-ID: <69e25e00.050a0220.1de265.002c.GAE@google.com> (raw)
In-Reply-To: <177644287830.3790093.7729454483587611807@talencesecurity.com>

> #syz test: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master

This crash does not have a reproducer. I cannot test it.

>>From c2c3a03773b08b55240f1a32b79b20b57bb88076 Mon Sep 17 00:00:00 2001
> From: Tristan Madani <tristan@talencesecurity.com>
> Date: Fri, 17 Apr 2026 16:15:19 +0000
> Subject: [PATCH] ocfs2: replace BUG_ON with error return in
>  __ocfs2_page_mkwrite()
> __ocfs2_page_mkwrite() uses BUG_ON(err != len) after
> ocfs2_write_end_nolock(). On corrupted filesystems, a short
> write triggers a kernel panic. Replace with proper error
> handling that returns VM_FAULT_SIGBUS to userspace.
> Reported-by: syzbot+ea5aff81e35d189b9335@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=ea5aff81e35d189b9335
> Signed-off-by: Tristan Madani <tristan@talencesecurity.com>
> ---
>  fs/ocfs2/mmap.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> diff --git a/fs/ocfs2/mmap.c b/fs/ocfs2/mmap.c
> index 6c57015..d999d88 100644
> --- a/fs/ocfs2/mmap.c
> +++ b/fs/ocfs2/mmap.c
> @@ -103,7 +103,12 @@ static vm_fault_t __ocfs2_page_mkwrite(struct file *file,
>  		goto out;
>  	}
>  	err = ocfs2_write_end_nolock(mapping, pos, len, len, fsdata);
> -	BUG_ON(err != len);
> +	if (unlikely(err != len)) {
> +		if (err >= 0)
> +			err = -EIO;
> +		ret = vmf_error(err);
> +		goto out;
> +	}
>  	ret = VM_FAULT_LOCKED;
>  out:
>  	return ret;
> -- 
> 2.47.3

           reply	other threads:[~2026-04-17 16:21 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <177644287830.3790093.7729454483587611807@talencesecurity.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69e25e00.050a0220.1de265.002c.GAE@google.com \
    --to=syzbot+ea5aff81e35d189b9335@syzkaller.appspotmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=tristmd@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox