From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f197.google.com (mail-oi1-f197.google.com [209.85.167.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7E04346FAE for ; Fri, 17 Apr 2026 16:21:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776442917; cv=none; b=iF4/SR+mOMxAlkcNEQ816KR/HFQpGjmCBm9Ffrdkcb+wF6ABmqXPuBjfUk4KBVgVKEGV/f4M2siLGZjAbsJtSgiAQjbGZjknliRTG76tkSPFF5hzkhnsR6zYVplRShJq+4dxZnUm7uHsm1dAH856aMI5D6UIqCsLPvjVPbtZm00= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776442917; c=relaxed/simple; bh=UktUzQRWBlxx0yjuyNgScyn8JPYKraYWBgVioeqgGwY=; h=MIME-Version:Date:In-Reply-To:Message-ID:Subject:From:To: Content-Type; b=sRxfYa2c5zWFOHx0vTt2g1XIe7YPj2TFcx3zKv52vElnc0ElXCbigcn3DRIFgJLF0WX/AerT3+Kp5F0d/iHEkVG4cyowX9IT8iPMRauhfjpBxNyfK0XA+pt2YhSLkYtEJXO3lQ6HTIuMIrUWPXur7MDhkhsP4AVNqf5wfEemXRc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; arc=none smtp.client-ip=209.85.167.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com Received: by mail-oi1-f197.google.com with SMTP id 5614622812f47-467e8ec004dso1238798b6e.0 for ; Fri, 17 Apr 2026 09:21:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776442915; x=1777047715; h=to:from:subject:message-id:in-reply-to:date:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ahkh/EW18E2ch5YuBG8185KeYQC4vKeTmG8wVjOy0mM=; b=AzkXqazfZJSZeBy5LgXhtxQZbbqhIxASA2SGmw/KdTfcNsU+/XNfMKBh/oY3W32/06 VMiBI4P/mBaxhXf0AQnvmG9mAcNNzS12AvirkmLbwCQtuKtJjEapPpSWIZIqBWd0e9N6 IwvEsmgXP8BujXM7iqnGowDwu1qoH8zOjumDCZUs0CUEQqd6qjbzYmLFb2TrlG2fwAQo igHWH801xl7kMutN5z+g/d4ig/5WOKUxxbkACAXDYXq61idqFYh+XpmZshYGAoSDimy/ f0TB+Bh87WfWrTtCoMW0ogh7xVch6OK3V744gZI2YJcqzENRTcBLpZ8uqRZCHZT4SBqS t9zg== X-Gm-Message-State: AOJu0YyvOk2y2es8OqLvbJyrtlAXZzfCVFUl96h6DjVLnIsEs4+Xm9GR rfwDAGwoECuRapUiZ64BX44mbFLUvlr7XlJehBJ5AuxplusTgNsBoeoE9RUHGnREPkLf5J+F3iq CLvlgblG9qGdf0qi1svyW5UWgoM2IjcrjVE8l93rasmBHwHyozMGQlHavImA= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Received: by 2002:a05:6820:4dfb:b0:680:6d72:9399 with SMTP id 006d021491bc7-69462e64465mr1973670eaf.24.1776442915036; Fri, 17 Apr 2026 09:21:55 -0700 (PDT) Date: Fri, 17 Apr 2026 09:21:55 -0700 In-Reply-To: <000000000000ca86690612e7cacd@google.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <69e25e23.a00a0220.1bd0ca.000e.GAE@google.com> Subject: Forwarded: Re: [syzbot] WARNING in gfs2_check_blk_type From: syzbot To: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" For archival purposes, forwarding an incoming command email to linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com. *** Subject: Re: [syzbot] WARNING in gfs2_check_blk_type Author: tristmd@gmail.com #syz test: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master >>From a57e64056f6b6fa2ede96b624b49baeb5269478b Mon Sep 17 00:00:00 2001 From: Tristan Madani Date: Fri, 17 Apr 2026 16:15:20 +0000 Subject: [PATCH] gfs2: remove WARN_ON_ONCE in gfs2_check_blk_type() gfs2_check_blk_type() wraps gfs2_rbm_from_block() in !WARN_ON_ONCE(), triggering a kernel WARNING on corrupted filesystems. Replace with a plain error check and map the error to -ESTALE for the caller. Reported-by: syzbot+26e96d7e92eed8a21405@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=26e96d7e92eed8a21405 Signed-off-by: Tristan Madani --- fs/gfs2/rgrp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c index 5988a16..da94c25 100644 --- a/fs/gfs2/rgrp.c +++ b/fs/gfs2/rgrp.c @@ -2625,7 +2625,9 @@ int gfs2_check_blk_type(struct gfs2_sbd *sdp, u64 no_addr, unsigned int type) rbm.rgd = rgd; error = gfs2_rbm_from_block(&rbm, no_addr); - if (!WARN_ON_ONCE(error)) { + if (error) { + error = -ESTALE; + } else { /* * No need to take the local resource group lock here; the * inode glock of @no_addr provides the necessary -- 2.47.3