From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f70.google.com (mail-oo1-f70.google.com [209.85.161.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C72B227BB5 for ; Sat, 18 Apr 2026 12:56:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776517016; cv=none; b=jYEukrWW6Mx2V9fZkmFPEHre6wWWO6E+2MiK8Si2TsKvNPTDtSSXl7gH9Zl9tJj0tRKXSAmR3+b33IP+av1Qk8bAozx2ZUmRxD0Eo19rj8bk54JaPlbXTy9MSaRod9nG7odx7bnBLLeljco2FCQQaHQY8CYJGBaexOH+Wc28UFI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776517016; c=relaxed/simple; bh=MgjJBCLuvZWQiwt09DltJMrGr1n0BH4SLLHjV2O1OP0=; h=MIME-Version:Date:In-Reply-To:Message-ID:Subject:From:To: Content-Type; b=NAt6O2abmLDD5jKa5A8pHfANibqbUKdJqlFhImdzZ1BS4klZxGXYtr3/Vd1amTlRvESWxD2ph/v6dZjUFIdQbdt1L2vx0Tm7/QmiyhDGJ+z/Tu3LCOlZDtp61EaDovDe866ewHd6Vj0Wh274kSnb4WIo4gdoYJHyZUl3TzWdkHM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; arc=none smtp.client-ip=209.85.161.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com Received: by mail-oo1-f70.google.com with SMTP id 006d021491bc7-69271008251so3183026eaf.2 for ; Sat, 18 Apr 2026 05:56:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776517014; x=1777121814; h=to:from:subject:message-id:in-reply-to:date:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dl+lg1QFzZ0Syod8tA4CU768Kf6Xxm8/ACam/bQIJ+c=; b=K3cC/w2RoB+oepSumtxo2cIGD/+6bfbBFeu+17e9CZII9MDkjVi+c4oD1Abq3b/dGn 5SqzQZtjB+UMk9yY4ompZ9S99hLDNR9trgzJGb/c7piPWYixGY1pOkx5GVqrPwOr0UKk KuhOngfefBfBKB4yFcCLHF5Zt9+VTRGZvo2HyX5mlsry1j9g2pP948/bswI/8mAclVLA dP7GzdEc8lvoNmv6aArLMHmAB4V7qGRUMnVpXQtjNR/gDkr5fp4KlN+MYRyktCieyBrz FlaXDDe2lxWHiYHrf/bVVPR8ElYRDRTXKjhmWK05RaSJfxbobUssK5w+gmquzsf7fbA1 nj+w== X-Gm-Message-State: AOJu0Ywr5YX2KNjsu1qCA7iDnPG/EkUaHowb75eZULyqxLOairrOQVUD ZRivBRo0HXSuw+8a44jsSotjdX44Tb93uEqD34bI//NxscHc9Qavdrb/afaFq0+aQMiumiJGEDM KCxYpK0PvAlWrFlUnsrIEh1xUSqUuxTkC2C4+HfKp1aWh9IsL2zA5MVct7cQ= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Received: by 2002:a05:6820:1c9d:b0:683:84f8:c0f0 with SMTP id 006d021491bc7-69462ee6a13mr3523235eaf.36.1776517014089; Sat, 18 Apr 2026 05:56:54 -0700 (PDT) Date: Sat, 18 Apr 2026 05:56:54 -0700 In-Reply-To: <0000000000008bbf19061531d31a@google.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <69e37f96.050a0220.24bfd3.0007.GAE@google.com> Subject: Forwarded: Re: [syzbot] kernel BUG in jffs2_del_ino_cache From: syzbot To: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" For archival purposes, forwarding an incoming command email to linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com. *** Subject: Re: [syzbot] kernel BUG in jffs2_del_ino_cache Author: tristmd@gmail.com #syz test: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master >>From 7108f321633c0bdfbbab9d305e2e01e7d83c8902 Mon Sep 17 00:00:00 2001 From: Tristan Madani Date: Sat, 18 Apr 2026 12:55:36 +0000 Subject: [PATCH] jffs2: clean up residual xattr refs in jffs2_del_ino_cache jffs2_del_ino_cache() uses BUG_ON(old->xref) to assert that all xattr references have been cleaned up before deleting an inode cache entry. However, a corrupted filesystem image can lead to inode cache deletion with xattr references still attached, triggering a kernel panic. Replace the BUG_ON with a graceful cleanup path that calls jffs2_xattr_free_inode() to properly release all residual xattr references before proceeding with the deletion. Reported-by: syzbot+44664704c1494ad5f7a0@syzkaller.appspotmail.com Fixes: aa98d7cf59b5 ("[JFFS2][XATTR] XATTR support on JFFS2 (version 5)") Cc: stable@vger.kernel.org Signed-off-by: Tristan Madani --- fs/jffs2/nodelist.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/jffs2/nodelist.c b/fs/jffs2/nodelist.c index b86c78d178c60..498308f741a34 100644 --- a/fs/jffs2/nodelist.c +++ b/fs/jffs2/nodelist.c @@ -459,7 +459,10 @@ void jffs2_del_ino_cache(struct jffs2_sb_info *c, struct jffs2_inode_cache *old) struct jffs2_inode_cache **prev; #ifdef CONFIG_JFFS2_FS_XATTR - BUG_ON(old->xref); + if (old->xref) { + pr_notice("ino #%u: cleaning up residual xattr refs\n", old->ino); + jffs2_xattr_free_inode(c, old); + } #endif dbg_inocache("del %p (ino #%u)\n", old, old->ino); spin_lock(&c->inocache_lock); -- 2.47.3