Re: [PATCH 1/2] mailbox: Add power_get/power_put API to mbox_chan_ops

["Jason-JH Lin (林睿祥)" <Jason-JH.Lin@mediatek.com>]

On Fri, 2024-06-14 at 13:35 +0200, Markus Elfring wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  > To avoid pm_runtime APIs calling sleep in all the atomic context
> APIs
> 
>            PM-runtime?
> 
OK, I'll change this.

> 
> > in mbox_chan_ops, we add power_get/power_put API to let the
> controllers
> > implement them with pm_runtime APIs outside the other atomic
> context APIs
> > in mbox_chan_ops.
> 
> * How do you think about to omit the word “we” from such a change
> description?
>   
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc3#n94
> 

OK, I'll remove `we` and change the sentence below:
Add power_get/power_put API into mbox_chan_ops to let controllers
implement them with PM-runtime APIs outside the other atomic context
APIs in mbox_chan_ops to avoid calling sleep in the atomic context.


> * Would you like to improve any indications for adjustments of data
> structures?
> 

You mean the description of power_get and power_put in struct
mbox_chan_ops? Is this better?
@power_get: Called when the controller needs to increase a reference
count to keep power on for the device of mailbox controller. It's
optional to use PM-runtime API or more complex operations to implement
this function.

@power_put: Called when the controller needs to decrease a reference
count to release power for the device of mailbox controller. It's
optional to use PM-runtime API to more complex operations to implement
this function.

> 
> > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> 
> Does a dot really belong to the personal name
> (according to the Developer's Certificate of Origin)?
> 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc3#n438
> 
A dot is not in my name, but I've been using it for a long time.
It's binding to my environment everywhere and it's not easy to change
in a short time. But I'll try to change it before sending upstream
patch. Thanks for your advice.

Regards
Jason-JH Lin


> Regards,
> Markus