From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f72.google.com (mail-oo1-f72.google.com [209.85.161.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67F5823A561 for ; Sat, 25 Apr 2026 08:58:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.72 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777107525; cv=none; b=et0w112+i9CyaxSoNU3moHt3HDpRNB+PTy5kBbqY+s0wGS4gbD19EZxYKVt1p5mEZW8YYMFh6n8fXVIxXZZz1mfkdDV7NHrgYdVJ/fy7Pcx+b/pdoBaguVOWRkI28bL39vtKQKXbzgwXcZAJllO6lTH3qOAx09sxxrIw9ltXxgo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777107525; c=relaxed/simple; bh=aVtn89CHNVLZQF9qX18F0Jvdv1URZ4Xm+Rrp5HPDoFo=; h=MIME-Version:Date:In-Reply-To:Message-ID:Subject:From:To: Content-Type; b=AVuyoXF31k7Y7F93JGPlu8S3ZF914LaTufiPYwTyqouEhheeuqnwGy1nj42TsjG8M0tf9hCh2+Bz2YabCqXIzBTterLTcQKeThBbvWCiEJRZWeBeKanlK3vV5INE2TOyVMi5kCvyUtVi+cCk//IEpFIMJYc5VWdE9VvISkBw86k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; arc=none smtp.client-ip=209.85.161.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com Received: by mail-oo1-f72.google.com with SMTP id 006d021491bc7-694867ca247so11826833eaf.1 for ; Sat, 25 Apr 2026 01:58:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777107523; x=1777712323; h=to:from:subject:message-id:in-reply-to:date:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aFqD1RCQ38VfzdFQzoZr+FFyv2sK1I2slGivrxOUeMs=; b=Q8sIYxbH9wrw9AhNNSSCLIQQRE1IcWVaTJTA+qI4XmPOD9+v87sCkvs1YTIv63D6ii YcnFOztklhMh89b4d3GG3tq4pF07TKCPuyBVufYUW14cxm5hXpQ5C/hrC/oYOxKM/EIo kp0AsrxNgVtVGA/ICfIdCcJ2v8UNC811DL9+rXL3az4rsfpI9ij2e/iKlNtKQvM1z3ZK tksSjYBzBkNktg4bTgGILJk8ZnNesrCp7ckGuPpXCqlQyXtNpmN8YEHxnjgTVXNwcQ9p b9BwwvuGQw4RMNaPDvOcq1XcuZ9NFOsmd3PHW2B76NepnKedA5hYjnwH+YYv+J1oeaW5 +gnQ== X-Gm-Message-State: AOJu0YzGLVsgY/n0PVlQu4kWZRqmvS0XmFscAK+7kFTcclRjGciKWQcj /NbMzj8hajwywZ2eUq2LYsKLgQBrru6bB6d+lw9QSTs74lxhp9bong318rya1d+tCLQYSwx/lCP 0Sv+UD0QuZ7enEBy+jX2oU64sHFcjGbUPYGb+gCSP7fGBRPbTChq6xxtV9Jo= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Received: by 2002:a05:6820:f005:b0:696:1be1:92d0 with SMTP id 006d021491bc7-6961be1a142mr6158477eaf.30.1777107523492; Sat, 25 Apr 2026 01:58:43 -0700 (PDT) Date: Sat, 25 Apr 2026 01:58:43 -0700 In-Reply-To: <69ec231a.a00a0220.7773.000c.GAE@google.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <69ec8243.a00a0220.7773.0013.GAE@google.com> Subject: Forwarded: [PATCH] usb: core: hub: fix memory leak in hub_port_connect From: syzbot To: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" For archival purposes, forwarding an incoming command email to linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com. *** Subject: [PATCH] usb: core: hub: fix memory leak in hub_port_connect Author: souradiptodas6@gmail.com #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 24960ba9caa9..2924ce770066 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -5405,6 +5405,7 @@ static void hub_port_connect(struct usb_hub *hub, int port1, u16 portstatus, if (hcd->usb_phy && !hdev->parent) usb_phy_notify_disconnect(hcd->usb_phy, udev->speed); usb_disconnect(&port_dev->child); + udev = NULL; } /* We can forget about a "removed" device when there's a physical @@ -5582,6 +5583,7 @@ static void hub_port_connect(struct usb_hub *hub, int port1, u16 portstatus, goto loop_disable; status = hub_power_remaining(hub); + udev = NULL; if (status) dev_dbg(hub->intfdev, "%dmA power budget left\n", status); @@ -5624,6 +5626,8 @@ static void hub_port_connect(struct usb_hub *hub, int port1, u16 portstatus, if (status != -ENOTCONN && status != -ENODEV) hcd->driver->relinquish_port(hcd, port1); } + if (udev) + usb_put_dev(udev); } /* Handle physical or logical connection change events.