From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D93823612EF for ; Mon, 27 Apr 2026 03:58:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777262307; cv=none; b=ook7F2AdDn8368SWqJGc3fZ5FWEAz+aeMS18mTp5wDpvogd0yrHQmm2EnmB/GZ1W4IHDHFE1BMrtuhxMguxhCC2OuabxZobfjBTEusTb+SM+jqZnB/igfwGyq8PmW2daVa1hYpOLYGfLEPrwQZajHqRMetuLWJz9mwzQyuZ1n9Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777262307; c=relaxed/simple; bh=ebTLqvJ8TU4SweNZX+gkXIlTxan4FkVR9U1QHLSMC9g=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gwadD/qtCT4yNlsnQx8b7Fn6M6cGR4S5ipf3HI17tWNpMyjQFotbaY2ILvQW9J8LnX2pmNf1fy8CsqRls2cO7/SOlOmD2UmXuFSj8bOYObGzzq5547tIkk8pKkR5jwqUmK0O5ouZoCa6SyNNHG1lYlpN57iDskiV5o1Uwyx9IFs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sRon1Y62; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sRon1Y62" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-3585ec417f6so4963924a91.1 for ; Sun, 26 Apr 2026 20:58:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777262305; x=1777867105; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:mail-followup-to:subject:cc:to:from:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=aDwV9jOGS1Ta3doKCAH5P3EaRc0vCO2ZKbMN+NTdxUo=; b=sRon1Y62sFt9oP1TuCA5G7S/tsKAQcGtqCPq1nTQytrpOkyfboqaJ+RBctemXYGAZD 99yGx+R8mUyHHZMfKriOB6tC9my+CIjy8GumAp9UPSOQrZSs3IvyOBD5Oe6gjZ+CJdZO YQ0loxIfWtXSX9u+Cxrie1gzpHq50X5z+SyFWOpKcd5/Eo970dLaPTBia5OODPb1hvLV E4GiYJscFhT8IhfGws5cDvn8GkLViwgzjHRBLx1oQJEW6mOe9bazMcUROO8R4YPk8B7N mpmsnA2YST/eGX0jJNUNEdO9+HZh/uD0h6lqVPdN3FcK8eRWAwHb2m4WM8PW3Q+Ogzfi j82Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777262305; x=1777867105; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:mail-followup-to:subject:cc:to:from:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aDwV9jOGS1Ta3doKCAH5P3EaRc0vCO2ZKbMN+NTdxUo=; b=MUyD0jdXq4P6NHoLFylS3QGJs4BKtTJUFAn88k7QtukrP0nWFoa6hvXVQYUBwNZqsb Jo5sfVyPUUb/SUn/baDuQ10eifeLFdxXZU3iHkekkDHgNhb02F7OUy6NID6f9Ew1Y706 xS48SSWz7SsuYHp6iiGQzBXMwjYlDHyY9eUNDJFt7vgUe5Yqq4HI9PR0dmcY99iPQycZ BshjLpTDsqfEB8B/z5EJ3VMzcZC9dK8CSve3pWTRAGdJYWiHGyc9VDYNHgfTz7XggLWj TEVRXXnbFwzpXfdSjOUU7MYABPti3hoexLafQl1iJptO8PjN/0NmH9rH+7WdCQeAQmgo C/rg== X-Forwarded-Encrypted: i=1; AFNElJ9TFk+q8uuQOKaxCIxqKbNMF2J84jDwlemzASdtz/cTOjx9Zwt5dON5A+fXgVZVIqP9V1QsbkrawkQjT1Q=@vger.kernel.org X-Gm-Message-State: AOJu0YzoJPIT72hHqP88Ake+CoDwfbLeKdbCVavpBkQ6jgyoZVQVJPv/ XOIRm2X5mD9aTv2Bk7L8OOrupEZMjHODMWdwQvZ9XXZkkEpXX51tamJy X-Gm-Gg: AeBDievZceaF2DkJpYy5vWxVuQ30lm2f7v+rXNXjjPp9TJaKniPnWPVogftzW5mrKbL 35CctmQq5+SxGTT/xq57A24XNZwaZA27ZJwJNh64TMt1454mY5AN5nbgZxRKGSO0pqT+NApMe7a BlGnNBkzeCor1cV9ndMqlT42eZTFCFTiaY1RpU9fFTd09jWSM9A6374tvhoQph6Q1QxnFMFbZd+ 7RY1a7nNSfegMto+OTdCaikhLr9QZlRwCPsG6vpY0nbwMXnnIDU0vuo8BY2ntC3XrmDC7WRGERp OtW6yq8lgWNlRs5eGz+ICKcCYrbld/IGYXcHmJWFrPCe9gpXJ+82UrD9EDF74HcGYpHFiE8umSd UhdAM1KdXS+u3CqGKHESpK6WlcG1tm+tO0gUglKCHtcP6rmNV9uSKRyNmkBiMn+xPiulIkw0Ryf wN365jUyvgbSNloF3YIWK4SpjTjfSVXwfAogi0P72zSCmOthY= X-Received: by 2002:a17:90b:17cb:b0:35d:aa02:d776 with SMTP id 98e67ed59e1d1-3613ffce5admr32691672a91.2.1777262305136; Sun, 26 Apr 2026 20:58:25 -0700 (PDT) Received: from yuwhisper-pc. ([49.213.140.88]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-361410a7a9fsm30321821a91.12.2026.04.26.20.58.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2026 20:58:24 -0700 (PDT) Message-ID: <69eedee0.170a0220.230e6f.9507@mx.google.com> X-Google-Original-Message-ID: Date: Mon, 27 Apr 2026 11:58:20 +0800 From: Hsiu Che Yu To: Miguel Ojeda Cc: Hsiu Che Yu , rust-for-linux@vger.kernel.org, Alexandre Courbot , Danilo Krummrich , Lorenzo Stoakes , Vlastimil Babka , "Liam R. Howlett" , Uladzislau Rezki , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?B?QmrDtnJu?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , open list Subject: Re: [PATCH v2 2/2] rust: alloc: fix `Vec::extend_with` SAFETY comment Mail-Followup-To: Miguel Ojeda , rust-for-linux@vger.kernel.org, Alexandre Courbot , Danilo Krummrich , Lorenzo Stoakes , Vlastimil Babka , "Liam R. Howlett" , Uladzislau Rezki , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?B?QmrDtnJu?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , open list References: <20260425060823.76175-1-yu.whisper.personal@gmail.com> <18fc8eee2f057a6bfbcadae156d1d0b7c40d0077.1777111268.git.yu.whisper.personal@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sun, Apr 26, 2026 at 03:10:12PM +0200, Miguel Ojeda wrote: >For this case it doesn't matter too much, but in general, when >something is a fix, we add a Fixes: tag (and in most cases Cc: stable@ >to accompany it). That helps backporting (when needed), adds context >e.g. for reviewing (at times), etc. I did miss the Fixes: tag — and what I hadn't thought about was that these tags feed into the underlying tooling and workflows. I'll make sure to include a Fixes: tag in fix-related commits going forward (and will likely use one in the assert! patch coming up shortly)! On Sun, Apr 26, 2026 at 03:10:12PM +0200, Miguel Ojeda wrote: >By the way, now that I was looking at `reserve()`, the assert in the >example there should probably use `>= 11` since there is already an >element, instead of `>= 10`. That could be another similar patch. I'll go ahead and work on that. I was thinking of changing it to `>= v.len() + 10`, which might make the intent clearer. For this patch, should I include the Suggested-by:, Reported-by:, and Fixes: tags? Thanks, Hsiu