From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 141613B19B4 for ; Mon, 27 Apr 2026 09:28:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777282123; cv=none; b=RJesUAiQhYAP8b/w3Z/ZKeO+KkYMvUgahyz436//sJ8WTyJhOiySzDcoUKDRj+TA8jBNofVlCCCeun7dGCnw1Um1JvCUzxlcKIl+lPJfP3nNkgEud2o2U5C5YjtaNviIGHzWZnUwYO7FePCnUlyLUxnmsz1A3zlh5Z6Gebs2yTc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777282123; c=relaxed/simple; bh=cWlCOFhZcpalfl3WjAaLRxx9ew6UD/guyBxJt7n25L4=; h=Message-ID:Date:Content-Type:MIME-Version:From:To:Cc:Subject: In-Reply-To:References; b=mGMPCOfhxPvUJcsE+hjQRUJmfheCau89+Mi4aOIDAFoR2wE3IRHY7khFU7YPjrKUtcsQS8KRJ7ZGHsOaTofQE2o4bsRE4N1jGr+/t0eFGFJiPeFOsbm5/hHeL4252ULmjHs77AxTbxveAliEhgjPem5pa//Cz+veJj82RqMSJtI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pXfx+mps; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pXfx+mps" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-43cfd1f9fd1so6147340f8f.3 for ; Mon, 27 Apr 2026 02:28:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777282120; x=1777886920; darn=vger.kernel.org; h=references:in-reply-to:subject:cc:to:from:content-transfer-encoding :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=Nnc/PUQBSU6rmjuW9Girol1kceDL3q32jW2r6UBTf7U=; b=pXfx+mps0JUafPEN6dOk1kffuiHx6fqZNFhXPndfFuWl6ztSEd9lGuDA3vpheBEfRy 6fuoj0/zxzfyfDJRNr9m8fc46IYglp78hkbKYuT1SKNh6ZdLgUXUqBGSvCJzfi3f9X79 4RQzo5P3bA917hNyzTZ34wqY3EK6WcFvKpv7ySNhtL0UHnu7MtOAApJCoaQiohJo4Lc6 uQWB/AY5BucF8uhpDuCueMJaayDLwNAfOrfKXhKQJjsLG0qui3WnGT3Vg56TNZPuEj4Q QBBFhjYXqVLpty5QUYR26buKHEu6+VRwEdO0Rp+UOnjPdPHmePAdwVvQBQNT7Q7LChxJ ZgEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777282120; x=1777886920; h=references:in-reply-to:subject:cc:to:from:content-transfer-encoding :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Nnc/PUQBSU6rmjuW9Girol1kceDL3q32jW2r6UBTf7U=; b=bpOweCxOFrns8fk8jIxfPaoSK2VSgDKsgkC3vX2/55kglfO6x59lIjxwHOpy2aFM76 WfZAXpG71Ok7hH0ERi7kmRbDZIanfFWGJehMolfBzjk1rmUwVupb1RXqCSJtSEcq7nPW hLKFeM1i580+kt0BLu5LJev1J7/CHiNf7+n/GAmF3Cf8DsdoEEBNNQLL4n61fkkc7Tsr xSyVmfnlbjOS+R5i5tPoDosGhVK1WSkBLJ+kRPm15QJ31dIkWpczBkKpBefYX1Cdrauf l6X4ge9UIKAFOUpThshXtBT9nm8zv8oM6o8vXjShwt/pGQon+9gW9eMI20V/XMPdDs0c LLlA== X-Forwarded-Encrypted: i=1; AFNElJ+WlGAsEoAGIwbjf+SFcz2QXRkJyvmsCviAJYdPSlEXEHxP0GofGbH/JkM0ImSpAmMTF+xqKV90SqMEwM4=@vger.kernel.org X-Gm-Message-State: AOJu0YxqqVnSwmXqWpqAvdIVVQsb3bA/K7Nnjwm8Vs65nw4BS/vgSikS bh9XCPPktyzErt8IPR0zx1T05mxskB2dryUCKm5h3frkvCEfJSmhcNHz X-Gm-Gg: AeBDievuf0q719CRpZTbIzbmumL9HPgk98IeIEAJUOilJiNcrK56qg4F/Zu3Knf73Gq 2EkhFzV0OGj/6W41ZznhjV28/sX8jOaEXSDLqZDfBodqAyFqPaejzbzoC6Y9EG9O9kUbCxbZHmd dI6TkSggPRBKQSrVpV9THqrK5oKys8XQOiw6qzSBiqN2OtmAQBSuUQAyzGMVbKl6D0mIL+TlvDQ unIVfAx90xWc6YzZmzT6mKu/zj7psvPkVERfM3WcNkJATfmuJvRZT3P4GI2+8D612IvBwZeFDnN aBkPQHy6k0KYBB+THzTYXSoKH3oiDxgpVABEOaYCgntYm0L3V788hDf0YWadJ3Uh+Eq68+I3jrk SqELkLpvS4u0soECCf7NVFcMdqx8/eAOCWQqrJUz83Qz75SmCBVqgtaQ4F+WqgqJWVf41Ll/UFu iAOcpIaIi+r5zluBWO9/XUO4U3xJUDDrM1QtMoUx9ElM/k9ZItWYb7Z8qXORjvv3yS5Ci+hvJuI RGh1vq2yvms+E1EWRiCtdOG1mTvUoA/fWHFwqTpxMCtUUxadFMJRCo1SqRme1uIGV6xxbU= X-Received: by 2002:a05:6000:2508:b0:43d:71f4:7ecf with SMTP id ffacd0b85a97d-43fe3e1131cmr63955799f8f.38.1777282120103; Mon, 27 Apr 2026 02:28:40 -0700 (PDT) Received: from ahossu.localdomain ([82.78.232.184]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4412150a071sm42776641f8f.21.2026.04.27.02.28.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 02:28:39 -0700 (PDT) Message-ID: <69ef2c47.5d0a0220.2e33d8.bde8@mx.google.com> Date: Mon, 27 Apr 2026 02:28:39 -0700 (PDT) Content-Type: text/plain; charset="us-ascii" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Alexandru Hossu To: Dan Carpenter Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, luka.gejak@linux.dev, stable@vger.kernel.org Subject: Re: [PATCH v2 1/2] staging: rtl8723bs: fix OOB write in HT_caps_handler() In-Reply-To: References: <20260427081748.3407939-1-hossu.alexandru@gmail.com> <20260427081748.3407939-2-hossu.alexandru@gmail.com> On Mon, Apr 27, 2026 at 11:17 AM, Dan Carpenter wrote: > We need a little change log here. I was hoping you would provide > a link to the AI review in the changelog. Hi Dan, Sorry about the missing changelog, will add it in v3. For the AI review link, I don't have a direct link to the bot output. What I know is from Greg's reply in the v1 thread on lore.kernel.org, where he said both his fix and mine would break things on some systems according to the review bot and asked me to use truncation instead. I went with min_t() specifically because he asked for it. You're right that technically early return would have been strictly better than the original, the original was already writing out of bounds so it wasn't working to begin with. But since Greg asked for truncation I kept it that way. Thank you. Alexandru