From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CE0435A3AD for ; Mon, 4 May 2026 14:16:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.69 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777904194; cv=none; b=pPpeaBBqfYUPLSSyoQE1d76jViAHno9s/961Kjo7Z1/8I14nh+hPgexi2R6qXKVjj8C8oFG5IwJ5eas1A9Us6pvDH/fXf/HTP00jiaKZyx2hMnRBG72H0SQVUaiOvrpzRZAjIsf9/pAN9XsqYO1ITTLbYMGxZhCwNqpAeIlV3zU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777904194; c=relaxed/simple; bh=3F4oXENUdSmx+rdSkjarz/dVw+B7HzrMZN2M9o/CqK4=; h=MIME-Version:Date:In-Reply-To:Message-ID:Subject:From:To: Content-Type; b=pdV1Ed3DXMJf9ZWUrqpiHMAlGXxhGI0l0aBezibe6+KILAO7tvDKVuW51ll9in/xNDyK/YbpzKkiel8limw0sbTS5ndT7ipJF2owXtF64wfWPZC/TesMnKk7nDgfCQeh4E6a9KO+CNH/8WS9XYEkRclNYcQzaZYNkMTlm9ui0bg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; arc=none smtp.client-ip=209.85.210.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com Received: by mail-ot1-f69.google.com with SMTP id 46e09a7af769-7dcdcacd141so6000008a34.2 for ; Mon, 04 May 2026 07:16:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777904192; x=1778508992; h=content-transfer-encoding:to:from:subject:message-id:in-reply-to :date:mime-version:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FGy9Xg1ecCWiDRhN8FXqYzJl7l901nUNd/vWHz0e9Yc=; b=KrUbSxXY0qOsxgnmHzjKK8KnGjMDrRtXcg7TOi2Wxp22MY2xPKFghXyG0WIYUgT+Cl I+nI/EWdPH1lVWKhptJOwa4fD7KlwjmUsigYLvWqZxpWtsMlsYahRDR7cPnKiEWWJ3oh s6UnR6qaTM0ElFT82pEVwgeP5shWXMYKRiq+IUcFr6xgwoN/AI2eSqVtqsLvvqSghDK+ XdP9DjsvMSmMnDrjpJAYKcSZNYv03pXGB5og6/IHkEclJL28y+uQfHF+WVYV3G2anriY VjlwFkOEsjvZJQTYeZdav/raf3kkddZR6Nf9tRESozSA6Q0qXF7MGulOyY1S4xovnnCS R60Q== X-Gm-Message-State: AOJu0YxFpGeAZOY7t3pQNswz5wDdnC/wM85QvoAKTQQy7WKHuFipGU+t X+jcGIqOxmctA7PIdLVso/4BtnIyssLki1okHm/4O9Flg0U5aA4fMGMTR8cf9T+NQO5chLflR6q me0nO5gkPdCJTJjhSG3v6SAXpudGY34IbpsXu+tPoCly5/piIavpVOkmSYCk= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Received: by 2002:a05:6820:1c9d:b0:695:a86:91a0 with SMTP id 006d021491bc7-69697e42866mr4345928eaf.42.1777904185712; Mon, 04 May 2026 07:16:25 -0700 (PDT) Date: Mon, 04 May 2026 07:16:25 -0700 In-Reply-To: <69e4ee46.a00a0220.1bd0ca.0058.GAE@google.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <69f8aa39.050a0220.892e9.00d4.GAE@google.com> Subject: Forwarded: Re: [PATCH] security/keys/encrypted: encrypted_key_alloc(): fix KMSAN uninit-value on dlen From: syzbot To: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable For archival purposes, forwarding an incoming command email to linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com. *** Subject: Re: [PATCH] security/keys/encrypted: encrypted_key_alloc(): fix KM= SAN uninit-value on dlen Author: pardhuvarma.kernel@gmail.com #syz test On Mon, May 4, 2026 at 7:45=E2=80=AFPM PardhuVarma Konduru < pardhuvarma.kernel@gmail.com> wrote: > KMSAN reports an uninitialized-value use in encrypted_key_alloc() > due to dlen being referenced in a compound condition when kstrtol() > fails. > > Split the condition to ensure dlen is only accessed after successful > initialization. > > Preserve original error handling semantics. > > Reported-by: syzbot+23d7fcd204e3837866ff@syzkaller.appspotmail.com > Signed-off-by: PardhuVarma Konduru > --- > security/keys/encrypted-keys/encrypted.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/security/keys/encrypted-keys/encrypted.c > b/security/keys/encrypted-keys/encrypted.c > index 56b531587a1e..4bf4b4e8f7b5 100644 > --- a/security/keys/encrypted-keys/encrypted.c > +++ b/security/keys/encrypted-keys/encrypted.c > @@ -588,7 +588,9 @@ static struct encrypted_key_payload > *encrypted_key_alloc(struct key *key, > int ret; > > ret =3D kstrtol(datalen, 10, &dlen); > - if (ret < 0 || dlen < MIN_DATA_SIZE || dlen > MAX_DATA_SIZE) > + if (ret < 0) > + return ERR_PTR(-EINVAL); > + if (dlen < MIN_DATA_SIZE || dlen > MAX_DATA_SIZE) > return ERR_PTR(-EINVAL); > > format_len =3D (!format) ? strlen(key_format_default) : > strlen(format); > -- > 2.54.0 > >