From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f175.google.com (mail-dy1-f175.google.com [74.125.82.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7E4137F0E0 for ; Mon, 12 Jan 2026 17:40:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768239628; cv=none; b=l3ZkW2WF81jK59GDoQkfw0LTor2yUpTaJBFQ2WUs+ExrrkWmRI5rwd5mWLOWbCJ/Wtwf4IIYIe4QEowAnPCrykNEmpIjTz9MHq8GNQuSCkhLL64mlqYSxlnYp6P3NdTkctjbxo2n7MoXFbRc7vpZsoJMd2IHeAfpLBRRGHYWCc4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768239628; c=relaxed/simple; bh=bWNt8XX+a1EExBXkcnhLkWphW1cwAsUON30o0t1HtEo=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=rxOUlD/eK6i31ojyprsBTEdnA7kCKszDE2Bmh43b/mYCfFegJ9+/NMWwRCIOlWHe4gWV91LDNuYtu6XQ3zWPaVuncBe7WzU50DikWVti6J7Nhso7bgZ7nz0bW9HvH+gn85LLGeKOHIaqfnTsY8UMlfo6TA7I3l8p0ySktOHXC9g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GDkYj3+G; arc=none smtp.client-ip=74.125.82.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GDkYj3+G" Received: by mail-dy1-f175.google.com with SMTP id 5a478bee46e88-2aef8e4a569so5393510eec.0 for ; Mon, 12 Jan 2026 09:40:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768239610; x=1768844410; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=xEfzR2IMaUJ79aVMeAHSeF5WLoBzAAzr7Ul2pdFLEjU=; b=GDkYj3+GMSorx/eaULUQBhQYY35+EdAlXkW4K7NdIBEWd8uxXS9+lHRXoDGzBIW3E/ RsYfFj11lydtT+zGsTXKejdd7/3uLTsnY6xvRn6jwm+QrsJsIUBXivOHBBNK84rnE2jy fra2RhJU8iveo8zKEkVq3cOKH/dLapI3W76KTQbnRSzguXcyrYOXg0wJwcRmeICvCB/7 vA+CHzSGreeb5PwQKiRkbpDZVKkLs9l8I05v7VXW9CU3ZbRVKCFPNT7jzkcWJPWYmJpl F0xPf13PlURowuXVKZYgCYBJv48dlxnzy/ugqUQRgbBHK0/MWRfRNsb5JW2DRYHRIgyp EiQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768239610; x=1768844410; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xEfzR2IMaUJ79aVMeAHSeF5WLoBzAAzr7Ul2pdFLEjU=; b=svD1s0cAxixo8l1ua8LBygMIVT3JjqTfCsRJhAoM5gkmRwR8fe1kvJAQYDpC1aYjwu 792bjCRnAEFcBMBO1k7wxEGgYFbNTQRooHNtj3QhThM05h6tuUp0ICRj6wRd+sf+VUwp 8HAD1N9udFqDEexXdQPe/ygvDlAN/rsx74zh8WrS8oIHcuSIrqczUszn9o3yeR2tb9hA 4Cd3eBGfzibzISUP8t4fKzw7limd+NETSW16NzemmH4zIMMx/omUvz5SJPsI0FfUWhnz oAQyZoqiyATAsUfysWKwfO8csmc0VNjYToSDXx+KhcEne6K6RuuDtxrtqJ8Xt+qbtMNU yAxQ== X-Forwarded-Encrypted: i=1; AJvYcCW216/N1q2NkVe3knORx01JIsBpI8yC/AlSnchjVfGMdh/5lluhNzDBsGib7PV+EOOesLH/xv2CKtj8J6E=@vger.kernel.org X-Gm-Message-State: AOJu0YzBYHo6STbAeCCuuvCkWawwqN6/WG73r9/dZSv/bR9IBsHIMbdr atMRgkpL8NE2ZvjzEsp2d3rV60hlipIG5GOpXOEeQcaxUWcJN/R/lax5 X-Gm-Gg: AY/fxX4cdKayQpsNqw7+lJcXfeoNY4kstQRQyW2AazkGMn7rTIyzQxi2dSFAzVLPmjV yUC76O8q8s49ktkS1lZxNXOz4Heln8PYpb0NzKmsIqKF5PlqDBjcqy5bM+dj9BcB0d9yHku0sTJ 1yalvsAzZh9MpeyDExslRDx9eEaFWOlC79txbxu2/Hn+R1CkFE8fq1lqbUMz9xVbEIx5JQLYar0 Ktcn/aIDZuNqKotG0xKGpucp8OBCJqQK0f/j/mQlBPNKMtHf2wsbQU7F+l4iew4fzQ/xo9nMWx4 3HXWXF88EJlcumzfKt8wwr/P6AgLpqv4QY9SiYE45HHH/cpWTGuir52fph6IpQJ6nqtk1QMj1Q8 jXyGLFmmfRLoLC7mcAUhgqw4hX3yMypYqHIiUp8dJI/KhjL/3cHXeJXe5ND4GaT4C1qO4pxqen3 1SM6zLCZ3SPh9+WfGPL7Ozqi1VJc8F32atgTMerOaYRMBtoeV7rmugKxky6it/OsX5sgXjbqhrX K+y4bwsNg== X-Google-Smtp-Source: AGHT+IHCTZtjyWlWk0cwrNDVQ+H3iM6fgz0CcfURU1LVPBZ+hluW6yquQuzFvxEgwtxB4odmjN+y5w== X-Received: by 2002:a05:7301:8613:b0:2b0:4b5b:6820 with SMTP id 5a478bee46e88-2b17d2e3663mr11342670eec.26.1768239610022; Mon, 12 Jan 2026 09:40:10 -0800 (PST) Received: from ehlo.thunderbird.net (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b170675076sm16683675eec.2.2026.01.12.09.40.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jan 2026 09:40:09 -0800 (PST) Date: Mon, 12 Jan 2026 09:40:09 -0800 From: "Derek J. Clark" To: Jiri Kosina CC: Benjamin Tissoires , Mario Limonciello , Zhixin Zhang , Mia Shao , Mark Pearson , "Pierre-Loup A . Griffais" , linux-input@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v2_02/16=5D_HID=3A_hid-lenovo-go?= =?US-ASCII?Q?=3A_Add_Lenovo_Legion_Go_Series_HID_Driver?= User-Agent: Thunderbird for Android In-Reply-To: <0on4p9s6-7512-9408-49no-3292o86113r3@xreary.bet> References: <20251229031753.581664-1-derekjohn.clark@gmail.com> <20251229031753.581664-3-derekjohn.clark@gmail.com> <0on4p9s6-7512-9408-49no-3292o86113r3@xreary.bet> Message-ID: <6BB4F74A-F440-4F21-B094-62CFD18C599A@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On January 12, 2026 4:12:43 AM PST, Jiri Kosina wrote: >On Mon, 29 Dec 2025, Derek J=2E Clark wrote: > >> Adds initial framework for a new HID driver, hid-lenovo-go, along with >> attributes that report the firmware and hardware version for each >> component of the HID device, of which there are 4 parts: The MCU, the >> transmission dongle, the left "handle" controller half, and the right >> "handle" controller half=2E Each of these devices are provided an attri= bute >> group to contain its device specific attributes=2E Additionally, the to= uchpad >> device attributes are logically separated from the other components in >> another attribute group=2E >>=20 >> This driver primarily provides access to the configurable settings of t= he >> Lenovo Legion Go and Lenovo Legion Go 2 controllers running the latest >> firmware=2E As previously noted, the Legion Go controllers recently had= a >> firmware update[1] which switched from the original "SepentiaUSB" proto= col >> to a brand new protocol for the Go 2, primarily to ensure backwards and >> forwards compatibility between the Go and Go 2 devices=2E As part of th= at >> update the PIDs for the controllers were changed, so there is no risk o= f >> this driver attaching to controller firmware that it doesn't support=2E >>=20 >> Signed-off-by: Derek J=2E Clark >> --- >> MAINTAINERS | 6 + >> drivers/hid/Kconfig | 12 + >> drivers/hid/Makefile | 1 + >> drivers/hid/hid-ids=2Eh | 3 + >> drivers/hid/hid-lenovo-go=2Ec | 734 ++++++++++++++++++++++++++++++++++= ++ >> 5 files changed, 756 insertions(+) >> create mode 100644 drivers/hid/hid-lenovo-go=2Ec >>=20 >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 9ed6d11a7746=2E=2Eb5ad29d24e3e 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -14135,6 +14135,12 @@ L: platform-driver-x86@vger=2Ekernel=2Eorg >> S: Maintained >> F: drivers/platform/x86/lenovo/wmi-hotkey-utilities=2Ec >> =20 >> +LENOVO HID drivers >> +M: Derek J=2E Clark >> +L: linux-input@vger=2Ekernel=2Eorg >> +S: Maintained >> +F: drivers/hid/hid-lenovo-go=2Ec > >Hi Derek, > >thanks for working on this=2E > >I am now almost finished with reviewing this pile and am planning to queu= e=20 >it in hid=2Egit shortly, but I have a question regarding the MAINTAINERS= =20 >entry above=2E > >The title claims support for all of Lenovo HID, but there is much more to= =20 >it than drivers/hid/hid-lenovo-go=2Ec, specifically in hid-lenovo=2Ec=2E > >So either please make the title more specific (or claim the ownership of= =20 >the whole Lenovo HID landscape indeed, fine by me, but the please reflect= =20 >that in F: :) )=2E > >Thanks, > Hi Jiri Sure, I've debated using LENOVO LEGION GO HID drivers and LENOVO GO HID dr= ivers=2E Do you have a preference? The other drivers are pretty old and I d= on't have any hardware that would use them so I'd prefer to keep them separ= ate (though I'll acknowledge that they don't seem to have a MAINTAINERS ent= ry) I also need to fix the ABI docs, I accidentally added an extra + character= to every line in the patch for both=2E I'll update that too when I fix thi= s=2E Thanks, Derek