From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B830F19C542 for ; Sat, 25 Apr 2026 02:43:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777085036; cv=none; b=YgSx6EIaUBLHaxMfTbCYwAgAwidibbCmlPx9zbPlAcgUHwlfQoJ0YAXGBdldObUgMINCKdELnWXsr/JMal5uK1hyWAWYOovWBBmmxDHEFJOtZ3/8JRmrRX6052EXth1qUFEEp1C1IhbiSoYet3yDWbpEluFaLXbXu3tqW8bn6MQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777085036; c=relaxed/simple; bh=/p/S8kUDUJ1olhsEvmLElM8ozexRk8Qir2DHZwWEN5s=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=tGF+JQyJFeQOEQjIffd9U6J3QON5iIfINp1JJY8Ih2wyePLLCiphmWRlD3fTGN9Wr+yj8INKzp+V4nraa82LWgYc8FQ+jDyRfO1ZPzRjwKsczJ+EsgKZkLEL2Fyf0DHM7w4V04iFkhcDeGYZ/KbzF5p+gg3IhZz1HvYoLwej+eU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GtJ02XIc; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GtJ02XIc" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-35da1af3e10so7961240a91.3 for ; Fri, 24 Apr 2026 19:43:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777085035; x=1777689835; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=/p/S8kUDUJ1olhsEvmLElM8ozexRk8Qir2DHZwWEN5s=; b=GtJ02XIcMxWufMeBWwfhnmOlxx68ESDO+A9UwiIvCNrO49t/JI63dDYBYVDMlPf/v6 z74MtLniIdNalcDIJEH68uwXNAjuz8ZHUw06zWvrF5p0qF1/4W2JZW2uGeJZFGL8lWlj FaNizbvcOTw/Xjl71cQhbLrZ7nlYFSPP/+30l8+srPpLpbTljrPimGeDBINnYAfl5qXx 8OiAc/w2qSdQH8paf2Q4+0PRuTjZ8rqQ6L+5+77P6hxTj5ZwmcSzvY3/v0rZW5V6ZEl4 sUO1ovcSpgqFii7kiId0HSP6uV6WcUDha3L5uSui4vS/9sukv7dy3Bg++ZLMh///lJik /k3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777085035; x=1777689835; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/p/S8kUDUJ1olhsEvmLElM8ozexRk8Qir2DHZwWEN5s=; b=BEdMtFXcpLOjHt+kSZ1O0Yj65o3/Bkx1KCUGj04N2V0hKYKTIDKxg3O0lnZZwU6jXi tt8bGCa/TPPVXqqnUOoNSeG65vOLbPOP7PUiQH5CRcTV/CBk1QnIFPS6Yeso7+9qJZFq khWz8HIztmH9JMAH0yvGUqyqzOSWIEWImnu2P641TjBCRqj7fjikmSSRkjf3W0hCauor 4c+Nwc4PA2WlfU0FPVi6K9LFo0KxCQLOvCLdnI3EQoKHa5wDk9ko/xpiOIPOcE/wCat3 oxdZ2c9XD3Qz8UpWBttM9Tf5qMI1c2OJTSDHLbcXJqZPTrijWObr2ayVHNbb79lxN8uV j62w== X-Forwarded-Encrypted: i=1; AFNElJ8fQYumY/GKiTQA05lP1PR1xf9Oml03u9B3cHD19JD5Q59fzMxRR497a8yXsBdeU/PRrKntwtu1cpHXGfs=@vger.kernel.org X-Gm-Message-State: AOJu0YzRwFdstlwpdMUC9rYp0jWqAb1PW5lGOdYYH5dIzRACRXJ1qzUw eY8yfkzKBSMAf+ohBUO8SNs1DXIAn5/cLOGcVu8W0TlGcwweKAfWuujw X-Gm-Gg: AeBDiesQ8Xi52IYUYoQ+iXbSUtDsBUDAPEGs8lcP+e6qP+88o+nhP4LKlk+kcob3835 VPtgVJUf7yaIwU68F2yYlFwK56QK8+4U5h+7uowOd3dfszjMAvNRJoOCbO63T8/zocGCGHF38Uk uV5MSW6kCQ6//+5xd0P1rK148EAU4j4uMDJCqh9S8ULbNVCrI8A+GON5YhpuGk15nr/Rhoq8LpG W9x67xUeHJ6yQnVPKdc2Uxb9/rgAsIzWZ1liNKW7OazhMigGzPqo/S3j8sB3UGSnsc+cfyFmkpg tLKdI5RKOpDNtOJIjkQB93qqm38QP2aTbja/zO9wWrGpE+lW+SMnsRe1WJyiyad0VXBz01WJFW/ UY6lF2Rn1p0FpROqTsHZkvSW7EBMA3E0rTpBopZbVwf2VxW3jc9MUQeSMXZY8Bgv2a0Q32ol1N4 EMz/e6E4MxwXJMEgGF54PXOd+yx3mUNoa5ymEhu9SRdH76FXSg758= X-Received: by 2002:a17:903:1b24:b0:2ae:66c9:494f with SMTP id d9443c01a7336-2b5f9e64bfcmr357108255ad.2.1777085035096; Fri, 24 Apr 2026 19:43:55 -0700 (PDT) Received: from ehlo.thunderbird.net ([203.184.33.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fa9ff390sm234089145ad.9.2026.04.24.19.43.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Apr 2026 19:43:54 -0700 (PDT) Date: Sat, 25 Apr 2026 14:43:48 +1200 From: Brite To: Lachlan Hodges CC: Johannes Berg , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, fjhhz1997@gmail.com, oscar.alfonso.diaz@gmail.com Subject: =?US-ASCII?Q?Re=3A_=5BPATCH=5D_wifi=3A_mac80211=3A_restore_monitor?= =?US-ASCII?Q?_injection_when_coexisting_with_another_VIF?= User-Agent: K-9 Mail for Android In-Reply-To: <4i5nyqdrtpgm575dd3swyp7662wjdxu3hky7ucgwnuwigx5ge4@tc474ip5qxtc> References: <20260424120807.25005-1-brite.airgeddon@gmail.com> <4i5nyqdrtpgm575dd3swyp7662wjdxu3hky7ucgwnuwigx5ge4@tc474ip5qxtc> Message-ID: <6EC55EE4-4534-4832-9FB2-393182829B22@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On April 25, 2026 1:47:28 PM GMT+12:00, Lachlan Hodges wrote: >Hi, > >I will leave implementation discussion to Johannes, but I have some >generic feedback; > Thanks for the feedback and now i know why the code was flagged as llm cre= ated=2E My approach to finding the vm freeze issue followed by the 5ghz dea= uth not working, was done using debug prints everywhere possible, with adde= d delays between function calls(the delay was added because the vm froze ot= herwise, without any dmesg logs)=2E Since I didn't have the proper knowledg= e, the fixes i tried initially (spread across 6 or 7 files) led to other is= sues, intermittent failures etc=2E Everything was done inside a kali VM wit= h no comments, full of messy code, not using git commits to revert etc=2E i= had to start from scratch but then i added comments alongside=2E Even thou= gh the initial patch fixed every issue, being too invasive, I tried to trim= down as much as I could which landed the sole chandef and then the 5ghz pa= tch=2E I didn't pay attention to improving the comments when removing code = sections=2E I also had very limited time to spare for this and my intention= as I said in the airgeddon discord channel was to send a cleaned up code t= o the kernel devs so that they could get a hint at what the issue is and co= me up with a proper fix=2E The commit message is what i summed up from doin= g all my research and testing=2E I didn't know the format to submit a patch= , so i used information from AI, Google, previous threads/replies etc here = to submit an email=2E I didn't check if AI changed any comments=2E=20 As I mentioned earlier, a community had been waiting for so long to have t= his issue fixed=2E My sole intention was to find anything that helps with r= esolving this=2E I've also packaged 6=2E18, 6=2E19 and 7=2E0 with the patch= and uploaded it for the users now but as Oscar said the proper way would b= e a fix in the upstream and backporting it=2E If v2 patch by Johannes(no need for sole_chandef) + 5ghz patch from me fix= es the whole issue(I've tested this today) please look into improving it an= d providing a fix=2E Thanks