From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f72.google.com (mail-oo1-f72.google.com [209.85.161.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E8B33A3E97 for ; Tue, 12 May 2026 08:59:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.72 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778576384; cv=none; b=pjZJ8lQwy44ROyBn5uWGnxVFD3mwta2gNYj9m04OtsvQTTtgtKQul0Z2TYIg4TIKui2J8QyP4OBmMF0Mn1EFBLtmDsdAaWTiPturiY1o2i0deyjHTRWC3lJsg4duNHcalclinWluk5hV7iebXJqvF286I3R1IDz5j+Xk6wrBPmQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778576384; c=relaxed/simple; bh=mC2H8311T9z0HVrvQ2u6/GOTyu0FotAU/zxDl3dYgGQ=; h=MIME-Version:Date:In-Reply-To:Message-ID:Subject:From:To:Cc: Content-Type; b=JptUywvR8oVxg5j4X3qXSiHANjFvIL+6C/rqYnN/CeSeZ0bQgN9OhX9+LbfFC3IqcCVmrSxYP5EELKxTVpGA/VJKAT5NmX6doqSt3Gb2Gn0JyMmSGmtHs9S5uDxQPXRAEQr65aDj8ye7Sfmqji/R+uq32hrJflynEXbHZ8inW9o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; arc=none smtp.client-ip=209.85.161.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com Received: by mail-oo1-f72.google.com with SMTP id 006d021491bc7-69649771a5aso9663377eaf.2 for ; Tue, 12 May 2026 01:59:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778576377; x=1779181177; h=cc:to:from:subject:message-id:in-reply-to:date:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Qry07HiLRpI4moE29vwWP3imXR+DsmNoqtYT3jSQb00=; b=fKqWFfYT42Bvl8i8dmCfcCFAotJEhfmoMaGx7uAnT4YVVoA8RZQXtZhrO8Ci5Os1Lr U3s7Y/smpjV89oxPJ7DjhH5gAOcAjjJeuLqgZIufsrmZnP57w2jUcoKSNwdMeqZhhFhE 4XWxA6RleMGnlZgQh7De70yq8RplonbHkTmHRLHUJPgDgX9IqEBq0xUS5poT2ZAgNcYt uUGNsFXvoIsw7xw9nSGcHXJzqc+kYoGN+yIaVlB140XVVZGcyXrbJHcva53dkkQR8Uso XHXD6pByf+8xQs9RqLzJU7MQIv8qHG78FSQimqNhHoLzoxePcS99n4BU/FInCTYcnWHa cl9g== X-Forwarded-Encrypted: i=1; AFNElJ88x4l0/GgZ6kkXblw/9qgo6w6VSptRy8qZNQoYwF0DFL7kktpUiQvsdM5TnP/ATR+LQc0j0opg2ztRPO0=@vger.kernel.org X-Gm-Message-State: AOJu0YxdMjYCfA6yDo2/rkYcIkF8ut5s49jFpAGiz/teWA/X2oorzkl/ CeJbsf8ujRpq3rBvQQQKs8iO9qmZr6vE3MQtE9ps1W2UlAn3IyiMOOB0TEh4023rSeBaR0mZt6O CPWrt88OATOmf47KXx9ZBZsIv3zkhmBtso6XjAdJSmWfE9VzG3/D/+T3zJbU= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Received: by 2002:a05:6820:190e:b0:67e:36e9:79ac with SMTP id 006d021491bc7-69998cc3719mr14591303eaf.27.1778576377620; Tue, 12 May 2026 01:59:37 -0700 (PDT) Date: Tue, 12 May 2026 01:59:37 -0700 In-Reply-To: <20260512-virtio-gpu_wait_event-v1-1-207eb4c1a69a@redhat.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <6a02ebf9.170a0220.7f9b3.000b.GAE@google.com> Subject: Re: [PATCH] drm/virtio: add timeout to virtqueue wait to avoid hung task From: syzbot To: ryasuoka@redhat.com Cc: airlied@redhat.com, dmitry.osipenko@collabora.com, dri-devel@lists.freedesktop.org, gurchetansingh@chromium.org, kraxel@redhat.com, linux-kernel@vger.kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, olvaffe@gmail.com, ryasuoka@redhat.com, simona@ffwll.ch, tzimmermann@suse.de, virtualization@lists.linux.dev Content-Type: text/plain; charset="UTF-8" > virtio_gpu_queue_ctrl_sgs() and virtio_gpu_queue_cursor() use > wait_event() without timeout when waiting for virtqueue space. If the > host device stops processing commands, these waits block indefinitely. > Since callers may hold DRM locks, this can make the entire system > unresponsive. > > Replace wait_event() with wait_event_timeout() using a 5-second timeout, > consistent with the existing timeout pattern in the driver. On timeout, > clean up and return -ENODEV, following the same error path as > drm_dev_enter() failure. > > Reported-by: syzbot+d6dd6f86d3aaf7eebe7406e45c1c6e549453f224@syzkaller.appspotmail.com > Closes: https://syzkaller.appspot.com/bug?id=d6dd6f86d3aaf7eebe7406e45c1c6e549453f224 > Reported-by: syzbot+908bd910da5dd79b88de4cf7baf376cc873a922e@syzkaller.appspotmail.com > Closes: https://syzkaller.appspot.com/bug?id=908bd910da5dd79b88de4cf7baf376cc873a922e > Signed-off-by: Ryosuke Yasuoka > --- > drivers/gpu/drm/virtio/virtgpu_vq.c | 20 ++++++++++++++++++-- > 1 file changed, 18 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c > index 67865810a2e7..05e816a0ae0b 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_vq.c > +++ b/drivers/gpu/drm/virtio/virtgpu_vq.c > @@ -396,7 +396,16 @@ static int virtio_gpu_queue_ctrl_sgs(struct virtio_gpu_device *vgdev, > if (vq->num_free < elemcnt) { > spin_unlock(&vgdev->ctrlq.qlock); > virtio_gpu_notify(vgdev); > - wait_event(vgdev->ctrlq.ack_queue, vq->num_free >= elemcnt); > + if (!wait_event_timeout(vgdev->ctrlq.ack_queue, > + vq->num_free >= elemcnt, > + 5 * HZ)) { > + /* The device did not respond */ > + if (fence && vbuf->objs) > + virtio_gpu_array_unlock_resv(vbuf->objs); > + free_vbuf(vgdev, vbuf); > + drm_dev_exit(idx); > + return -ENODEV; > + } > goto again; > } > > @@ -566,7 +575,14 @@ static void virtio_gpu_queue_cursor(struct virtio_gpu_device *vgdev, > ret = virtqueue_add_sgs(vq, sgs, outcnt, 0, vbuf, GFP_ATOMIC); > if (ret == -ENOSPC) { > spin_unlock(&vgdev->cursorq.qlock); > - wait_event(vgdev->cursorq.ack_queue, vq->num_free >= outcnt); > + if (!wait_event_timeout(vgdev->cursorq.ack_queue, > + vq->num_free >= outcnt, > + 5 * HZ)) { > + /* The device did not respond */ > + free_vbuf(vgdev, vbuf); > + drm_dev_exit(idx); > + return; > + } > spin_lock(&vgdev->cursorq.qlock); > goto retry; > } else { > > --- > base-commit: 5d6919055dec134de3c40167a490f33c74c12581 > change-id: 20260512-virtio-gpu_wait_event-e0cdf8675b7c > > Best regards, > -- > Ryosuke Yasuoka > I see the command but can't find the corresponding bug. The email is sent to syzbot+HASH@syzkaller.appspotmail.com address but the HASH does not correspond to any known bug. Please double check the address.