From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751315AbcFXWkK (ORCPT ); Fri, 24 Jun 2016 18:40:10 -0400 Received: from megous.com ([83.167.254.221]:53942 "EHLO xff.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751010AbcFXWkI (ORCPT ); Fri, 24 Jun 2016 18:40:08 -0400 Subject: Re: [linux-sunxi] [PATCH 13/14] ARM: dts: sun8i: Add gpio-regulator used on Orange Pi One To: Julian Calaby References: <20160623192104.18720-1-megous@megous.com> <20160623192104.18720-14-megous@megous.com> Cc: Linux Sunxi , "Mailing List, Arm" , Rob Herring , Mark Rutland , Russell King , Maxime Ripard , Chen-Yu Tsai , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list From: =?UTF-8?Q?Ond=c5=99ej_Jirman?= Message-ID: <6a178035-9d0d-33ea-7afa-28a3bfb03dfe@megous.com> Date: Sat, 25 Jun 2016 00:39:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="34Cul0oThTvIVLxedS59WWI4mOXgvsSQM" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --34Cul0oThTvIVLxedS59WWI4mOXgvsSQM Content-Type: multipart/mixed; boundary="Ob1p0VLXQ3IuDXfEA9clEkbrGmwtoUJqF" From: =?UTF-8?Q?Ond=c5=99ej_Jirman?= To: Julian Calaby Cc: Linux Sunxi , "Mailing List, Arm" , Rob Herring , Mark Rutland , Russell King , Maxime Ripard , Chen-Yu Tsai , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Message-ID: <6a178035-9d0d-33ea-7afa-28a3bfb03dfe@megous.com> Subject: Re: [linux-sunxi] [PATCH 13/14] ARM: dts: sun8i: Add gpio-regulator used on Orange Pi One References: <20160623192104.18720-1-megous@megous.com> <20160623192104.18720-14-megous@megous.com> In-Reply-To: --Ob1p0VLXQ3IuDXfEA9clEkbrGmwtoUJqF Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Julian, thank you for the review. You're right. I added the pinctrl client nodes. Also the patches were split incorrectly, so I fixed that too. regards, Ondrej On 24.6.2016 04:51, Julian Calaby wrote: > Hi Ondrej, >=20 > On Fri, Jun 24, 2016 at 5:21 AM, wrote: >> From: Ondrej Jirman >> >> Xulong Orange Pi One uses GPIO based regulator that >> switches between two voltages: 1.1V and 1.3V. The >> regulator is controlled from the PL6 pin. >> >> Signed-off-by: Ondrej Jirman >> --- >> arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 26 ++++++++++++++++++++= ++++++ >> 1 file changed, 26 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts b/arch/arm/bo= ot/dts/sun8i-h3-orangepi-one.dts >> index 0adf932..ce4ba91 100644 >> --- a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts >> +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts >> @@ -88,6 +88,25 @@ >> gpios =3D <&r_pio 0 3 GPIO_ACTIVE_LOW>; >> }; >> }; >> + >> + vdd_soc: gpio-regulator { >> + compatible =3D "regulator-gpio"; >> + >> + regulator-name =3D "soc-vdd-supply"; >> + regulator-min-microvolt =3D <1100000>; >> + regulator-max-microvolt =3D <1300000>; >> + regulator-boot-on; >> + regulator-type =3D "voltage"; >> + >> + gpios =3D <&r_pio 0 6 GPIO_ACTIVE_HIGH>; >> + states =3D <1100000 0x0 >> + 1300000 0x1>; >> + >> + startup-delay-us =3D <100000>; >> + enable-active-high; >=20 > Don't you need to reference the new pinctl node in this one? >=20 > Thanks, >=20 --Ob1p0VLXQ3IuDXfEA9clEkbrGmwtoUJqF-- --34Cul0oThTvIVLxedS59WWI4mOXgvsSQM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXbba4AAoJEG5kJsZ3z+/xU2cP/3/wBUv8e6NE6ZgjjzTiWiJS QXg1XFbQkB7VjtohImrNUNX+RKD1vtC21WvrpM1JbrPPO/iLChLFE0uwuy3voYkK om+aK+6U0J7RAdq74V0tS9mdGFNNpfmLULwB19V2l1k1bjCprynUNblBk4FEGUy4 WugsOFtF70kLXebGJNGgmJXhV98JNutVWFL6ivSDmsngd3a+vcLd10fhqNG0D+hb /Nn4ZgN9uT96s9oIo3Qj3r/qwXUdcyWQMPZaQpFiDqblUzP/lBSuP0xqXEYt17hF fWw+fRkm+083ZBjHnqprQUysPASH8mRy8zFlolM7rHy7CO19S0fowW4ZMYYh5/ms vOaJCRL9PO4GFV7Zsbe+e05Tkla+qCh1JXpFktLoR4FiCeODOX3Or06zll9qarAq mRv85qpD8dBa2nHvy+07HTyxyKNki7XV0SAyffmxhF/tQCae+pwLLmpaW8Nm52NC SANgHrXZUkiU8lKdLMtD+Lc4IoYmf5o43Jy0Ov1Yx0c39ZdJIaVI+C6HgCz7YaNj anHLny5oYMHY2XjXcbK9GPX5V0XqVL2OM6seGwIcSRBBQDaCm4gYLASmRkFjZ54x sKY3AMu7kmh7Lkp6+bdISsiSg3/W6HSqPh/sWCE0jV4i5E4K1I1Zet07oRFgOcTn Begc7WMR8ecFQ0+5zu0G =i0/h -----END PGP SIGNATURE----- --34Cul0oThTvIVLxedS59WWI4mOXgvsSQM--