Re: [PATCH v2 3/8] dt-bindings: mips: realtek: Add rtl930x-soc compatible

Krzysztof Kozlowski
2024-06-26T07:12:10Z

On 24/06/2024 07:00, Chris Packham wrote:
> Hi Krzysztof,
>
> On 24/06/24 16:48, Krzysztof Kozlowski wrote:
>> On 24/06/2024 03:22, Chris Packham wrote:
>>> Add the rtl930x-soc and RTL9302C board to the list of Realtek compatible
>> 930x or 9302?
>
> Oops. Will fix.
>
>>> strings.
>>>
>>> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
>>> ---
>>>
>>> Notes:
>>> Changes in v2:
>>> - Use specific compatible for rtl9302-soc
>>> - Fix to allow correct board, soc compatible
>>>
>>> Documentation/devicetree/bindings/mips/realtek-rtl.yaml | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mips/realtek-rtl.yaml b/Documentation/devicetree/bindings/mips/realtek-rtl.yaml
>>> index f8ac309d2994..05daa53417e5 100644
>>> --- a/Documentation/devicetree/bindings/mips/realtek-rtl.yaml
>>> +++ b/Documentation/devicetree/bindings/mips/realtek-rtl.yaml
>>> @@ -20,5 +20,9 @@ properties:
>>> - enum:
>>> - cisco,sg220-26
>>> - const: realtek,rtl8382-soc
>>> + - items:
>>> + - enum:
>>> + - realtek,rtl9302c
>> Why board has the name of SoC?
>
> What I have is actually a reference board with the name
> RTL9302C_2xRTL8224_2XGE. If found that a bit incomprehensible so I
> (over) shortened it. Technically it would be something like
> cameo,rtl9302c-2x-rtl8224-2xge which I can include in the next round.

Looks fine to me.

>
>>> + - const: realtek,rtl9302-soc
>> Drop the -soc suffix. The rtl9302 is the soc.
>
> On that. I hope to eventually add "realtek,rtl9302-switch" for the DSA
> switch block in the same chip. So keeping the -soc suffix was
> intentional to try to disambiguate things. I can drop the -soc if the
> consensus is that there is no need to disambiguate the two.

Thanks for explanation, kind of depends on what exactly is this. Most of
SoCs comprise of several items. The entire chip is the soc, e.g.
"qcom,foo1234". It might have MAC/Ethernet/whatever inside, controllable
by the SoC (Linux, bootloader, TF, hypervisor, other VM guest) and that
part is "qcom,foo1234-ethernet". Regardless whether Linux OS actually
controls it or not.

The question is whether DSA switch is part of the SoC or not.

Best regards,
Krzysztof