Re: [PATCH v2 5/8] dt-bindings: interrupt-controller: realtek,rtl-intc: Add rtl9300-intc

Krzysztof Kozlowski
2024-06-24T04:50:50Z

On 24/06/2024 03:22, Chris Packham wrote:
> Add a compatible string for the interrupt controller found on the
> rtl930x SoCs. The interrupt controller has registers for VPE1 so these
> are added as a second reg cell.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
>
> Notes:
> Changes in v2:
> - Set reg:maxItems to 2 to allow for VPE1 registers on the rtl9300. Add
> a condition to enforce the old limit on other SoCs.
> - Connor and Krzysztof offered acks on v1 but I think the changes here
> are big enough to void those.
>
> .../interrupt-controller/realtek,rtl-intc.yaml | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/realtek,rtl-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/realtek,rtl-intc.yaml
> index fb5593724059..ff2f2acea87e 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/realtek,rtl-intc.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/realtek,rtl-intc.yaml
> @@ -25,6 +25,7 @@ properties:
> - items:
> - enum:
> - realtek,rtl8380-intc
> + - realtek,rtl9300-intc
> - const: realtek,rtl-intc
> - const: realtek,rtl-intc
> deprecated: true
> @@ -35,7 +36,8 @@ properties:
> const: 1
>
> reg:
> - maxItems: 1
> + minItems: 1
> + maxItems: 2
>
> interrupts:
> minItems: 1
> @@ -71,6 +73,19 @@ allOf:
> else:
> required:
> - interrupts
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: realtek,rtl9300-intc
> + then:
> + properties:
> + reg:
> + maxItems: 2

Just like in v1. You need to describe the items.

Best regards,
Krzysztof