From: Robert Gadsdon <rhgadsdon@gmail.com>
To: Stuart Little <achirvasub@gmail.com>,
Dan Williams <dan.j.williams@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
linux-nvdimm@lists.01.org
Cc: kernel list <linux-kernel@vger.kernel.org>
Subject: Re: PROBLEM: 5.9.0-rc6 fails to compile due to 'redefinition of ‘dax_supported’'
Date: Sun, 20 Sep 2020 20:50:14 -0700 [thread overview]
Message-ID: <6a352fb6-ae2d-606d-34a0-cfc8ac1c88af@gmail.com> (raw)
In-Reply-To: <20200921022550.GE3027080@arch-chirva.localdomain>
On 9/20/20 7:25 PM, Stuart Little wrote:
> An update on this: I've done a bisect, with the following result.
>
> --- cut here ---
>
> e2ec5128254518cae320d5dc631b71b94160f663 is the first bad commit
> commit e2ec5128254518cae320d5dc631b71b94160f663
> Author: Jan Kara <jack@suse.cz>
> Date: Sun Sep 20 08:54:42 2020 -0700
>
> dm: Call proper helper to determine dax support
>
> DM was calling generic_fsdax_supported() to determine whether a device
> referenced in the DM table supports DAX. However this is a helper for "leaf" device drivers so that
> they don't have to duplicate common generic checks. High level code
> should call dax_supported() helper which that calls into appropriate
> helper for the particular device. This problem manifested itself as
> kernel messages:
>
> dm-3: error: dax access failed (-95)
>
> when lvm2-testsuite run in cases where a DM device was stacked on top of
> another DM device.
>
> Fixes: 7bf7eac8d648 ("dax: Arrange for dax_supported check to span multiple devices")
> Cc: <stable@vger.kernel.org>
> Tested-by: Adrian Huang <ahuang12@lenovo.com>
> Signed-off-by: Jan Kara <jack@suse.cz>
> Acked-by: Mike Snitzer <snitzer@redhat.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/r/160061715195.13131.5503173247632041975.stgit@dwillia2-desk3.amr.corp.intel.com
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
>
> drivers/dax/super.c | 4 ++++
> drivers/md/dm-table.c | 10 +++++++---
> include/linux/dax.h | 22 ++++++++++++++++++++--
> 3 files changed, 31 insertions(+), 5 deletions(-)
>
> --- end ---
>
Confirm that reverting this patch, 5.9-rc6 compiles OK ...
RG.
next prev parent reply other threads:[~2020-09-21 3:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 1:03 PROBLEM: 5.9.0-rc6 fails to compile due to 'redefinition of ‘dax_supported’' Stuart Little
2020-09-21 2:25 ` Stuart Little
2020-09-21 3:50 ` Robert Gadsdon [this message]
2020-09-21 6:04 ` Naresh Kamboju
2020-09-21 7:32 ` Greg KH
2020-09-21 8:02 ` Borislav Petkov
2020-09-21 8:49 ` Bhaskar Chowdhury
2020-09-21 9:50 ` Jan Kara
2020-09-21 10:08 ` Geert Uytterhoeven
2020-09-21 10:29 ` Stuart Little
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a352fb6-ae2d-606d-34a0-cfc8ac1c88af@gmail.com \
--to=rhgadsdon@gmail.com \
--cc=achirvasub@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox