From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E65A6C43463 for ; Mon, 21 Sep 2020 03:50:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 960AB207D3 for ; Mon, 21 Sep 2020 03:50:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ku6LGz56" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726242AbgIUDuR (ORCPT ); Sun, 20 Sep 2020 23:50:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726011AbgIUDuR (ORCPT ); Sun, 20 Sep 2020 23:50:17 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14ADFC061755 for ; Sun, 20 Sep 2020 20:50:17 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id a9so6729532pjg.1 for ; Sun, 20 Sep 2020 20:50:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=y9gUatZD9QuyqAlm05aGA5o/i3RPKk46CeyCbsRfLsg=; b=ku6LGz56JeKHjeFmpWEl07wzZy//X6hghxfPTUEs2dJ//VVW/KfW1ovvdU8tWcIBBg oY6Y12jkFgBgyeUWiJC0ycVjVFPeJtn9IwXdiRMUFqcnLEtyWp/FzcJT2u30Ni0q/Vcl qrQ4hjlGi+TBVTxnzdS2tkxg8g9X/P/MGkMaqLLj3uGtfB9hURWx4ZYSuIwKZ257Jrg0 SWoTMUV4vv3OIglvI8/1JAxJ9wsmmHcxgy6C/5GrcFPaAa24V5N/HSbiYqH/9y6jNEO3 C/tabc174d9sBGPwf6uqIuJ0KbMRwBcICpLaeY3h30PCW9WEF4ZYp4OddN6vpO9DJ1lp NHag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=y9gUatZD9QuyqAlm05aGA5o/i3RPKk46CeyCbsRfLsg=; b=fIvNWtmWmW3wfeGCup3AY4y3AcP12MQXiD673ToYEz1EljPrlhcZVYkIIPmCMvOnW2 C/BSFT+x/fSDqt+kiC8PAOcy+X1Lo2iJFVZ4UtN8tBlvFx9PAvda7oEN1VR91c7l5zpl Be8GfJWAhacI1mg+rxKKzO9pbcldvaWvsdAFlifagZlqFBQh4ZwSxlr7mHOuNm9quk2M 80H4o9iHgWslXLbmd0n3/p5wH6ftPAhqs3f9+7JhUOzdI7Xj/BKJCAMtWBdKSEHAGaaD IWXbGImLhNM3fY2GDS80gaP0fYmBvDWveYRl8IuwT8v4rqODOnCZKtEbT4cIqr5leQZh YNvg== X-Gm-Message-State: AOAM5313TceIrnkScx0Ce35jsTtDiL5qqmsrDYKa4mQuFldfsCxK4e6Y ZpHIbrbfu78lJpLfZnHfd/c= X-Google-Smtp-Source: ABdhPJw2vIajcVfKCt3bhM061zRNdAkhPwk4vl26wbvV7XFnD1bwaY77tGt0/V5JmqyzzYFYta1g6Q== X-Received: by 2002:a17:90a:e60d:: with SMTP id j13mr23401859pjy.61.1600660216667; Sun, 20 Sep 2020 20:50:16 -0700 (PDT) Received: from [10.203.4.217] ([209.58.129.104]) by smtp.googlemail.com with ESMTPSA id e14sm10075566pgu.47.2020.09.20.20.50.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Sep 2020 20:50:15 -0700 (PDT) Subject: =?UTF-8?Q?Re=3a_PROBLEM=3a_5=2e9=2e0-rc6_fails_to_compile_due_to_?= =?UTF-8?B?J3JlZGVmaW5pdGlvbiBvZiDigJhkYXhfc3VwcG9ydGVk4oCZJw==?= To: Stuart Little , Dan Williams , Vishal Verma , Dave Jiang , linux-nvdimm@lists.01.org Cc: kernel list References: <20200921010359.GO3027113@arch-chirva.localdomain> <20200921022550.GE3027080@arch-chirva.localdomain> From: Robert Gadsdon Message-ID: <6a352fb6-ae2d-606d-34a0-cfc8ac1c88af@gmail.com> Date: Sun, 20 Sep 2020 20:50:14 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <20200921022550.GE3027080@arch-chirva.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/20/20 7:25 PM, Stuart Little wrote: > An update on this: I've done a bisect, with the following result. > > --- cut here --- > > e2ec5128254518cae320d5dc631b71b94160f663 is the first bad commit > commit e2ec5128254518cae320d5dc631b71b94160f663 > Author: Jan Kara > Date: Sun Sep 20 08:54:42 2020 -0700 > > dm: Call proper helper to determine dax support > > DM was calling generic_fsdax_supported() to determine whether a device > referenced in the DM table supports DAX. However this is a helper for "leaf" device drivers so that > they don't have to duplicate common generic checks. High level code > should call dax_supported() helper which that calls into appropriate > helper for the particular device. This problem manifested itself as > kernel messages: > > dm-3: error: dax access failed (-95) > > when lvm2-testsuite run in cases where a DM device was stacked on top of > another DM device. > > Fixes: 7bf7eac8d648 ("dax: Arrange for dax_supported check to span multiple devices") > Cc: > Tested-by: Adrian Huang > Signed-off-by: Jan Kara > Acked-by: Mike Snitzer > Reported-by: kernel test robot > Link: https://lore.kernel.org/r/160061715195.13131.5503173247632041975.stgit@dwillia2-desk3.amr.corp.intel.com > Signed-off-by: Dan Williams > > drivers/dax/super.c | 4 ++++ > drivers/md/dm-table.c | 10 +++++++--- > include/linux/dax.h | 22 ++++++++++++++++++++-- > 3 files changed, 31 insertions(+), 5 deletions(-) > > --- end --- > Confirm that reverting this patch, 5.9-rc6 compiles OK ... RG.