From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 078E23C9894 for ; Tue, 30 Jun 2026 09:59:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782813595; cv=none; b=kLFAGp9G3AjiYWeoSA9O51hEj/dYOvrPNWFNOga+0VcfhLoRClkTZvAZV2eeHjPD8mOJYY0O1I+EHILGnY3DQLNE91hBXj2CnDNQmMevtH3FoNjyqQs4Ke6jQ9vGPSd7qaz/yCWo0xdxkbAVLfL5CQ+KYq6qh1IWJlFNZFTMoJo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782813595; c=relaxed/simple; bh=4UErpMtU6C50B+8xUMZwa9JPIAFrrvY9Ovb6uuXTv10=; h=Message-ID:From:To:Cc:Subject:Date; b=aeNSI6MGUFO2chjil+WZxB+ZpBGhhwppqH/iLnW1l2jbSOVnhrTSY79CoxXfIVZyXuI0Ts30+1eh+Y/hRWe/yFnX+9KmKpphqgbX2PxEvlXx7K56zgmvc2ahd/iWFJhBua0Vc1mX8UuRmyL7qjs3ojRBJHcGsSNmCNgd4XjrIK0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RfcLpBHz; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RfcLpBHz" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-474bf35cccdso292812f8f.1 for ; Tue, 30 Jun 2026 02:59:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782813592; x=1783418392; darn=vger.kernel.org; h=date:subject:cc:to:from:message-id:from:to:cc:subject:date :message-id:reply-to; bh=Rwbt4sA20/2rfBe59aV1e6bH46u3U8Si3wH+ZxMQUl0=; b=RfcLpBHz9Q0XJcAaoBWYjlDBbAQSdUR4ZFtLkeWr80J3fQurTFvMHBKDM5UxZCRF7l zvFZWZ8wVxi6wA6pincEo4AEJR6y8I/mAzLvq23H/2qFNgRez/QSE2PLeHL4ysNiOmD7 aTqSIzlvsJw55/L3PIjs9PE9TMmqhvHpp3tnMWcvHtUE9M9Lar7kbZdbU3Hyydjhm3mU UtTKP3QEMY7OHTtHqhNZklKylfAyvtQftzSrZGZbCI/F0ghN7AXU8hOOr9sQCOct9hoe RoJ4Oik8ltXc6AWqvrTXA+GS9OMiUeUNozZQbEzPhzLzvJPqLM3UckkRvyg1hEQjwq9c 1W0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782813592; x=1783418392; h=date:subject:cc:to:from:message-id:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Rwbt4sA20/2rfBe59aV1e6bH46u3U8Si3wH+ZxMQUl0=; b=MNNYdV9wclaExOECmr3vG3Pn59Hi8ekQyWlNNM3L1X3yDadVhklmEDpUYA5rjSueWO WvXVqC8l6QIq1L2JWKLP+mFP/ktnXDNiL/gFs6P+vLm7B0PKcLLq276zb79wEobGUQgi oBnCRGNkBb7kwp+UJYohWaSZLKmaQhPbroitcvU+ITg32wQhmPZA0tUBaXKUEG/5fy7d Tl5onGSegOuIgKFXcTC5BkrqNjRmtYatE+3pBKOneIUOcg2GBIh3/oD7AiogUbqr33EA /jonsx72JfMx1otbsCHPG1LocpEnk+a2FQe9CiMViK2fGB4vRjw77zQlfcnXTwvTSaPk hzFg== X-Gm-Message-State: AOJu0YybUfXc/oby7Nt+icPuKoJNsp2v44lGtFUqr8hNo3kab6/qnsjB 2yyksdDIcVYQbxEllARcdFN5XL8VOjqBNTJGA63bl5PSBBso6YvjA/mc X-Gm-Gg: AfdE7cm+U1upNlXI5dHYf87Z//Rm4n20bLbXbKHfEHpFdoaUj37Ofc+ANgASL39PRTM CDqKI8fhys78N/eyeqiljs+vWNySm7/IZLVTbd5qjUYCSfKlCEFggazvy/u8HMqk4AoRHlq4L2d e0lfC+YB//VaNNdTU+27o0lnCbOhvXUm3EsG5g8ZkqeCEHD+YcUBqcwl7aHUxjIKGTZQpCTFt8l A67Kua16yrEM5jeD3pjxBQdzwTfwBXrmRWVzVlXPxd/N4MzLuB4sG2f7HZvzF9FEI3aKe+sPz8A +nI0/rsJ2cckCBd3GgOCkcgRXBfKx0V/OHsmKUeQZ+Ra9qf14UuFca0c61nI3XRqjg3M5j24aaM JGMKDwviFJhhvg48jWWki5hTR9Zw9MpeDoVpfyjZwZSgbxHVXbpkMRrTMyDoCGe6etvb8cYeB20 1hK2qDCV4X6dgxQ1iVwqzclWd9tlm8Gg== X-Received: by 2002:a05:6000:469b:b0:46f:f12b:e44b with SMTP id ffacd0b85a97d-475530281b5mr3048385f8f.31.1782813592287; Tue, 30 Jun 2026 02:59:52 -0700 (PDT) Received: from gfs2_rcu.patch ([171.22.87.163]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-475641e4659sm6577230f8f.12.2026.06.30.02.59.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2026 02:59:51 -0700 (PDT) Message-ID: <6a439397.39c9bec7.125ac1.2db8@mx.google.com> From: Adrian Garcia Casado To: gfs2@lists.linux.dev Cc: linux-kernel@vger.kernel.org, rpeterso@redhat.com, agruenba@redhat.com Subject: [PATCH] gfs2: add missing __rcu annotation to i_gl in incore.h Date: Tue, 30 Jun 2026 11:55:00 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: In gfs2_inode_lookup() and other parts of the GFS2 filesystem, ip->i_gl is accessed and dereferenced via RCU helpers like rcu_dereference_check() and rcu_access_pointer(). However, the actual i_gl pointer in struct gfs2_inode was never annotated with __rcu in incore.h. This missing annotation causes Sparse to throw multiple "incompatible types in comparison expression (different address spaces)" warnings and compilation-blocking errors under strict static analysis builds. Fix this by adding the __rcu annotation to i_gl in struct gfs2_inode. Signed-off-by: Adrian Garcia Casado Tested-by: Adrian Garcia Casado --- diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h index 6146577..16df753 100644 --- a/fs/gfs2/incore.h +++ b/fs/gfs2/incore.h @@ -392,7 +392,7 @@ struct gfs2_inode { u64 i_generation; u64 i_eattr; unsigned long i_flags; /* GIF_... */ - struct gfs2_glock *i_gl; + struct gfs2_glock __rcu *i_gl; struct gfs2_holder i_iopen_gh; struct gfs2_qadata *i_qadata; /* quota allocation data */ struct gfs2_holder i_rgd_gh;