From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AF2827E1C5 for ; Tue, 30 Jun 2026 10:03:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782813815; cv=none; b=IuOIaugwGAZu4GXILQ2cmXA8fX5HYtvp7+cg7IRWvvX9/h2rLXLqneYHLFq/3LixSFf2lQlhvg1cE3I6/Aks3+jWOGV78+E+cUh3B5DKEp2ERAi6liL+e9K+ROQ/zZDPL8AfE+276u+xA7ool3OhWKWijTuOou9ZIIkDFRjw54g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782813815; c=relaxed/simple; bh=4UErpMtU6C50B+8xUMZwa9JPIAFrrvY9Ovb6uuXTv10=; h=Message-ID:From:To:Cc:Subject:Date; b=nzsebAsIUIatP7vpjRIAwjUXGUizGf0adyl/8K7SwjeVMZSPtP8VvFoM37l4yQxxBrMFl9tD8MhsV5YkWgRVTq6+6WbAPJn1Su8GpZy3mHkcQ8bYhLQeM8qZJ+H4c1zXfSqlrd2o+AG/P1F7anOMk5EN+F8M7BPgqfwtQqHtSI8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QscJnd9x; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QscJnd9x" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-47248615e4dso2600646f8f.2 for ; Tue, 30 Jun 2026 03:03:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782813813; x=1783418613; darn=vger.kernel.org; h=date:subject:cc:to:from:message-id:from:to:cc:subject:date :message-id:reply-to; bh=Rwbt4sA20/2rfBe59aV1e6bH46u3U8Si3wH+ZxMQUl0=; b=QscJnd9xrINVVdPRDE3ytBSakmXYjt87Wqrg1MC+A8Fp6wLXJVbggJOj0dsFBbC7a1 b3JiyOwDa9/sRmNHCRPmzfkoAsBYrulSQJBY+0R75T4RdHyVe31xyKROTvRv/d3lkMsT AmTWg04clLIugH0g5imsGtL+19/uj5YXrPJ3jr2FUcL+CPTsEXTHWtlkcQdXkgeWYJSS 4wLtIH6+gepV5aNEz7nIvenDUpt4T6ZAfs48Co9+OTIl0k4IhVmylsqlHscYE1Z24D20 9MRDEWkt0jUC/RxmjnxSSMOu0T4yDiW+rjboWKpERqBHu3ZpvNzevNqmjGlozzZ9mQTN F5JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782813813; x=1783418613; h=date:subject:cc:to:from:message-id:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Rwbt4sA20/2rfBe59aV1e6bH46u3U8Si3wH+ZxMQUl0=; b=dl1wf0cxlOUF65xIYgpMSd5asL69wypCppPBw6OjztD6k8jxx+sDHrCsXcQts8KLr5 ey1LEIqrhFf+SnqN4UKDZJ0c6IZ4Wkhbjvl5YQ4TZAP8YeXyn8+O5aiMYcDrG5nFMODS g8cSmYyAfy2G/lkJeZrjb/LNsL3dOhYxo0MFZ/2XgdP68jMJJ/luxMYWKbsGdtyVYDbi fG6wL7sW0owLah6mjZhwCdYNNVHDE+RqKylQoKAgPBw5X5572kR3eEHsvtTj7CXi5tF3 +X4C26pk3+NYhVOOchiw8+ZcetTJ4I2S7rNfzbDpqlobbA+96nt6j7c/OggDZ74de7RH 2jGQ== X-Gm-Message-State: AOJu0YzpM4bdHevc93v3llf3XinGK3IkBSbl5XT5UuDbeBm1nQb1T86H rJeQ8gXr9QN2D7OpdNxj9aWjzMgHteG+HHKeiiaDgpDy8xFOKVmiiMr5SHNfrlfwV80= X-Gm-Gg: AfdE7cng2PpxAAbNGixR0yc0ycgeIPsKxPuQSMzWf4SImI/IQynbUbNF/3u7YLQ3aGw DcSgOAnhnLy3DiMUjUTkEgaS1epcLhBwZN8VRcV0HBDj78QbLCkrEK2jwT4BRFBG/zmG9i+yeNW mywwXl6V/R7FaZ5FjgpAgXn+zc6s9NysdzzMi7YLI5Qrjt9r8iBdrSaDVrTr9UwXPlQyIhlpROz K6GocsB/s6pHkLmxC6kz+20GB1nLcEIo4W6rU1fz4sut0FIUIFFlGnbfzS7uJtWP4yJnbCYHNR3 V37uZsiqUxLmqiCt+gB9wQivCc4FZ6yd4MAd9l/X6AivoRxF6EpsUgbHXh/jE1JxjaB2N3IsE3E MX+pKJBT0ApfRui+OqFjiC4SKL4bZaa629l7r76mZFOWTBXQe8HWVktkKtobu8KMQz3fpo/zUFb ONQZdiUe0vz/fxflVBxo9guNCmlkzpjg== X-Received: by 2002:a05:6000:2990:20b0:472:fe1a:1ee9 with SMTP id ffacd0b85a97d-475507deee8mr2932337f8f.20.1782813812959; Tue, 30 Jun 2026 03:03:32 -0700 (PDT) Received: from gfs2_rcu.patch ([171.22.87.163]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47567979eafsm6152888f8f.34.2026.06.30.03.03.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2026 03:03:32 -0700 (PDT) Message-ID: <6a439474.4d70c427.9c655.9b2d@mx.google.com> From: Adrian Garcia Casado To: gfs2@lists.linux.dev Cc: linux-kernel@vger.kernel.org, agruenba@redhat.com Subject: [PATCH] gfs2: add missing __rcu annotation to i_gl in incore.h Date: Tue, 30 Jun 2026 12:02:00 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: In gfs2_inode_lookup() and other parts of the GFS2 filesystem, ip->i_gl is accessed and dereferenced via RCU helpers like rcu_dereference_check() and rcu_access_pointer(). However, the actual i_gl pointer in struct gfs2_inode was never annotated with __rcu in incore.h. This missing annotation causes Sparse to throw multiple "incompatible types in comparison expression (different address spaces)" warnings and compilation-blocking errors under strict static analysis builds. Fix this by adding the __rcu annotation to i_gl in struct gfs2_inode. Signed-off-by: Adrian Garcia Casado Tested-by: Adrian Garcia Casado --- diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h index 6146577..16df753 100644 --- a/fs/gfs2/incore.h +++ b/fs/gfs2/incore.h @@ -392,7 +392,7 @@ struct gfs2_inode { u64 i_generation; u64 i_eattr; unsigned long i_flags; /* GIF_... */ - struct gfs2_glock *i_gl; + struct gfs2_glock __rcu *i_gl; struct gfs2_holder i_iopen_gh; struct gfs2_qadata *i_qadata; /* quota allocation data */ struct gfs2_holder i_rgd_gh;