Re: [PATCH v4 02/21] KVM: arm64: Add SDEI virtualization infrastructure

Gavin Shan
2022-01-13T07:09:50Z

Hi Shannon,

On 1/11/22 5:40 PM, Shannon Zhao wrote:
> On 2021/8/15 8:13, Gavin Shan wrote:
>> diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c
>> index e9a2b8f27792..2f021aa41632 100644
>> --- a/arch/arm64/kvm/arm.c
>> +++ b/arch/arm64/kvm/arm.c
>> @@ -150,6 +150,8 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long type)
>>       kvm_vgic_early_init(kvm);
>> +    kvm_sdei_init_vm(kvm);
>> +
>>       /* The maximum number of VCPUs is limited by the host's GIC model */
>>       kvm->arch.max_vcpus = kvm_arm_default_max_vcpus();
> Hi, Is it possible to let user space to choose whether enabling SEDI or not rather than enable it by default?
>

It's possible, but what's the benefit to do so. I think about it for
a while and I don't think it's not necessary, at least for now. First
of all, the SDEI event is injected from individual modules in userspace
(QEMU) or host kernel (Async PF). If we really want the function to be
disabled, the individual modules can accept parameter, used to indicate
the SDEI event injection is allowed or not. In this case, SDEI is enabled
by default, but the individual modules can choose not to use it :)

Thanks,
Gavin