From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9050931AA87 for ; Thu, 9 Jul 2026 19:34:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783625648; cv=none; b=W8aAuLyJlqC3cpdE/MD0FFI93hC8mj+roK4SVvHlDwxyfo+TvAIjlwiC7x+MbgQvFn0YbBNHy1L0dbKdaJ2Nm5CGAsOJLaL6T+dFbkExLqsjqngnkZTi6wNzfG9Ob/iWheiBP/UqSN9ix18a3m7fxds7GEc+dsNEqSP6AXcRXWw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783625648; c=relaxed/simple; bh=JGAI6q9kLL1tKj/cfaA7h5qYsJKerfZ6CUiwwiwN760=; h=Message-ID:From:Date:Subject:To:Cc; b=c6LOAJy0h6e0t9ff3rhAFXQEDJnRu/jWkQqGRdPsIIDZiB2GTRj0DWSL67m7O6n94U0MbZTXJ7KJQl11vmYnBWqMP9X8LPk8oC3MONaHcy43nujiwvQ/bXNiG8cL+RvG4gEgYbW9NZoDAjCsY/DWC8NFowcB4/nAHWAlQW1IJHQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FzSp3pdN; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FzSp3pdN" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-493ec555a26so1202345e9.0 for ; Thu, 09 Jul 2026 12:34:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783625645; x=1784230445; darn=vger.kernel.org; h=cc:to:subject:date:from:message-id:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6CQ6zJLDn5aN6cZk8Pts4DCUGUZw96d49DXcY2VMoDc=; b=FzSp3pdNpB3EXQDnuxXMXxWhTPwsebKZxYHbA8m/Jkc/JkSAtIWnC59ZFv+4Ou7l6D 20lUqRLXUhCyvZoGXnFmWTXYaFUjQ4JIOaGfALEMEJRtTU2X//SilSCFuyxvnxhCc50w xqOaQ6KylSkmRDy/bDre+T4LFKlXpo0GdwAbBOLY/wO0iJQGWKWVUhYpqswKhogCJ0EX CdfUxVPnGNRD5n9gVIQJw+5Buqll59LfXpWoPeoJx4hT16gpBtA5GChgcOCPQ7741ncm YJ6x2ebAHT/kANfPUnRKBBcAsuIvAThv4M4SqhH3DCU0vaiinaPmMMbB8d3HK9/Q8xJM Qbvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783625645; x=1784230445; h=cc:to:subject:date:from:message-id:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=6CQ6zJLDn5aN6cZk8Pts4DCUGUZw96d49DXcY2VMoDc=; b=JMWhBbhJCNQOhgLKu5XMnCAy1M01QS395SrGWdZtB0HsZKOxYsEGe5/NCm52MYU+kv bGAu/zjY/CE0VNtj7XvPD0QWP9L9eTtK9qP1FPvr6VkQUVQ+v4qov7QngejCsnKGlICy cN4lVN88R3UEnN6c0FmvXvozRvGPPLPYYr7jma021pdY2sEdUMzatLXbXIqi8tDqyAGF vJv4AAZcQmgfqReBEmIOGK0LDUMHMGOzYcq/k8/priUZsL1irzKEKZOfFsfIljiJluZh JvMnJz8RCQeXu+VXL5iPEr/lcaYuM15+juf0OVhnkUkA7YgMbaDS48SYfBRABkpBpKsZ /fxw== X-Forwarded-Encrypted: i=1; AHgh+RpFFoNiHxx22kxPXN7Fr5Vp1qZEM251f445Y9/kHgYHtSpEq+3DgOTuzRJGbM21hpSxnrAGmjV1T887DUI=@vger.kernel.org X-Gm-Message-State: AOJu0YwmGWYOrkXUMWjKkXPcAR++wOcaYYU9H46N6szfT1LJAA5wUc+0 XzkEwZznOObN+2xTzRNdna69fx8hWFIhVzlcypSh1rSuoDKIMtN0ylfs X-Gm-Gg: AfdE7cm1wYShnhjtl3Y5GRXmU5Tcy08yiP0qCzFDaD0K9TJsfDXb5uo1R9q3r6NZBA0 g0ztm97idqi5ieF3DFnlizRvA5WT1kOWPQVe/TRdMIkG4JA4uCMgTeHXyxccfDW/Me34F35zyik W/wZeCN9H8B59rAWqj2lGHnLsbfgeVA40m8FkMQmD2SHO2YGErw5dEbwaq30/7iV817eVK1I3hq nVp83OMnwJBBkZm4aRonR+4eX2WF6Kx4V91aYCeaM8aGx3FPPXteIaS+Arjucrjr2fZxqMAJFil LOlAjnbEUa64/PEkPzyWcZPjxgQlju9U2DalG25LDk84RSWxXNd6Bu4kD/QPtO9L9jVbRzE149N SmkyWDkqshk0CFN55OoTa6j8VLa4Tt6t75ASaorBWoCiBl+BYZ7tcES8RZgmmUcYZSG2nOLxgAv AtbkQLPjoBbJGUeAEMJkbFr9FQZb9zovZL1GeVwiiaLGheR4FkhYnhNuE= X-Received: by 2002:a05:600c:46c8:b0:493:b499:3ef2 with SMTP id 5b1f17b1804b1-493e68da50amr86703625e9.37.1783625644621; Thu, 09 Jul 2026 12:34:04 -0700 (PDT) Received: from legion.localdomain ([92.44.171.31]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493eb742a49sm80116905e9.12.2026.07.09.12.34.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 12:34:04 -0700 (PDT) Message-ID: <6a4ff7ac.cef1946f.13cfe2.dd63@mx.google.com> From: Batu Ada Tutkun Date: Tue, 23 Jun 2026 15:35:08 +0300 Subject: [PATCH v3] staging: most: dim2: use dev_err_probe() for clock errors in rcar enable functions To: Greg KH Cc: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, error27@gmail.com Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: rcar_gen2_enable() and rcar_gen3_enable() use the old pattern of dev_err() followed by return PTR_ERR() when devm_clk_get() fails. fsl_mx6_enable() in the same file was already converted to use dev_err_probe() by a previous cleanup series. Convert the remaining two functions for consistency. devm_clk_get() calls clk_get() which can return -EPROBE_DEFER if the clock provider has not yet registered. Using dev_err_probe() suppresses the log at error level in that case, avoiding misleading "cannot get clock" output during a normal deferred probe. clk_prepare_enable() cannot return -EPROBE_DEFER since the clock handle is already acquired at that point, so those error paths are left as dev_err(). Assisted-by: Claude:claude-sonnet-4-6 Signed-off-by: Batu Ada Tutkun --- Compile tested only. No R-Car hardware available. This is a correctness fix for the deferred probe path, not a response to a reported user visible issue. Changes in v3: - Add Assisted-by tag per Documentation/process/coding-assistants.rst Changes in v2: - Mention clk_get() explicitly in commit message - Add testing note under --- cut off line drivers/staging/most/dim2/dim2.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c index 7953d4626..56f856d6d 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -974,10 +974,9 @@ static int rcar_gen2_enable(struct platform_device *pdev) int ret; dev->clk = devm_clk_get(&pdev->dev, NULL); - if (IS_ERR(dev->clk)) { - dev_err(&pdev->dev, "cannot get clock\n"); - return PTR_ERR(dev->clk); - } + if (IS_ERR(dev->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(dev->clk), + "cannot get clock\n"); ret = clk_prepare_enable(dev->clk); if (ret) { @@ -1019,10 +1018,9 @@ static int rcar_gen3_enable(struct platform_device *pdev) int ret; dev->clk = devm_clk_get(&pdev->dev, NULL); - if (IS_ERR(dev->clk)) { - dev_err(&pdev->dev, "cannot get clock\n"); - return PTR_ERR(dev->clk); - } + if (IS_ERR(dev->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(dev->clk), + "cannot get clock\n"); ret = clk_prepare_enable(dev->clk); if (ret) { -- 2.53.0