From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA5C91CAA65; Sat, 11 Jul 2026 00:45:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783730703; cv=none; b=ux5LHY5RNH19ahocCNzkSKzVBrkyjKgVYukTISEeU30Wp/ZvkUH8rXmb8hmn4125G7cKENw9bzSNUV6ln7OiIYTvu2MAdfZ/EvaRB2GprOIXe4nug/UMDYYRFNk80Qpa3gXX3hR60R0DJidvNurVaQJrC2YnJH5BRpQ0KUSgFn0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783730703; c=relaxed/simple; bh=GRGathIQPJDGY81vbSSFInPKSN8SwR8AZqBYKQchyi8=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=vBoSd04bPKB0acc+YTe0MwJtf0rvCpNWnJJkOF2MYfVtEkmlABm96MqCPGe+3mhfkRJqtWZbu9LWBIgPWEU2cAN5+C2CSMuywTsXk30uCNGNu6VpZQ2YLTtWLwnXWgxmkm54jzXR3XTT/ASnnY+uJKjNTEmqGB0dqliVZw4vBt8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UTpii3ZT; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UTpii3ZT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1A141F00A3D; Sat, 11 Jul 2026 00:45:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783730702; bh=KIlT+GTV4WhhrNy4N/2keFT3wGvoTbsHteN+Z3WZskc=; h=Date:From:To:Cc:In-Reply-To:References:Subject; b=UTpii3ZTDjIqVdqCN3Y7JfG8857lWe/8ShEDy/EdfU3y/XMnyR+G1cxIkOL4O+39U DhJyWR41oHjppG+ui0PPQ4f06lLHkzHP5JETmOobXocWuKLRdZ4XRZ2qM01xe6gGFs TUOBaN/2ZcbgNJ7OdTpd0LDccKTM0pD+uMugDiJmAe5wcEll+CVo8U4xyouB4gbKXR LJGPccgGwIoMJGU0hcB8CCrfZ/9m3pF5ef46DuTkdn57vH6bhuljSDDgkXng5mlRaX cqnDsFAKwQajYYT3g8dp1yzEmqxojWvcOBpnPKAKnfVnZVBkblRry+ZIqYqzfiM3al OyKh72u6/dtUA== Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfauth.phl.internal (Postfix) with ESMTP id C3820F40213; Fri, 10 Jul 2026 20:45:00 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-01.internal (MEProxy); Fri, 10 Jul 2026 20:45:00 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTF2lv/BTmJtmx58UCBnX4LYuS/hSPolWJtMhIC6n0miZhX4RDMWuAT1Cl4GARjHte lqEr6OARdwjx3wovv+JqFFm48+pvz4Zx4EQgeWrHiwpat62fKOUYIDPSrStJXAVJdwqAxx 1VEqZJrIf0stTWrfvXtzf0i7jWSJNy8uf/jMXDtx7Ywygxat1p6MeXmPc0lsZiFUkLa3sn qa6w0Xk6djDcgTGYwGlBlj0VErXEEYhYZKCiUyzXOxRQ/T3BtU3+nzlNyVrmTVdMzrm/96 wcvb3aTmxG5/VfGOD77r/GAytqa5b3EPaQD9Vf4C29SbV+quV+TOBZUtmCKPnndUNJDSRZ +ToTW+SzNgQPekcbdtuVHSCZJfTWEvui+ohy6FWXQGTH1WxWfOkyT5SfiV0QmnNv9YTVyW Az3C/jQXQ4aeolLcpVA+KSPE8sQ/+V81F48UYQyA6+hB3F5Tcft4haEs5wdocS7yCVLRmM eSiI1bmkYAGgHgFPZbPfSjjX7xTDURKGauaHAqJAUKmeWcQOaIbRLhfpOBpXDtRQUr4SiG 51D5Yz83d+midz8y+A0C1ngj1l5eqsImNnder4kQrBTBEBTa0W2jRC0Bk7wTpgyAL8NADc UEb/7ghPKpmuk6TFsfN4MhANBLmxJZlqzMh+KiUGp/hqzMkKRBDuput0FGOQ X-ME-Proxy: Feedback-ID: i67ae4b3e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 10 Jul 2026 20:44:59 -0400 (EDT) Date: Fri, 10 Jul 2026 17:44:58 -0700 From: "Dan Williams (nvidia)" To: Gregory Price , "Dan Williams (nvidia)" Cc: linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, driver-core@lists.linux.dev, linux-kselftest@vger.kernel.org, kernel-team@meta.com, david@kernel.org, osalvador@suse.de, gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org, vishal.l.verma@intel.com, dave.jiang@intel.com, alison.schofield@intel.com, akpm@linux-foundation.org, ljs@kernel.org, liam@infradead.org, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, shuah@kernel.org, iweiny@kernel.org, Smita.KoralahalliChannabasappa@amd.com, apopple@nvidia.com Message-ID: <6a51920acece6_35cf3310061@djbw-dev.notmuch> In-Reply-To: References: <20260630211842.2252800-1-gourry@gourry.net> <20260630211842.2252800-8-gourry@gourry.net> <6a5016bf71df4_3b7ee5100b3@djbw-dev.notmuch> Subject: Re: [PATCH v6 07/10] dax: plumb hotplug online_type through dax Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Gregory Price wrote: > On Thu, Jul 09, 2026 at 06:08:45PM -0400, Gregory Price wrote: > > On Thu, Jul 09, 2026 at 02:46:39PM -0700, Dan Williams (nvidia) wrote: > > > > This was more a matter of having the DEFAULT set consistently across > > the dax driver variant probe() functions to make the behavior explicit. > > I didn't want an un-set value bug to creep in here somehow. > > > > Happy to drop them if you think that's unneeded. > > > > Ah > > Not setting the value in each of those places is equivalent to setting > MMOP_OFFLINE (0), so better to just set DEFAULT regardless. > > So unless you have strong feelings i will keep them as-is. Right, the mild feelings are only coming from the changelog mismatch which says "Oh no, device-dax drivers can not specify their online type besides the default" and all this series does is keep the status quo. That can be had by just having unconditional: online_type = mhp_get_default_online_type(); ...in dev_dax_kmem_probe() and get rid of dev_dax->online_type until the first user arrives. If you are respinning the series and that patch drops, yay. If not, oh well.