From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f71.google.com (mail-oo1-f71.google.com [209.85.161.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E29037E5DA for ; Thu, 16 Jul 2026 11:24:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.71 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784201090; cv=none; b=iHLU15AASYg1kzXql64727vcn0AgqFW8/Yb3g1+/8KZVv2XDnch0oGgTmX5C5u/YfQ/gpcTxTcAzvPQV944IBkN0VW3zuAFfa6XhQOEsIZ3o2USdZl5Ksfg4b2j+tD12gMOyZ5isTV1uA0SKyQvi4V/uIwLfG1gq1r1OypSFLss= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784201090; c=relaxed/simple; bh=tZiZSF3+JSKJpEeI+7cpWJbfZpe9xvnM5psgQKfoToI=; h=MIME-Version:Date:In-Reply-To:Message-ID:Subject:From:To: Content-Type; b=BzNsYufrcJrg/6GvKMnZokIaARBV1vtHMcFVqiDQutcxaBomMnxJ6Lv392jQFbOJYdOuwglpZrjSyYOXUGd1EzFz/xeus4BiCvzTADs5KrbsR7a0YmBzxigUiYWSg/gni8Ycusswx+QEu857LNbps060tirNNRRStY0sLz0tXXw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; arc=none smtp.client-ip=209.85.161.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com Received: by mail-oo1-f71.google.com with SMTP id 006d021491bc7-6a1632e1c13so4819731eaf.0 for ; Thu, 16 Jul 2026 04:24:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784201088; x=1784805888; h=content-type:to:from:subject:message-id:in-reply-to:date :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=h0IsKm9nwEJTv+TiNB2dybE6+JVTCvwBevqkbOI3lcU=; b=WrxQO/g758qFPVwhrw67UUJKhcc8+Ydxqs3wxM97lsBDkOJXYznld0kBy8NT/s6o0P 0jWf8H8wf6LIs4IlU9gctomeUNlea6VQ4tUl9pQIWeM+bWlObh6HLRWf73zlGb1QcfBV shMf4cW1/VgHNK1XvYMYsh3EDDUh5PsBT9smWkdqsMtPD4oPY9YSJYzkWfUWVtNhpjyl maODUq06NoHcbtY/rRqZ1QLhL6l1QY53qjsNFmzVec3cubLTvQVjtJ1JLiXKLMIGMFVT +n0p5F2uiNWCCFttE1Po4RPV10oL1WbO2sBUTZiJ4gWjtQZcrIhRtSFFjoQgfL7tHJdQ V8Xw== X-Gm-Message-State: AOJu0YxXGDC4SFj4nlnKujJnDYgY5Krn4OHmMOMUEwh/gX44W/Uz5/GZ DrwgrLxMoBINUv4eUXA6I3MBgTr2OLwr6CTgF+B17BZ2pm7KtzlphfC0T8a7E9sn8G9icdhpxtR maJcgGwkCBItrPYfiT84yh6OP3CQdGlHtap1nWy/McW1WMzx1hONfaQPbSGE= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Received: by 2002:a05:6820:1a03:b0:6a3:1f3d:a9d0 with SMTP id 006d021491bc7-6a3cb7e27a6mr6345961eaf.15.1784201088272; Thu, 16 Jul 2026 04:24:48 -0700 (PDT) Date: Thu, 16 Jul 2026 04:24:48 -0700 In-Reply-To: <6a56fb92.c90005c7.37d349.003c.GAE@google.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <6a58bf80.577457d1.8bd2.001f.GAE@google.com> Subject: Forwarded: Re: [syzbot] [media?] INFO: trying to register non-static key in __vb2_queue_cancel From: syzbot To: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" For archival purposes, forwarding an incoming command email to linux-kernel@vger.kernel.org. *** Subject: Re: [syzbot] [media?] INFO: trying to register non-static key in __vb2_queue_cancel Author: gautambhadori9@gmail.com #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git cc2b5f627e8ccbae1188ef2d8be3e451d7f933a5 diff --git a/drivers/media/usb/em28xx/em28xx-video.c b/drivers/media/usb/em28xx/em28xx-video.c index c418add65b..d93f1b5049 100644 --- a/drivers/media/usb/em28xx/em28xx-video.c +++ b/drivers/media/usb/em28xx/em28xx-video.c @@ -1410,6 +1410,9 @@ static int em28xx_vb2_setup(struct em28xx *dev) if (rc < 0) return rc; + if (!em28xx_vbi_supported(dev)) + return 0; + /* Setup Videobuf2 for VBI capture */ q = &v4l2->vb_vbiq; q->type = V4L2_BUF_TYPE_VBI_CAPTURE; @@ -2416,7 +2419,7 @@ static int em28xx_v4l2_fini(struct em28xx *dev) if (video_is_registered(&v4l2->radio_dev)) { dev_info(&dev->intf->dev, "V4L2 device %s deregistered\n", video_device_node_name(&v4l2->radio_dev)); - vb2_video_unregister_device(&v4l2->radio_dev); + video_unregister_device(&v4l2->radio_dev); } if (video_is_registered(&v4l2->vbi_dev)) { dev_info(&dev->intf->dev, "V4L2 device %s deregistered\n", @@ -2954,6 +2957,7 @@ static int em28xx_v4l2_init(struct em28xx *dev) mutex_init(&v4l2->vb_vbi_queue_lock); v4l2->vdev.queue = &v4l2->vb_vidq; v4l2->vdev.queue->lock = &v4l2->vb_queue_lock; + v4l2->vb_vbiq.lock = &v4l2->vb_vbi_queue_lock; v4l2->vdev.device_caps = V4L2_CAP_READWRITE | V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_STREAMING; if (dev->int_audio_type != EM28XX_INT_AUDIO_NONE) @@ -2983,6 +2987,11 @@ static int em28xx_v4l2_init(struct em28xx *dev) if (dev->chip_id == CHIP_ID_EM2828X || dev->board.decoder == EM28XX_BUILTIN) v4l2_disable_ioctl(&v4l2->vdev, VIDIOC_ENUM_FRAMESIZES); + /* Initialize the queues before registering devices that reference them. */ + ret = em28xx_vb2_setup(dev); + if (ret) + goto unregister_dev; + /* register v4l2 video video_device */ ret = video_register_device(&v4l2->vdev, VFL_TYPE_VIDEO, video_nr[dev->devno]); @@ -3068,9 +3077,6 @@ static int em28xx_v4l2_init(struct em28xx *dev) /* Save some power by putting tuner to sleep */ v4l2_device_call_all(&v4l2->v4l2_dev, 0, tuner, standby); - /* initialize videobuf2 stuff */ - em28xx_vb2_setup(dev); - dev_info(&dev->intf->dev, "V4L2 extension successfully initialized\n"); @@ -3082,7 +3088,7 @@ static int em28xx_v4l2_init(struct em28xx *dev) dev_info(&dev->intf->dev, "V4L2 device %s deregistered\n", video_device_node_name(&v4l2->radio_dev)); - vb2_video_unregister_device(&v4l2->radio_dev); + video_unregister_device(&v4l2->radio_dev); } if (video_is_registered(&v4l2->vbi_dev)) { dev_info(&dev->intf->dev,