From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA2402931D6 for ; Thu, 23 Jul 2026 18:38:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784831897; cv=none; b=HsfJSk1yD6DdVRNBi9Jw5ofelJAhgjOQj/6H7m4sJQi2byEtsa0luJDaxJTK6E2QCShWWAsKbgR0+vlr4WRo509e05e02Pxw/SM7RaIMreX4ONklRzcWSm8NwMckDHDPwIduTkhbpqE6cGnok6K9GnuAr7DoISzC/BGic2qXC0Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784831897; c=relaxed/simple; bh=nzG4awxgYfrlyx9Luz617YX5oT+UjV3SFnHCznNjdDg=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uAbLaVywHicdvSOH02m7ZPHx8gmYDz8KeAnL0GYMMlYLUTBDK3Jab7C/DgKnNXTz4Latt7DuswQRx6CDGrTKQ+gHPzslRPRgmBTHgmVzK21MzLNz8AjynjjTCtXn/OGrfNM/4VRO6wZ4RcMVLcHCbnJAyc4TgMAFbilGC9QdpFg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=q3baiUl0; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="q3baiUl0" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-47f703a9e5dso413069f8f.0 for ; Thu, 23 Jul 2026 11:38:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784831893; x=1785436693; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:subject:cc:to:from:date:message-id:from:to:cc:subject :date:message-id:reply-to:content-type; bh=mQh8Ebl2z6PI6INJ382vkExB/1zYbiEiM8I01ow3Vog=; b=q3baiUl0KU0vhV7XIUY8UgLk6WUJkdFv62CRIgrnnEVsnxw9cBofQB9I/4L7jZRE/g 64JAzh+bfdUy57LDnKMo2Q/5ffLNbhnOEB/g8z73gBdReTWszvKrsFzqh5DCi6PbmZL0 FXgGiKdJn28ft/xgtwHqRMwXHC79RQnMwycm5OQvNQ5mZIXylFLw7JNT9QZPA9JLjWAz jOcBcVn7T2+W6Ehyz6R0uknsyq5ciDrLE8HpyLk2tU5pN83f9iuOj4IbMOa/C4SK9emN xS1BVx2LCLNz/q2JABcPOvctTUuJZfP74QY/F882LjFO+dB3jXApnyB/iYRhcMk8pXNP m7NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784831893; x=1785436693; h=in-reply-to:content-disposition:content-type:mime-version :references:subject:cc:to:from:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=mQh8Ebl2z6PI6INJ382vkExB/1zYbiEiM8I01ow3Vog=; b=cW6MUPBzzlANqv0hP5Xi9MIntlXYXKO9T6+lcnVw09cU1AWvTeqjaIdmlEQ4AcIEV/ V1Xb8dabyHN6odP7XCDvvQV0qNrQSZqvqYyxlza9dYJBOOhGKy00uVMe3ZUm2nWdfiQe RDZHoI60oDy7gnUsADJsk4KDnhwCGa3VPQS4tT/ql4apMzuePvd/aL4h4tw9EHs44YX1 TNbhWrK0ynSw55fnmk9jA26bULi62nN9RDJkXjOErsOS8MCm6QGM9Ek++9xOE2ohDFFm BTTAAaNnOFbWZuwGVP1FJhdFBhJbCdwzsR/a033BQq99cCQFYxWz4rfO+ouxYHRIcmEd kbeQ== X-Forwarded-Encrypted: i=1; AHgh+RqYok/yGZud+JR7KKTQdrf6g75REOUvGZxLVtP3brz8HuFHtc0TymqrwsRbFU19K65flF9wYrdYHLDH4RU=@vger.kernel.org X-Gm-Message-State: AOJu0YwCv8uK9cj79XF6mEtl/OXjKsaSZ3Izkt/1H4ZdTvLjnWh1pttd yHnGMd21Y6agkon2aQOYm0/zPPMsl/azf0JCNFhF0ucWT6Y+It1UEbXc X-Gm-Gg: AR+sD10vIBjmOGb4R8KqwdAGh3nMAC+v5nPBr8vDpu4FOo15iKTlfYaPg1l/kk0Fktt 2G5RISG8jIYu4eSb1pgQ3D7qGzI/xCiyKHE8uZbO2fEZr2VFHhm4Br5IpMPQy89rodChRaDq8xF bCfyFycmx6mFM3R0M5xv9Hb+vD1URthoE32ZU9dH8dUKAmdZYFCVFknzwN2z+V2MIqCf/XO0Npd 6s/NKtCU0khdB8BMhoOhtWJzn9XUYcUAhVqjXxPdoFdf7JA3wyZ6djbb2rnwqkl3rnjTVuNXocd XskuqH6P8ni3oZ4mN8HOADE0kst+0rproKOqqn2PaW1iYXBu0lcDEzt2gTBj/tT5NWS+zNzKf7m R5I9A3eZ9ci4cqabjE7YghqlDHRGhQHAESfrB6DMdGCqMHr2fxYps5hLiYhfXtYHhaJCJsFLrKF ByAV8HRamV7HS13UrlWHVG9tnygZuP8o8aI04hygKFTrTByqk= X-Received: by 2002:a05:6000:1846:b0:478:77c1:787c with SMTP id ffacd0b85a97d-47f8d76ead4mr5907181f8f.56.1784831892999; Thu, 23 Jul 2026 11:38:12 -0700 (PDT) Received: from Ansuel-XPS. (host-87-3-249-180.retail.telecomitalia.it. [87.3.249.180]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f85c6f076sm18328564f8f.34.2026.07.23.11.38.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 11:38:12 -0700 (PDT) Message-ID: <6a625f94.4d70c427.b2b96.9b5b@mx.google.com> X-Google-Original-Message-ID: Date: Thu, 23 Jul 2026 20:38:09 +0200 From: Christian Marangi To: Dmitry Baryshkov Cc: Konrad Dybcio , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 1/2] ASoC: qcom: remove ipq806x Storm machine driver References: <20260721-drop-sound-storm-v1-0-23ae4a689ffe@oss.qualcomm.com> <20260721-drop-sound-storm-v1-1-23ae4a689ffe@oss.qualcomm.com> <85f2799d-fadf-478d-9f3f-fb8ff91ba84d@oss.qualcomm.com> <6a609d87.87c5160c.1accad.0f33@mx.google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jul 22, 2026 at 01:48:30PM +0300, Dmitry Baryshkov wrote: > On Wed, 22 Jul 2026 at 13:38, Christian Marangi wrote: > > > > On Wed, Jul 22, 2026 at 10:00:34AM +0200, Konrad Dybcio wrote: > > > On 7/21/26 8:12 PM, Dmitry Baryshkov wrote: > > > > The Storm board machine driver targets Google's IPQ806x-based Storm > > > > reference board (a MAX98357A DAC wired to the LPASS I2S bus). This board > > > > has no upstream device tree, no active users and has seen no functional > > > > changes in years, so the driver is dead weight. > > > > > > > > Remove the driver together with its Kconfig entry and Makefile rule. > > > > > > > > Assisted-by: Claude:claude-opus-4-8 > > > > > > Using AI to `git rm` is definitely tokenmaxxing! > > > > > > > Signed-off-by: Dmitry Baryshkov > > > > --- > > > > > > Reviewed-by: Konrad Dybcio > > > > > > > Honestly I'm pretty angry about the latest changes on ipq806x. First the > > dtsi just because there weren't device (it's ok and understandable) now we > > are starting to remove driver... > > > > There are godzillion situation where there is a driver but absolutely no > > dtsi. Lets remove the dwmac driver, usb phy, pcie and everything else at > > this point and treat this soc like it's a 80-90 code... > > > > I will post dtsi with actual device for the SoC but really I'm not > > following all this hurry in cleaning code for device that still gets used > > and actually some company even produced new one (even if it's EOL) > > We have no way to check that the device is being used other than the > DTSI present in the kernel, being updated from time to time with > non-trivial changes. > > For the patchset in question, do you (or the community) actually use > OnHub? If so, please consider upstreaming DT files (and also updating > schema FWIW). > If not, the files will eventually go away. Just having unused drivers > _adds_ a burden. I stumbled upon the driver while reviewing a patch > changing the driver (for the sake of changing the ASoC API). > > And FWIW the series doesn't touch the IPQ806x LPASS driver (which has > a DT counterpart). > Yes on OpenWrt we support 3 OnHub google devices from Asus and Tplink and they also use the storm driver for the strange attached speaker. -- Ansuel