From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 767C7367291 for ; Fri, 31 Jul 2026 06:45:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785480354; cv=none; b=bVHQhjEvpXW/u0assshW3wUDkBWRj9n0QGXsKE6UTaqQrIjcmb9TpYB/LmysqXV63L6wyRJQpgDQDdVIaxaqzAxox4mCvtFZyo+nSACy83gppYeE6iVYRoKnvZPLLJ8KDgYbrO1YzpdMt8YUJeaJZ5foMiOZHKxJkGTqyIqZc10= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785480354; c=relaxed/simple; bh=yEJiRz0ut4OqquzOoDrHCNnJmPbJdaHDKmPFO5dEKhU=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=vAglOjI9pztUz53iuepOCaFOW8r6Ae9Yo0xjK+MrTjjOuUMptzGGGV85JQ9YPhK1ROS8Qs50ogbYyNA9opR/Izc1TzWJUHQ39NFLfvyygLXoy0jwlI8M0ApOY32wKKRo7fLdKHieuYWQfXKxnd/t54TTwqLrb0eBaYv6TMK62Cg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VBTMoe8B; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VBTMoe8B" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-6a07a051a81so1107607a12.0 for ; Thu, 30 Jul 2026 23:45:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785480347; x=1786085147; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:subject:cc:to:from:date:message-id:from:to:cc:subject :date:message-id:reply-to:content-type; bh=MIbPeVG4258G9HKd8kCy72K/NwqK4KgRygqC+exQgG8=; b=VBTMoe8Bpe/kfyG76gYWE7s7OqYe2JbfgKTQPQhPjWBXZkBPclmUY1V/abEp7eAHVl bsUx3XDYAs2iGg+gHysd8JEbRfZR+moaOFlJVq6H91IZ8ruUPLASRwDS10O6sRSiZ1I+ bH0AzVYM5RAMmRo9pym0eZPA7ILKxGNPiImtITJp3xid2Cq+t+tFDTIPSEar2dXfiYyu gf09AerkK8iIknReQ4x6i7QMvleI7MWejTsbN1GDgOQm+gCgT8fmmW1b6s81oLVwC/3h UNCgJVVxxbi9UCfBosydqmD06dw4APx+prDuUCVcM85YStebWSzifMrtcCJsRigkI86R ta6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785480347; x=1786085147; h=in-reply-to:content-disposition:content-type:mime-version :references:subject:cc:to:from:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MIbPeVG4258G9HKd8kCy72K/NwqK4KgRygqC+exQgG8=; b=cP2VVOsnFlC/zH6ChnBATJMeoCbomFBzvvJJPBzJxgmPsYahlIcRjBYP48aPjfcqbP 8/0HwN75k6ogv1Hvpi0IrQGrDCn760CUAAbQvSu18fehKqSehOS+QZAQez3kmfyvh2aH cBh2eOx2MCzFGQiLWZy65/WVKFQQLVmCemPMbuMbFVu5nUJ6y7t4+x5ovKgIlRyohGm+ xBWRHDIT5BMFJWYPtA4kWSww7KCJJYx9pd7RCqBx4gwzeW3dR8a+axCxc2LOGE3+zk6W ntLKd2PQohyYDO49dZlDxRB5wJVTy4nuBnim/QP1ezVEHcd0c2X01paSx4I29eO5s0tI LhxA== X-Forwarded-Encrypted: i=1; AHgh+Rp3FtBh55C2L/4doCaV8fd7HNyBe6c21Qs+JuqEOjHHiL4lZiMfJww0pPgKtLOENzVvx12Ms/MPVliYN9g=@vger.kernel.org X-Gm-Message-State: AOJu0YzhrnElQz9yVtmZtYI1KycJf9vmGsIeF20pdugkWOsCsgMk2bL2 V9x79Qiz8r+rFl+iJqxpOfIPezr/jQ7OJ34VuUPFBn/gZaLBz+NsfvNa X-Gm-Gg: AR+sD13eGRS9cTOEDmaZP+XK+O2scuZKkeeywqk4ksrKTY0ZecV8igXEdx/o0y7o4uE TMj1gu0/EjgeUL3qH1tFpJ0zZw+AP27t8ofEDkkC5fg5ZEVJtgpLEpNtGWy2s1TVvXY8L0aE4zb QvXWlETt+0NtatH5EdFoX7kEF5ksv37lIYN7MAQm+PKOwPIHtIRfrGYnerhT/+EVFvq4+le/8nY qerJavMlM2YALrl+9/CM6iE7nXxqNRsf0XAUgCNbWfwbMjbE4ebF1/XRG/zvQue/LCWnCnFuC+J MWeOT5xQLPQH5DcpwHZw7P2wGg/ltypgPqBV5dIzbLDjV+fdGnj4UOhs9ZX3D0w9bUZMz5jfJst CgUcQIfY1CRY+hN6gCixcuEDygUfcudKn3rXriBSqV1xTMRVTrepuy7cgYsF/cLhwm7PPyRY8MT VtGg5uxRrX1aT0kJ2xXUjXYookpZ7jnMZXAiBHyokYTDX6mAE0WLafuPp8DmCW2ZVSvOkNiqNif Md24Q5mCQ7zw5Lis2h/YsYCkdPXYmJ7jdxEr17AwRO0vHGY X-Received: by 2002:a17:907:ea8c:b0:c1c:3b06:ed1b with SMTP id a640c23a62f3a-c1fd23f9c06mr42429466b.22.1785480346401; Thu, 30 Jul 2026 23:45:46 -0700 (PDT) Received: from Ansuel-XPS. (host-87-11-254-126.retail.telecomitalia.it. [87.11.254.126]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fd3c5b0fasm33332166b.5.2026.07.30.23.45.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 23:45:45 -0700 (PDT) Message-ID: <6a6c4499.797cc74e.266cba.6533@mx.google.com> X-Google-Original-Message-ID: Date: Fri, 31 Jul 2026 08:45:40 +0200 From: Christian Marangi To: Krzysztof Kozlowski Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , Matthias Brugger , AngeloGioacchino Del Regno , Philipp Zabel , Cyril Chao , Kuninori Morimoto , Chen-Yu Tsai , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v3 1/4] ASoC: dt-bindings: Add Airoha AN7581 AFE Sound card. References: <20260528174840.28644-1-ansuelsmth@gmail.com> <20260528174840.28644-2-ansuelsmth@gmail.com> <20260531-spicy-sassy-woodlouse-b2674e@quoll> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260531-spicy-sassy-woodlouse-b2674e@quoll> On Sun, May 31, 2026 at 02:39:32PM +0200, Krzysztof Kozlowski wrote: > On Thu, May 28, 2026 at 07:48:29PM +0200, Christian Marangi wrote: > > Add YAML schema for Airoha AN7581 AFE SoC sound card. > > > > Nit: subject, drop final stop. > > > > Signed-off-by: Christian Marangi > > --- > > .../bindings/sound/airoha,an7581-afe.yaml | 41 +++++++++++++++++++ > > 1 file changed, 41 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/sound/airoha,an7581-afe.yaml > > > > diff --git a/Documentation/devicetree/bindings/sound/airoha,an7581-afe.yaml b/Documentation/devicetree/bindings/sound/airoha,an7581-afe.yaml > > new file mode 100644 > > index 000000000000..80d9e87f1470 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sound/airoha,an7581-afe.yaml > > @@ -0,0 +1,41 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/sound/airoha,an7581-afe.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Airoha AFE PCM controller for AN7581 > > + > > +maintainers: > > + - Christian Marangi > > + > > +properties: > > + compatible: > > + const: airoha,an7581-afe > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > This looks incomplete - missing at least clocks. Are you sure that AFE > here is so limited, comparing to other Mediatek designs? > Sorry for the late reply, I checked documentation and the SoC doesn't have a clock for AFE, Airoha reported that it's always enable from reset condition. The clock driver doesn't expose it. > -- Ansuel