From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f200.google.com (mail-oi1-f200.google.com [209.85.167.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F74B1A680E for ; Fri, 7 Aug 2026 13:46:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.200 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786110398; cv=none; b=a9Ew/+nMgfP1zPtnnNn07X6IWZ7pVlxb69Bjfjt6vKR/2iuQ03OOXMjQk5YVt2dODNUkItQh97IaIN0Q+YUnssev1xRF3tJu6WHpdvrHs49bpcVFYYh1FGhPDeHjlgPB3ef4NJ779e5VnS8sOqn6+vc6bvm+bFMdUxj0LDFIPVQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786110398; c=relaxed/simple; bh=t55O0B8jZfd6nk3k/IVI8OuTN9lehVN24SxCXYcnIas=; h=MIME-Version:Date:In-Reply-To:Message-ID:Subject:From:To: Content-Type; b=bGKal3f3W0vB1P0nYlo0VUa1Ixv1L9oe1/BzkQSF1Li/+hbLDiui8JhdSMKHFtefKfm3jVWC/F6gHc3OmAhczyeeOrAOUAYhunap3lUc+83T23xDVYvMzNrDNRO1EBOIjfmEOWR6rT21gB/Jq45dTAR9M1aSJv9E0HfUZ/IqgOI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; arc=none smtp.client-ip=209.85.167.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com Received: by mail-oi1-f200.google.com with SMTP id 5614622812f47-4afa222912eso1830359b6e.2 for ; Fri, 07 Aug 2026 06:46:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786110391; x=1786715191; h=content-type:to:from:subject:message-id:in-reply-to:date :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=p/8b4e9HeXbTv3yPq7Rip9dSaQXm7RuJKlWSQdtkR6E=; b=rYLyy/FdOpeP0Nh2jRhfc6Qdjfecss7N05SDE7YB8/ATAQ4Edfo1jN1g0C+ws1Ac+e L9n7wSlkPv5AC4/dqAMnRvMxzudv7KEBDLZOKKZLO9R6asPfrv/RAt8i4B7cqhPCtGvI MM6UpjGInrDC9GhJCJ6r5bnwnyqQpgECKvj7HZTU3zCeZEVLoexrQPhuqec3YP/ImeJs juudDOmqG3x/uc0H9xiwJeut8etgSZaFAFLuxU8NFt7TwyBC2biLma656IfjAmT9kI5y FnV+ImrvkwW3tK052M3fq/RvfU8D6m4JvFle0n9z3HaQqiKHh6gtZIKbC77Q5/M6GZ7i HUfw== X-Gm-Message-State: AOJu0Yy1x3FlZVBCFPADvb3hyXetGAKPrbMnT4YGzrlZv2QORIZlYdwh q+fWL0auKXz8gMLIIIvD5+VRyrDGCEA4JSbf/O0KE9f6BbAwiK9oS/nU2U+oDomUxx1/LuexWmv pCTRVCv9+QEpryLWFVlaXFX5pnaxWMGuKj1x/WtAuf4tHd60BLB+S9R3lRVc= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Received: by 2002:a05:6808:c2a7:b0:4af:88b7:94ab with SMTP id 5614622812f47-4b1ab7a8b07mr255491b6e.7.1786110391252; Fri, 07 Aug 2026 06:46:31 -0700 (PDT) Date: Fri, 07 Aug 2026 06:46:31 -0700 In-Reply-To: <6a74aa04.01d0871a.3a0d52.0025.GAE@google.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <6a75e1b7.01d0871a.3a0d52.0048.GAE@google.com> Subject: Forwarded: [PATCH] e100: prevent shift out-of-bounds in e100_eeprom_load From: syzbot To: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" For archival purposes, forwarding an incoming command email to linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com. *** Subject: [PATCH] e100: prevent shift out-of-bounds in e100_eeprom_load Author: pavankumaryalagada@gmail.com From: Yalagada Pavan Kumar When reading the EEPROM address length, e100_eeprom_read() can return an invalid length (0 or >= 16). Passing an invalid addr_len to bit-shift operations causes a shift out-of-bounds, triggering a kernel panic or UBSAN warning. Validate addr_len after reading it from EEPROM and return -EINVAL if the value is out of bounds. Additionally, use 1U to prevent signed integer overflow when calculating eeprom_wc. Reported-by: syzbot+e0abb1d45ac291ebebeb@syzkaller.appspotmail.com Link: https://syzkaller.appspot.com/bug?extid=e0abb1d45ac291ebebeb Signed-off-by: Yalagada Pavan Kumar #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master --- Tested using syzbot c reproducer. #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master --- drivers/net/ethernet/intel/e100.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c index 29960762e64a..1de5cd41ea0c 100644 --- a/drivers/net/ethernet/intel/e100.c +++ b/drivers/net/ethernet/intel/e100.c @@ -744,7 +744,12 @@ static __le16 e100_eeprom_read(struct nic *nic, u16 *addr_len, u16 addr) * complete address. Use this to adjust addr_len. */ ctrl = ioread8(&nic->csr->eeprom_ctrl_lo); if (!(ctrl & eedo) && i > 16) { - *addr_len -= (i - 16); + u16 len = i - 16; + + if (len > *addr_len) + *addr_len = 0; + else + *addr_len -= len; i = 17; } @@ -765,7 +770,15 @@ static int e100_eeprom_load(struct nic *nic) /* Try reading with an 8-bit addr len to discover actual addr len */ e100_eeprom_read(nic, &addr_len, 0); - nic->eeprom_wc = 1 << addr_len; + + if (!addr_len || addr_len >= 16) { + netif_err(nic, probe, nic->netdev, + "Invalid EEPROM address length %u\n", + addr_len); + return -EINVAL; + } + + nic->eeprom_wc = 1U << addr_len; for (addr = 0; addr < nic->eeprom_wc; addr++) { nic->eeprom[addr] = e100_eeprom_read(nic, &addr_len, addr); -- 2.43.0