Re: [syzbot] [usb?] memory leak in gadget_bind (2)

[syzbot <syzbot+d83b3c49738aea97c0e5@syzkaller.appspotmail.com>]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
memory leak in device_set_deferred_probe_reason

BUG: memory leak
unreferenced object 0xffff888127cacec0 (size 64):
  comm "syz.0.66", pid 7033, jiffies 4294952202
  hex dump (first 32 bytes):
    67 61 64 67 65 74 3a 20 44 65 76 69 63 65 20 6e  gadget: Device n
    6f 74 20 72 65 61 64 79 20 74 6f 20 70 72 6f 62  ot ready to prob
  backtrace (crc 2d586e63):
    kmemleak_alloc_recursive include/linux/kmemleak.h:44 [inline]
    slab_post_alloc_hook mm/slub.c:4597 [inline]
    slab_alloc_node mm/slub.c:4917 [inline]
    __do_kmalloc_node mm/slub.c:5333 [inline]
    __kmalloc_node_track_caller_noprof+0x3d3/0x570 mm/slub.c:5471
    kvasprintf+0x6e/0xf0 lib/kasprintf.c:25
    kasprintf+0x6b/0x90 lib/kasprintf.c:59
    device_set_deferred_probe_reason+0x41/0x70 drivers/base/dd.c:235
    __dev_probe_failed+0xae/0xc0 drivers/base/core.c:5092
    dev_err_probe+0x73/0xa0 drivers/base/core.c:5152
    __driver_probe_device+0x185/0x1a0 drivers/base/dd.c:846
    driver_probe_device+0x28/0xf0 drivers/base/dd.c:898
    __driver_attach drivers/base/dd.c:1292 [inline]
    __driver_attach+0x10a/0x200 drivers/base/dd.c:1232
    bus_for_each_dev+0xb8/0x120 drivers/base/bus.c:383
    bus_add_driver+0x122/0x280 drivers/base/bus.c:763
    driver_register+0xb1/0x140 drivers/base/driver.c:174
    usb_gadget_register_driver_owner+0x69/0xe0 drivers/usb/gadget/udc/core.c:1752
    raw_ioctl_run drivers/usb/gadget/legacy/raw_gadget.c:600 [inline]
    raw_ioctl+0xad7/0x10c0 drivers/usb/gadget/legacy/raw_gadget.c:1311
    vfs_ioctl fs/ioctl.c:51 [inline]
    __do_sys_ioctl fs/ioctl.c:597 [inline]
    __se_sys_ioctl fs/ioctl.c:583 [inline]
    __x64_sys_ioctl+0xf4/0x140 fs/ioctl.c:583
    do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
    do_syscall_64+0xf8/0x610 arch/x86/entry/syscall_64.c:94

connection error: failed to recv *flatrpc.ExecutorMessageRawT: EOF


Tested on:

commit:         2f1baf1f Merge tag 'trace-v7.2-rc7' of git://git.kerne..
git tree:       https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
console output: https://syzkaller.appspot.com/x/log.txt?x=1797fac6580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=6843f8fd2336602d
dashboard link: https://syzkaller.appspot.com/bug?extid=d83b3c49738aea97c0e5
compiler:       gcc (Debian 14.2.0-19) 14.2.0, GNU ld (GNU Binutils for Debian) 2.44
patch:          https://syzkaller.appspot.com/x/patch.diff?x=13a08279580000