Re: [syzbot] [dri?] WARNING in drm_mm_takedown

[syzbot <syzbot+d93b9064fe5f74af3aa3@syzkaller.appspotmail.com>]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
WARNING in drm_mm_takedown

Console: switching to colour dummy device 80x25
------------[ cut here ]------------
Memory manager not clean during takedown.
WARNING: drivers/gpu/drm/drm_mm.c:965 at drm_mm_takedown+0x62/0x280 drivers/gpu/drm/drm_mm.c:965, CPU#1: syz.0.22/6271
Modules linked in:
CPU: 1 UID: 0 PID: 6271 Comm: syz.0.22 Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2 04/01/2014
RIP: 0010:drm_mm_takedown+0x62/0x280 drivers/gpu/drm/drm_mm.c:965
Code: 8b 43 38 48 39 c5 75 16 e8 eb 42 45 fc 48 83 c4 08 5b 5d 41 5c 41 5d 41 5e c3 cc cc cc cc e8 d5 42 45 fc 48 8d 3d 0e 72 68 0b <67> 48 0f b9 3a 48 c7 c0 e0 c3 46 8e 48 ba 00 00 00 00 00 fc ff df
RSP: 0018:ffffc9000607f790 EFLAGS: 00010293
RAX: 0000000000000000 RBX: ffff88804754e868 RCX: ffffffff85c4f8ab
RDX: ffff888025482540 RSI: ffffffff85c50d6b RDI: ffffffff912d7f80
RBP: ffff88804754e8a0 R08: 0000000000000007 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000000 R12: ffff88803d419400
R13: ffff88803d419418 R14: ffffffff85c3ea70 R15: 0000000000000000
FS:  00007f803fef06c0(0000) GS:ffff8880d5ef1000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f803feceff8 CR3: 000000003e66d000 CR4: 0000000000352ef0
Call Trace:
 <TASK>
 drm_managed_release+0x1bb/0x540 drivers/gpu/drm/drm_managed.c:75
 drm_dev_release drivers/gpu/drm/drm_drv.c:914 [inline]
 kref_put include/linux/kref.h:65 [inline]
 drm_dev_put.part.0+0xca/0x140 drivers/gpu/drm/drm_drv.c:948
 drm_dev_put+0x1f/0x30 drivers/gpu/drm/drm_drv.c:947
 virtio_dev_remove+0xb8/0x170 drivers/virtio/virtio.c:375
 device_remove+0xcb/0x180 drivers/base/dd.c:616
 __device_release_driver drivers/base/dd.c:1349 [inline]
 device_release_driver_internal+0x44e/0x620 drivers/base/dd.c:1372
 bus_remove_device+0x2bc/0x560 drivers/base/bus.c:664
 device_del+0x376/0x9b0 drivers/base/core.c:3961
 device_unregister+0x1d/0xe0 drivers/base/core.c:4002
 unregister_virtio_device+0x39/0x60 drivers/virtio/virtio.c:594
 virtio_pci_remove+0x7c/0x110 drivers/virtio/virtio_pci_common.c:758
 pci_device_remove+0xb2/0x1d0 drivers/pci/pci-driver.c:512
 device_remove+0xcb/0x180 drivers/base/dd.c:616
 __device_release_driver drivers/base/dd.c:1349 [inline]
 device_release_driver_internal+0x44e/0x620 drivers/base/dd.c:1372
 pci_stop_dev drivers/pci/remove.c:27 [inline]
 pci_stop_bus_device+0x120/0x160 drivers/pci/remove.c:93
 pci_stop_and_remove_bus_device+0x58/0xa0 drivers/pci/remove.c:128
 pci_stop_and_remove_bus_device_locked+0x1a/0x20 drivers/pci/remove.c:136
 remove_store+0x123/0x140 drivers/pci/pci-sysfs.c:523
 dev_attr_store+0x58/0x80 drivers/base/core.c:2505
 sysfs_kf_write+0xf2/0x150 fs/sysfs/file.c:145
 kernfs_fop_write_iter+0x3e0/0x5f0 fs/kernfs/file.c:345
 new_sync_write fs/read_write.c:595 [inline]
 vfs_write+0x6ac/0x1050 fs/read_write.c:687
 ksys_write+0x12a/0x250 fs/read_write.c:739
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0x115/0x870 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f803ef9e0d9
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f803fef0028 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007f803f225fa0 RCX: 00007f803ef9e0d9
RDX: 0000000000000001 RSI: 00002000000000c0 RDI: 0000000000000003
RBP: 00007f803f035024 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f803f226038 R14: 00007f803f225fa0 R15: 00007fffd7f01f68
 </TASK>
----------------
Code disassembly (best guess):
   0:	8b 43 38             	mov    0x38(%rbx),%eax
   3:	48 39 c5             	cmp    %rax,%rbp
   6:	75 16                	jne    0x1e
   8:	e8 eb 42 45 fc       	call   0xfc4542f8
   d:	48 83 c4 08          	add    $0x8,%rsp
  11:	5b                   	pop    %rbx
  12:	5d                   	pop    %rbp
  13:	41 5c                	pop    %r12
  15:	41 5d                	pop    %r13
  17:	41 5e                	pop    %r14
  19:	c3                   	ret
  1a:	cc                   	int3
  1b:	cc                   	int3
  1c:	cc                   	int3
  1d:	cc                   	int3
  1e:	e8 d5 42 45 fc       	call   0xfc4542f8
  23:	48 8d 3d 0e 72 68 0b 	lea    0xb68720e(%rip),%rdi        # 0xb687238
* 2a:	67 48 0f b9 3a       	ud1    (%edx),%rdi <-- trapping instruction
  2f:	48 c7 c0 e0 c3 46 8e 	mov    $0xffffffff8e46c3e0,%rax
  36:	48 ba 00 00 00 00 00 	movabs $0xdffffc0000000000,%rdx
  3d:	fc ff df


Tested on:

commit:         93427272 drm/virtio: fix host-visible blob cleanup on ..
git tree:       https://github.com/yutao-intel/linux.git fix-dri-virtio-align-HEAD
console output: https://syzkaller.appspot.com/x/log.txt?x=12ffc979580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=acc0a882b963ae23
dashboard link: https://syzkaller.appspot.com/bug?extid=d93b9064fe5f74af3aa3
compiler:       gcc (Debian 14.2.0-19) 14.2.0, GNU ld (GNU Binutils for Debian) 2.44

Note: no patches were applied.