From: Florian Eckert <fe@dev.tdt.de>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Eckert.Florian@googlemail.com, rafael@kernel.org,
rui.zhang@intel.com, lukasz.luba@arm.com,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/thermal/tmon: Fix compilation warning for wrong format
Date: Wed, 20 Dec 2023 08:30:54 +0100 [thread overview]
Message-ID: <6a9f55419ee05ba44ef40430e7a16ac4@dev.tdt.de> (raw)
In-Reply-To: <6dbed9d3-abfe-476c-a771-10a5e70bb87c@linaro.org>
On 2023-12-19 19:12, Daniel Lezcano wrote:
> On 04/12/2023 15:13, Florian Eckert wrote:
>> The following warnings are shown during compilation:
>>
>> tui.c: In function 'show_cooling_device':
>> tui.c:216:40: warning: format '%d' expects argument of type 'int',
>> but
>> argument 7 has type 'long unsigned int' [-Wformat=]
>> 216 | "%02d %12.12s%6d %6d",
>> | ~~^
>> | |
>> | int
>> | %6ld
>> ......
>> 219 | ptdata.cdi[j].cur_state,
>> | ~~~~~~~~~~~~~~~~~~~~~~~
>> | |
>> | long unsigned int
>> tui.c:216:44: warning: format '%d' expects argument of type 'int',
>> but
>> argument 8 has type 'long unsigned int' [-Wformat=]
>> 216 | "%02d %12.12s%6d %6d",
>> | ~~^
>> | |
>> | int
>> | %6ld
>> ......
>> 220 | ptdata.cdi[j].max_state);
>> | ~~~~~~~~~~~~~~~~~~~~~~~
>> | |
>> | long unsigned int
>>
>> To fix this, the correct string format must be used for printing.
>>
>> Signed-off-by: Florian Eckert <fe@dev.tdt.de>
>> ---
>
> Applied, thanks
Thanks :+1:
prev parent reply other threads:[~2023-12-20 7:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 14:13 [PATCH] tools/thermal/tmon: Fix compilation warning for wrong format Florian Eckert
2023-12-19 18:12 ` Daniel Lezcano
2023-12-20 7:30 ` Florian Eckert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a9f55419ee05ba44ef40430e7a16ac4@dev.tdt.de \
--to=fe@dev.tdt.de \
--cc=Eckert.Florian@googlemail.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox