* [PATCH 2/2] drm/tests: Fix drm_test_fb_xrgb8888_to_xrgb2101010() on big-endian
2025-06-30 9:00 [PATCH 1/2] drm/tests: Fix endian warning José Expósito
@ 2025-06-30 9:00 ` José Expósito
2025-06-30 11:37 ` Thomas Zimmermann
2025-06-30 11:37 ` [PATCH 1/2] drm/tests: Fix endian warning Thomas Zimmermann
2025-07-01 8:22 ` Michel Dänzer
2 siblings, 1 reply; 10+ messages in thread
From: José Expósito @ 2025-06-30 9:00 UTC (permalink / raw)
To: maarten.lankhorst
Cc: mripard, tzimmermann, airlied, simona, lumag, cristian.ciocaltea,
gcarlos, dri-devel, linux-kernel, José Expósito
Fix failures on big-endian architectures on tests cases
single_pixel_source_buffer, single_pixel_clip_rectangle,
well_known_colors and destination_pitch.
Fixes: 15bda1f8de5d ("drm/tests: Add calls to drm_fb_blit() on supported format conversion tests")
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
---
drivers/gpu/drm/tests/drm_format_helper_test.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/tests/drm_format_helper_test.c b/drivers/gpu/drm/tests/drm_format_helper_test.c
index 86829e1cb7f0..981dada8f3a8 100644
--- a/drivers/gpu/drm/tests/drm_format_helper_test.c
+++ b/drivers/gpu/drm/tests/drm_format_helper_test.c
@@ -1040,6 +1040,7 @@ static void drm_test_fb_xrgb8888_to_xrgb2101010(struct kunit *test)
memset(buf, 0, dst_size);
drm_fb_xrgb8888_to_xrgb2101010(&dst, dst_pitch, &src, &fb, ¶ms->clip, &fmtcnv_state);
+ buf = le32buf_to_cpu(test, (__force const __le32 *)buf, dst_size / sizeof(u32));
KUNIT_EXPECT_MEMEQ(test, buf, result->expected, dst_size);
}
--
2.50.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 2/2] drm/tests: Fix drm_test_fb_xrgb8888_to_xrgb2101010() on big-endian
2025-06-30 9:00 ` [PATCH 2/2] drm/tests: Fix drm_test_fb_xrgb8888_to_xrgb2101010() on big-endian José Expósito
@ 2025-06-30 11:37 ` Thomas Zimmermann
2025-08-11 10:24 ` José Expósito
0 siblings, 1 reply; 10+ messages in thread
From: Thomas Zimmermann @ 2025-06-30 11:37 UTC (permalink / raw)
To: José Expósito, maarten.lankhorst
Cc: mripard, airlied, simona, lumag, cristian.ciocaltea, gcarlos,
dri-devel, linux-kernel
Am 30.06.25 um 11:00 schrieb José Expósito:
> Fix failures on big-endian architectures on tests cases
> single_pixel_source_buffer, single_pixel_clip_rectangle,
> well_known_colors and destination_pitch.
>
> Fixes: 15bda1f8de5d ("drm/tests: Add calls to drm_fb_blit() on supported format conversion tests")
> Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/tests/drm_format_helper_test.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/tests/drm_format_helper_test.c b/drivers/gpu/drm/tests/drm_format_helper_test.c
> index 86829e1cb7f0..981dada8f3a8 100644
> --- a/drivers/gpu/drm/tests/drm_format_helper_test.c
> +++ b/drivers/gpu/drm/tests/drm_format_helper_test.c
> @@ -1040,6 +1040,7 @@ static void drm_test_fb_xrgb8888_to_xrgb2101010(struct kunit *test)
> memset(buf, 0, dst_size);
>
> drm_fb_xrgb8888_to_xrgb2101010(&dst, dst_pitch, &src, &fb, ¶ms->clip, &fmtcnv_state);
> + buf = le32buf_to_cpu(test, (__force const __le32 *)buf, dst_size / sizeof(u32));
> KUNIT_EXPECT_MEMEQ(test, buf, result->expected, dst_size);
> }
>
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 2/2] drm/tests: Fix drm_test_fb_xrgb8888_to_xrgb2101010() on big-endian
2025-06-30 11:37 ` Thomas Zimmermann
@ 2025-08-11 10:24 ` José Expósito
2025-08-11 15:28 ` Thomas Zimmermann
0 siblings, 1 reply; 10+ messages in thread
From: José Expósito @ 2025-08-11 10:24 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: maarten.lankhorst, mripard, airlied, simona, lumag,
cristian.ciocaltea, gcarlos, dri-devel, linux-kernel
Hi Thomas,
On Mon, Jun 30, 2025 at 01:37:58PM +0200, Thomas Zimmermann wrote:
>
>
> Am 30.06.25 um 11:00 schrieb José Expósito:
> > Fix failures on big-endian architectures on tests cases
> > single_pixel_source_buffer, single_pixel_clip_rectangle,
> > well_known_colors and destination_pitch.
> >
> > Fixes: 15bda1f8de5d ("drm/tests: Add calls to drm_fb_blit() on supported format conversion tests")
> > Signed-off-by: José Expósito <jose.exposito89@gmail.com>
>
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Just a friendly reminder about this patches. Can I merge them?
They have been in the ML for a while and it doesn't look like
there are concerns.
Best wishes,
Jose
> > ---
> > drivers/gpu/drm/tests/drm_format_helper_test.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/tests/drm_format_helper_test.c b/drivers/gpu/drm/tests/drm_format_helper_test.c
> > index 86829e1cb7f0..981dada8f3a8 100644
> > --- a/drivers/gpu/drm/tests/drm_format_helper_test.c
> > +++ b/drivers/gpu/drm/tests/drm_format_helper_test.c
> > @@ -1040,6 +1040,7 @@ static void drm_test_fb_xrgb8888_to_xrgb2101010(struct kunit *test)
> > memset(buf, 0, dst_size);
> > drm_fb_xrgb8888_to_xrgb2101010(&dst, dst_pitch, &src, &fb, ¶ms->clip, &fmtcnv_state);
> > + buf = le32buf_to_cpu(test, (__force const __le32 *)buf, dst_size / sizeof(u32));
> > KUNIT_EXPECT_MEMEQ(test, buf, result->expected, dst_size);
> > }
>
> --
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Frankenstrasse 146, 90461 Nuernberg, Germany
> GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
> HRB 36809 (AG Nuernberg)
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 2/2] drm/tests: Fix drm_test_fb_xrgb8888_to_xrgb2101010() on big-endian
2025-08-11 10:24 ` José Expósito
@ 2025-08-11 15:28 ` Thomas Zimmermann
0 siblings, 0 replies; 10+ messages in thread
From: Thomas Zimmermann @ 2025-08-11 15:28 UTC (permalink / raw)
To: José Expósito
Cc: maarten.lankhorst, mripard, airlied, simona, lumag,
cristian.ciocaltea, gcarlos, dri-devel, linux-kernel
Hi
Am 11.08.25 um 12:24 schrieb José Expósito:
> Hi Thomas,
>
> On Mon, Jun 30, 2025 at 01:37:58PM +0200, Thomas Zimmermann wrote:
>>
>> Am 30.06.25 um 11:00 schrieb José Expósito:
>>> Fix failures on big-endian architectures on tests cases
>>> single_pixel_source_buffer, single_pixel_clip_rectangle,
>>> well_known_colors and destination_pitch.
>>>
>>> Fixes: 15bda1f8de5d ("drm/tests: Add calls to drm_fb_blit() on supported format conversion tests")
>>> Signed-off-by: José Expósito <jose.exposito89@gmail.com>
>> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> Just a friendly reminder about this patches. Can I merge them?
> They have been in the ML for a while and it doesn't look like
> there are concerns.
Merged into drm-misc-fixes now. Sorry for the delay.
Best regards
Thomas
>
> Best wishes,
> Jose
>
>>> ---
>>> drivers/gpu/drm/tests/drm_format_helper_test.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/gpu/drm/tests/drm_format_helper_test.c b/drivers/gpu/drm/tests/drm_format_helper_test.c
>>> index 86829e1cb7f0..981dada8f3a8 100644
>>> --- a/drivers/gpu/drm/tests/drm_format_helper_test.c
>>> +++ b/drivers/gpu/drm/tests/drm_format_helper_test.c
>>> @@ -1040,6 +1040,7 @@ static void drm_test_fb_xrgb8888_to_xrgb2101010(struct kunit *test)
>>> memset(buf, 0, dst_size);
>>> drm_fb_xrgb8888_to_xrgb2101010(&dst, dst_pitch, &src, &fb, ¶ms->clip, &fmtcnv_state);
>>> + buf = le32buf_to_cpu(test, (__force const __le32 *)buf, dst_size / sizeof(u32));
>>> KUNIT_EXPECT_MEMEQ(test, buf, result->expected, dst_size);
>>> }
>> --
>> --
>> Thomas Zimmermann
>> Graphics Driver Developer
>> SUSE Software Solutions Germany GmbH
>> Frankenstrasse 146, 90461 Nuernberg, Germany
>> GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
>> HRB 36809 (AG Nuernberg)
>>
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] drm/tests: Fix endian warning
2025-06-30 9:00 [PATCH 1/2] drm/tests: Fix endian warning José Expósito
2025-06-30 9:00 ` [PATCH 2/2] drm/tests: Fix drm_test_fb_xrgb8888_to_xrgb2101010() on big-endian José Expósito
@ 2025-06-30 11:37 ` Thomas Zimmermann
2025-07-01 8:22 ` Michel Dänzer
2 siblings, 0 replies; 10+ messages in thread
From: Thomas Zimmermann @ 2025-06-30 11:37 UTC (permalink / raw)
To: José Expósito, maarten.lankhorst
Cc: mripard, airlied, simona, lumag, cristian.ciocaltea, gcarlos,
dri-devel, linux-kernel
Am 30.06.25 um 11:00 schrieb José Expósito:
> When compiling with sparse enabled, this warning is thrown:
>
> warning: incorrect type in argument 2 (different base types)
> expected restricted __le32 const [usertype] *buf
> got unsigned int [usertype] *[assigned] buf
>
> Add a cast to fix it.
>
> Fixes: 453114319699 ("drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_xrgb2101010()")
> Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/tests/drm_format_helper_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tests/drm_format_helper_test.c b/drivers/gpu/drm/tests/drm_format_helper_test.c
> index 7299fa8971ce..86829e1cb7f0 100644
> --- a/drivers/gpu/drm/tests/drm_format_helper_test.c
> +++ b/drivers/gpu/drm/tests/drm_format_helper_test.c
> @@ -1033,7 +1033,7 @@ static void drm_test_fb_xrgb8888_to_xrgb2101010(struct kunit *test)
> NULL : &result->dst_pitch;
>
> drm_fb_xrgb8888_to_xrgb2101010(&dst, dst_pitch, &src, &fb, ¶ms->clip, &fmtcnv_state);
> - buf = le32buf_to_cpu(test, buf, dst_size / sizeof(u32));
> + buf = le32buf_to_cpu(test, (__force const __le32 *)buf, dst_size / sizeof(u32));
> KUNIT_EXPECT_MEMEQ(test, buf, result->expected, dst_size);
>
> buf = dst.vaddr; /* restore original value of buf */
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 1/2] drm/tests: Fix endian warning
2025-06-30 9:00 [PATCH 1/2] drm/tests: Fix endian warning José Expósito
2025-06-30 9:00 ` [PATCH 2/2] drm/tests: Fix drm_test_fb_xrgb8888_to_xrgb2101010() on big-endian José Expósito
2025-06-30 11:37 ` [PATCH 1/2] drm/tests: Fix endian warning Thomas Zimmermann
@ 2025-07-01 8:22 ` Michel Dänzer
2025-07-01 16:45 ` José Expósito
2 siblings, 1 reply; 10+ messages in thread
From: Michel Dänzer @ 2025-07-01 8:22 UTC (permalink / raw)
To: José Expósito, maarten.lankhorst
Cc: mripard, tzimmermann, airlied, simona, lumag, cristian.ciocaltea,
gcarlos, dri-devel, linux-kernel
On 30.06.25 11:00, José Expósito wrote:
> When compiling with sparse enabled, this warning is thrown:
>
> warning: incorrect type in argument 2 (different base types)
> expected restricted __le32 const [usertype] *buf
> got unsigned int [usertype] *[assigned] buf
>
> Add a cast to fix it.
>
> Fixes: 453114319699 ("drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_xrgb2101010()")
> Signed-off-by: José Expósito <jose.exposito89@gmail.com>
> ---
> drivers/gpu/drm/tests/drm_format_helper_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tests/drm_format_helper_test.c b/drivers/gpu/drm/tests/drm_format_helper_test.c
> index 7299fa8971ce..86829e1cb7f0 100644
> --- a/drivers/gpu/drm/tests/drm_format_helper_test.c
> +++ b/drivers/gpu/drm/tests/drm_format_helper_test.c
> @@ -1033,7 +1033,7 @@ static void drm_test_fb_xrgb8888_to_xrgb2101010(struct kunit *test)
> NULL : &result->dst_pitch;
>
> drm_fb_xrgb8888_to_xrgb2101010(&dst, dst_pitch, &src, &fb, ¶ms->clip, &fmtcnv_state);
> - buf = le32buf_to_cpu(test, buf, dst_size / sizeof(u32));
> + buf = le32buf_to_cpu(test, (__force const __le32 *)buf, dst_size / sizeof(u32));
> KUNIT_EXPECT_MEMEQ(test, buf, result->expected, dst_size);
>
> buf = dst.vaddr; /* restore original value of buf */
It might be cleaner to use two separate variables instead of using "buf" as both little endian and host byte order. (Same for patch 2)
--
Earthling Michel Dänzer \ GNOME / Xwayland / Mesa developer
https://redhat.com \ Libre software enthusiast
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 1/2] drm/tests: Fix endian warning
2025-07-01 8:22 ` Michel Dänzer
@ 2025-07-01 16:45 ` José Expósito
2025-07-01 17:19 ` Michel Dänzer
2025-07-02 8:12 ` Thomas Zimmermann
0 siblings, 2 replies; 10+ messages in thread
From: José Expósito @ 2025-07-01 16:45 UTC (permalink / raw)
To: Michel Dänzer
Cc: maarten.lankhorst, mripard, tzimmermann, airlied, simona, lumag,
cristian.ciocaltea, gcarlos, dri-devel, linux-kernel
Hey Michel,
Thanks for looking into this.
On Tue, Jul 01, 2025 at 10:22:13AM +0200, Michel Dänzer wrote:
> On 30.06.25 11:00, José Expósito wrote:
> > When compiling with sparse enabled, this warning is thrown:
> >
> > warning: incorrect type in argument 2 (different base types)
> > expected restricted __le32 const [usertype] *buf
> > got unsigned int [usertype] *[assigned] buf
> >
> > Add a cast to fix it.
> >
> > Fixes: 453114319699 ("drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_xrgb2101010()")
> > Signed-off-by: José Expósito <jose.exposito89@gmail.com>
> > ---
> > drivers/gpu/drm/tests/drm_format_helper_test.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/tests/drm_format_helper_test.c b/drivers/gpu/drm/tests/drm_format_helper_test.c
> > index 7299fa8971ce..86829e1cb7f0 100644
> > --- a/drivers/gpu/drm/tests/drm_format_helper_test.c
> > +++ b/drivers/gpu/drm/tests/drm_format_helper_test.c
> > @@ -1033,7 +1033,7 @@ static void drm_test_fb_xrgb8888_to_xrgb2101010(struct kunit *test)
> > NULL : &result->dst_pitch;
> >
> > drm_fb_xrgb8888_to_xrgb2101010(&dst, dst_pitch, &src, &fb, ¶ms->clip, &fmtcnv_state);
> > - buf = le32buf_to_cpu(test, buf, dst_size / sizeof(u32));
> > + buf = le32buf_to_cpu(test, (__force const __le32 *)buf, dst_size / sizeof(u32));
> > KUNIT_EXPECT_MEMEQ(test, buf, result->expected, dst_size);
> >
> > buf = dst.vaddr; /* restore original value of buf */
>
> It might be cleaner to use two separate variables instead of using "buf" as both little endian and host byte order. (Same for patch 2)
Yes, however, the same pattern is repeated 10 times in this file.
What do you think about fixing it in a follow up? I don't think it
should block fixing the KUnit tests.
Jose
>
> --
> Earthling Michel Dänzer \ GNOME / Xwayland / Mesa developer
> https://redhat.com \ Libre software enthusiast
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 1/2] drm/tests: Fix endian warning
2025-07-01 16:45 ` José Expósito
@ 2025-07-01 17:19 ` Michel Dänzer
2025-07-02 8:12 ` Thomas Zimmermann
1 sibling, 0 replies; 10+ messages in thread
From: Michel Dänzer @ 2025-07-01 17:19 UTC (permalink / raw)
To: José Expósito
Cc: maarten.lankhorst, mripard, tzimmermann, airlied, simona, lumag,
cristian.ciocaltea, gcarlos, dri-devel, linux-kernel
On 01.07.25 18:45, José Expósito wrote:
> Hey Michel,
>
> Thanks for looking into this.
>
> On Tue, Jul 01, 2025 at 10:22:13AM +0200, Michel Dänzer wrote:
>> On 30.06.25 11:00, José Expósito wrote:
>>> When compiling with sparse enabled, this warning is thrown:
>>>
>>> warning: incorrect type in argument 2 (different base types)
>>> expected restricted __le32 const [usertype] *buf
>>> got unsigned int [usertype] *[assigned] buf
>>>
>>> Add a cast to fix it.
>>>
>>> Fixes: 453114319699 ("drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_xrgb2101010()")
>>> Signed-off-by: José Expósito <jose.exposito89@gmail.com>
>>> ---
>>> drivers/gpu/drm/tests/drm_format_helper_test.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/tests/drm_format_helper_test.c b/drivers/gpu/drm/tests/drm_format_helper_test.c
>>> index 7299fa8971ce..86829e1cb7f0 100644
>>> --- a/drivers/gpu/drm/tests/drm_format_helper_test.c
>>> +++ b/drivers/gpu/drm/tests/drm_format_helper_test.c
>>> @@ -1033,7 +1033,7 @@ static void drm_test_fb_xrgb8888_to_xrgb2101010(struct kunit *test)
>>> NULL : &result->dst_pitch;
>>>
>>> drm_fb_xrgb8888_to_xrgb2101010(&dst, dst_pitch, &src, &fb, ¶ms->clip, &fmtcnv_state);
>>> - buf = le32buf_to_cpu(test, buf, dst_size / sizeof(u32));
>>> + buf = le32buf_to_cpu(test, (__force const __le32 *)buf, dst_size / sizeof(u32));
>>> KUNIT_EXPECT_MEMEQ(test, buf, result->expected, dst_size);
>>>
>>> buf = dst.vaddr; /* restore original value of buf */
>>
>> It might be cleaner to use two separate variables instead of using "buf" as both little endian and host byte order. (Same for patch 2)
>
> Yes, however, the same pattern is repeated 10 times in this file.
>
> What do you think about fixing it in a follow up? I don't think it
> should block fixing the KUnit tests.
Ah, yes, makes sense to do it separately then.
--
Earthling Michel Dänzer \ GNOME / Xwayland / Mesa developer
https://redhat.com \ Libre software enthusiast
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 1/2] drm/tests: Fix endian warning
2025-07-01 16:45 ` José Expósito
2025-07-01 17:19 ` Michel Dänzer
@ 2025-07-02 8:12 ` Thomas Zimmermann
1 sibling, 0 replies; 10+ messages in thread
From: Thomas Zimmermann @ 2025-07-02 8:12 UTC (permalink / raw)
To: José Expósito, Michel Dänzer
Cc: maarten.lankhorst, mripard, airlied, simona, lumag,
cristian.ciocaltea, gcarlos, dri-devel, linux-kernel
Hi
Am 01.07.25 um 18:45 schrieb José Expósito:
> Hey Michel,
>
> Thanks for looking into this.
>
> On Tue, Jul 01, 2025 at 10:22:13AM +0200, Michel Dänzer wrote:
>> On 30.06.25 11:00, José Expósito wrote:
>>> When compiling with sparse enabled, this warning is thrown:
>>>
>>> warning: incorrect type in argument 2 (different base types)
>>> expected restricted __le32 const [usertype] *buf
>>> got unsigned int [usertype] *[assigned] buf
>>>
>>> Add a cast to fix it.
>>>
>>> Fixes: 453114319699 ("drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_xrgb2101010()")
>>> Signed-off-by: José Expósito <jose.exposito89@gmail.com>
>>> ---
>>> drivers/gpu/drm/tests/drm_format_helper_test.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/tests/drm_format_helper_test.c b/drivers/gpu/drm/tests/drm_format_helper_test.c
>>> index 7299fa8971ce..86829e1cb7f0 100644
>>> --- a/drivers/gpu/drm/tests/drm_format_helper_test.c
>>> +++ b/drivers/gpu/drm/tests/drm_format_helper_test.c
>>> @@ -1033,7 +1033,7 @@ static void drm_test_fb_xrgb8888_to_xrgb2101010(struct kunit *test)
>>> NULL : &result->dst_pitch;
>>>
>>> drm_fb_xrgb8888_to_xrgb2101010(&dst, dst_pitch, &src, &fb, ¶ms->clip, &fmtcnv_state);
>>> - buf = le32buf_to_cpu(test, buf, dst_size / sizeof(u32));
>>> + buf = le32buf_to_cpu(test, (__force const __le32 *)buf, dst_size / sizeof(u32));
>>> KUNIT_EXPECT_MEMEQ(test, buf, result->expected, dst_size);
>>>
>>> buf = dst.vaddr; /* restore original value of buf */
>> It might be cleaner to use two separate variables instead of using "buf" as both little endian and host byte order. (Same for patch 2)
> Yes, however, the same pattern is repeated 10 times in this file.
>
> What do you think about fixing it in a follow up? I don't think it
> should block fixing the KUnit tests.
Before doing this, you should consider storing the test data in
little-endian. That would save all the endianess conversion in the code.
Best regards
Thomas
>
> Jose
>
>> --
>> Earthling Michel Dänzer \ GNOME / Xwayland / Mesa developer
>> https://redhat.com \ Libre software enthusiast
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
^ permalink raw reply [flat|nested] 10+ messages in thread