From: Gavin Shan <gshan@redhat.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>, linux-kernel@vger.kernel.org
Cc: will@kernel.org, catalin.marinas@arm.com, maz@kernel.org,
steven.price@arm.com, aneesh.kumar@kernel.org,
robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH v3 1/3] dma: Fix encryption bit clearing for dma_to_phys
Date: Fri, 28 Feb 2025 12:08:47 +1000 [thread overview]
Message-ID: <6ae2b809-7cc6-471b-9065-be446411570b@redhat.com> (raw)
In-Reply-To: <20250227144150.1667735-2-suzuki.poulose@arm.com>
On 2/28/25 12:41 AM, Suzuki K Poulose wrote:
> phys_to_dma() sets the encryption bit on the translated DMA address. But
> dma_to_phys() clears the encryption bit after it has been translated back
> to the physical address, which could fail if the device uses DMA ranges.
>
> AMD SME doesn't use the DMA ranges and thus this is harmless. But as we
> are about to add support for other architectures, let us fix this.
>
> Reported-by: Aneesh Kumar K.V <aneesh.kumar@kernel.org>
> Link: https://lkml.kernel.org/r/yq5amsen9stc.fsf@kernel.org
> Cc: Will Deacon <will@kernel.org>
> Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Robin Murphy <robin.murphy@arm.com>
> Cc: Steven Price <steven.price@arm.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Reviewed-by: Robin Murphy <robin.murphy@arm.com>
> Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> ---
> include/linux/dma-direct.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Gavin Shan <gshan@redhat.com>
next prev parent reply other threads:[~2025-02-28 2:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 14:41 [PATCH v3 0/3] arm64: realm: Fix DMA address for devices Suzuki K Poulose
2025-02-27 14:41 ` [PATCH v3 1/3] dma: Fix encryption bit clearing for dma_to_phys Suzuki K Poulose
2025-02-28 2:08 ` Gavin Shan [this message]
2025-02-27 14:41 ` [PATCH v3 2/3] dma: Introduce generic dma_addr_*crypted helpers Suzuki K Poulose
2025-02-28 2:09 ` Gavin Shan
2025-02-28 18:23 ` Robin Murphy
2025-02-27 14:41 ` [PATCH v3 3/3] arm64: realm: Use aliased addresses for device DMA to shared buffers Suzuki K Poulose
2025-02-27 16:05 ` Catalin Marinas
2025-02-27 17:03 ` Suzuki K Poulose
2025-02-28 2:08 ` Gavin Shan
2025-03-03 14:16 ` Robin Murphy
2025-03-03 11:35 ` [PATCH v3 0/3] arm64: realm: Fix DMA address for devices Suzuki K Poulose
2025-03-04 13:40 ` Marek Szyprowski
2025-03-06 11:39 ` Suzuki K Poulose
2025-03-06 18:06 ` Catalin Marinas
2025-03-11 11:45 ` Will Deacon
2025-03-11 17:15 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ae2b809-7cc6-471b-9065-be446411570b@redhat.com \
--to=gshan@redhat.com \
--cc=aneesh.kumar@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=hch@lst.de \
--cc=jean-philippe@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=maz@kernel.org \
--cc=robin.murphy@arm.com \
--cc=steven.price@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=thomas.lendacky@amd.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox