Re: [PATCH 46/46] selinuxfs: Use seq_puts() in sel_avc_stats_seq_show()

Paul Moore
2017-03-29T15:53:45Z

On Sun, Jan 15, 2017 at 10:46 AM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 15 Jan 2017 14:04:53 +0100
>
> A string which did not contain data format specifications should be put
> into a sequence. Thus use the corresponding function "seq_puts".
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> security/selinux/selinuxfs.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)

Merged, thanks.

> diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c
> index 55345f84f17d..0d81ebf7ff23 100644
> --- a/security/selinux/selinuxfs.c
> +++ b/security/selinux/selinuxfs.c
> @@ -1445,10 +1445,10 @@ static int sel_avc_stats_seq_show(struct seq_file *seq, void *v)
> {
> struct avc_cache_stats *st = v;
>
> - if (v == SEQ_START_TOKEN)
> - seq_printf(seq, "lookups hits misses allocations reclaims "
> - "frees\n");
> - else {
> + if (v == SEQ_START_TOKEN) {
> + seq_puts(seq,
> + "lookups hits misses allocations reclaims frees\n");
> + } else {
> unsigned int lookups = st->lookups;
> unsigned int misses = st->misses;
> unsigned int hits = lookups - misses;
> --
> 2.11.0
>

--
paul moore