From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-183.mta0.migadu.com (out-183.mta0.migadu.com [91.218.175.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 552CB2C234A for ; Mon, 8 Dec 2025 11:23:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765193017; cv=none; b=qi23JaopS/Em8IT5oBA3l8No32FP9Vq2aL9R7mWPrzuvNgwtuSocbjBmQ6L2GNgZZ2tPpoQUlhpVgaR8xmhk199kt8oICvfy26Jzd8KM7/4KYTB+umr+LaVFYhJutb7yulNNobl60r09g6uof0F+rlmL9M4F1dSYUw6PR+BCM80= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765193017; c=relaxed/simple; bh=Zlarpza6LKHMQ/Nj6Se8tqYuZTzEmNS4BPPMPYTmOuw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rI1voaRIrXwACLv/stOUKgy4VVIw2B3hQLw5cjYlxxM/4lMkPq2/OKzJRTtJ7P7A5gvnnYVDCukTgvJkD5CssJ+2lBxFK/Ooxul5n3Ft3EYScEEW8Nz8fYJTCDqJ102T/TAswUTMZ9rgKF255ooRnEZ4nDoLtdaDCW7OyBMVZ5Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=TEEGn4kA; arc=none smtp.client-ip=91.218.175.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="TEEGn4kA" Message-ID: <6af17c1e-32fc-478a-8493-6c754c3020f0@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1765193003; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AZslY/w57YIKP0V/RVk3ghb2uRO3E+hID8DGKnBOyko=; b=TEEGn4kAEneIFuOzRw5wMg1cnqgB7SFPVHa6cs4XPSb4GH5HySo343N5A1sYyvFvTqrYTy r2/l8gNPjmiD36xIvKFCcExTvKy4FQaMcH7l2RZ+uwpSiUPOR8+rMy75j8Z9KLum6no+a+ zEkPnTpYrcBBvxOc3tzGsPzmrLXR3jI= Date: Mon, 8 Dec 2025 11:23:17 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH 1/4] Revert "drm/atomic-helper: Re-order bridge chain pre-enable and post-disable" To: Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Dmitry Baryshkov , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Jyri Sarha Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Marek Szyprowski , Louis-Alexis Eyraud , Linus Walleij , Chaoyi Chen , Vicente Bergas , Marek Vasut , stable@vger.kernel.org References: <20251205-drm-seq-fix-v1-0-fda68fa1b3de@ideasonboard.com> <20251205-drm-seq-fix-v1-1-fda68fa1b3de@ideasonboard.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Aradhya Bhatia In-Reply-To: <20251205-drm-seq-fix-v1-1-fda68fa1b3de@ideasonboard.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT Hi Tomi, Thank you for posting this series. It makes sense to change the order in tidss _commit_tail(), than to undo the order changes in the regressed drivers. On 05/12/2025 09:51, Tomi Valkeinen wrote: > This reverts commit c9b1150a68d9362a0827609fc0dc1664c0d8bfe1. > > Changing the enable/disable sequence has caused regressions on multiple > platforms: R-Car, MCDE, Rockchip. A series (see link below) was sent to > fix these, but it was decided that it's better to revert the original > patch and change the enable/disable sequence only in the tidss driver. > > Reverting this commit breaks tidss's DSI and OLDI outputs, which will be > fixed in the following commits. > > Signed-off-by: Tomi Valkeinen > Link: https://lore.kernel.org/all/20251202-mcde-drm-regression-thirdfix-v6-0-f1bffd4ec0fa%40kernel.org/ > Fixes: c9b1150a68d9 ("drm/atomic-helper: Re-order bridge chain pre-enable and post-disable") > Cc: stable@vger.kernel.org # v6.17+ > --- > drivers/gpu/drm/drm_atomic_helper.c | 8 +- > include/drm/drm_bridge.h | 249 ++++++++++-------------------------- > 2 files changed, 70 insertions(+), 187 deletions(-) > Reviewed-by: Aradhya Bhatia