The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: syzbot <syzbot+8277294f653f005e64d8@syzkaller.appspotmail.com>
To: a.hindborg@kernel.org, leitao@debian.org,
	linux-fsdevel@vger.kernel.org,  linux-kernel@vger.kernel.org,
	syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [fs?] possible deadlock in uvcg_streaming_class_drop_link
Date: Mon, 16 Nov 2026 10:37:29 -0800	[thread overview]
Message-ID: <6afb4d69.27ea6653.1a0e84.0001.GAE@google.com> (raw)
In-Reply-To: <6afb2dc7.e6a8accb.234e85.0002.GAE@google.com>

syzbot has found a reproducer for the following issue on:

HEAD commit:    aebb72744764 Linux 7.4-rc3
git tree:       upstream
console+strace: https://syzkaller.appspot.com/x/log.txt?x=10026dad580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=d44b06612b68f56
dashboard link: https://syzkaller.appspot.com/bug?extid=8277294f653f005e64d8
compiler:       Debian clang version 22.1.8 (1~deb13u4), Debian LLD 22.1.8
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=15fd1bfd580000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=12026dad580000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/b41932060b28/disk-aebb7274.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/8cebe8ee66ec/vmlinux-aebb7274.xz
kernel image: https://storage.googleapis.com/syzbot-assets/5547adc1d9da/bzImage-aebb7274.xz

AI-generated root cause summary:
A circular locking dependency warning is triggered between
gadget_subsys.su_mutex, tpg_instances_lock, and the VFS inode mutex
(&sb->s_type->i_mutex_key). During TCM portal group creation, usbg_make_tpg()
calls configfs_depend_item_unlocked() while holding tpg_instances_lock
(previously acquired under gadget_subsys.su_mutex), which acquires the configfs
root directory inode lock. When subsequently unlinking a UVC streaming class
symlink, vfs_unlink() holds the symlink's inode lock and invokes
uvcg_streaming_class_drop_link(), which acquires gadget_subsys.su_mutex for
hierarchy navigation. Because configfs symlink inodes and the configfs root
directory inode both share the default superblock inode lockdep class
(&sb->s_type->i_mutex_key), lockdep detects a circular dependency (su_mutex ->
tpg_instances_lock -> i_mutex_key -> su_mutex).

full analysis:  https://syzkaller.appspot.com/x/ai_root_cause?x=8277294f653f005e64d8

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+8277294f653f005e64d8@syzkaller.appspotmail.com

======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz-executor251/5652 is trying to acquire lock:
ffffffff91034be8 (gadget_subsys.su_mutex){+.+.}-{4:4}, at: uvcg_streaming_class_drop_link+0x70/0x540 drivers/usb/gadget/function/uvc_configfs.c:3502

but task is already holding lock:
ffff888071c99440 (&sb->s_type->i_mutex_key#18){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1027 [inline]
ffff888071c99440 (&sb->s_type->i_mutex_key#18){+.+.}-{4:4}, at: vfs_unlink+0xd4/0x710 fs/namei.c:5653

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&sb->s_type->i_mutex_key#18){+.+.}-{4:4}:
       down_write+0x91/0x200 kernel/locking/rwsem.c:1631
       inode_lock include/linux/fs.h:1027 [inline]
       configfs_depend_item_unlocked+0x153/0x420 fs/configfs/dir.c:1268
       usbg_make_tpg+0x1e0/0x550 drivers/usb/gadget/function/f_tcm.c:1692
       target_fabric_make_tpg+0xa8/0x6d0 drivers/target/target_core_fabric_configfs.c:947
       configfs_mkdir+0x4f6/0x9e0 fs/configfs/dir.c:1369
       vfs_mkdir+0x411/0x660 fs/namei.c:5428
       filename_mkdirat+0x284/0x550 fs/namei.c:5461
       __do_sys_mkdirat fs/namei.c:5482 [inline]
       __se_sys_mkdirat+0x35/0x150 fs/namei.c:5479
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x171/0x540 arch/x86/entry/syscall_64.c:89
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (tpg_instances_lock){+.+.}-{4:4}:
       __mutex_lock_common kernel/locking/mutex.c:646 [inline]
       __mutex_lock+0x197/0x15a0 kernel/locking/mutex.c:821
       tcm_alloc_inst+0x65/0x1a0 drivers/usb/gadget/function/f_tcm.c:2687
       try_get_usb_function_instance drivers/usb/gadget/functions.c:28 [inline]
       usb_get_function_instance+0xe3/0x2f0 drivers/usb/gadget/functions.c:44
       function_make+0x127/0x360 drivers/usb/gadget/configfs.c:626
       configfs_mkdir+0x4f6/0x9e0 fs/configfs/dir.c:1369
       vfs_mkdir+0x411/0x660 fs/namei.c:5428
       filename_mkdirat+0x284/0x550 fs/namei.c:5461
       __do_sys_mkdirat fs/namei.c:5482 [inline]
       __se_sys_mkdirat+0x35/0x150 fs/namei.c:5479
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x171/0x540 arch/x86/entry/syscall_64.c:89
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (func_lock){+.+.}-{4:4}:
       __mutex_lock_common kernel/locking/mutex.c:646 [inline]
       __mutex_lock+0x197/0x15a0 kernel/locking/mutex.c:821
       try_get_usb_function_instance drivers/usb/gadget/functions.c:18 [inline]
       usb_get_function_instance+0x2e/0x2f0 drivers/usb/gadget/functions.c:44
       function_make+0x127/0x360 drivers/usb/gadget/configfs.c:626
       configfs_mkdir+0x4f6/0x9e0 fs/configfs/dir.c:1369
       vfs_mkdir+0x411/0x660 fs/namei.c:5428
       filename_mkdirat+0x284/0x550 fs/namei.c:5461
       __do_sys_mkdirat fs/namei.c:5482 [inline]
       __se_sys_mkdirat+0x35/0x150 fs/namei.c:5479
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x171/0x540 arch/x86/entry/syscall_64.c:89
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (gadget_subsys.su_mutex){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3209 [inline]
       check_prevs_add kernel/locking/lockdep.c:3328 [inline]
       validate_chain kernel/locking/lockdep.c:3952 [inline]
       __lock_acquire+0x164c/0x2de0 kernel/locking/lockdep.c:5288
       lock_acquire+0x115/0x350 kernel/locking/lockdep.c:5942
       __mutex_lock_common kernel/locking/mutex.c:646 [inline]
       __mutex_lock+0x197/0x15a0 kernel/locking/mutex.c:821
       uvcg_streaming_class_drop_link+0x70/0x540 drivers/usb/gadget/function/uvc_configfs.c:3502
       configfs_unlink+0x44f/0x6b0 fs/configfs/symlink.c:258
       vfs_unlink+0x279/0x710 fs/namei.c:5667
       filename_unlinkat+0x297/0x5c0 fs/namei.c:5737
       __do_sys_unlink fs/namei.c:5772 [inline]
       __se_sys_unlink+0x2e/0x140 fs/namei.c:5769
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x171/0x540 arch/x86/entry/syscall_64.c:89
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  gadget_subsys.su_mutex --> tpg_instances_lock --> &sb->s_type->i_mutex_key#18

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&sb->s_type->i_mutex_key#18);
                               lock(tpg_instances_lock);
                               lock(&sb->s_type->i_mutex_key#18);
  lock(gadget_subsys.su_mutex);

 *** DEADLOCK ***

locks held by syz-executor251/5652: 3, on CPU#0:
 #0: ffff88801eff0478 (sb_writers#8){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:531
 #1: ffff888078fe4f80 (&default_group_class[depth - 1]#7/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:1072 [inline]
 #1: ffff888078fe4f80 (&default_group_class[depth - 1]#7/1){+.+.}-{4:4}, at: __start_dirop fs/namei.c:2924 [inline]
 #1: ffff888078fe4f80 (&default_group_class[depth - 1]#7/1){+.+.}-{4:4}, at: start_dirop fs/namei.c:2948 [inline]
 #1: ffff888078fe4f80 (&default_group_class[depth - 1]#7/1){+.+.}-{4:4}, at: filename_unlinkat+0x198/0x5c0 fs/namei.c:5718
 #2: ffff888071c99440 (&sb->s_type->i_mutex_key#18){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1027 [inline]
 #2: ffff888071c99440 (&sb->s_type->i_mutex_key#18){+.+.}-{4:4}, at: vfs_unlink+0xd4/0x710 fs/namei.c:5653

stack backtrace:
CPU: 0 UID: 0 PID: 5652 Comm: syz-executor251 Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/06/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120
 print_circular_bug+0x2e2/0x300 kernel/locking/lockdep.c:2087
 check_noncircular+0x12f/0x150 kernel/locking/lockdep.c:2219
 check_prev_add kernel/locking/lockdep.c:3209 [inline]
 check_prevs_add kernel/locking/lockdep.c:3328 [inline]
 validate_chain kernel/locking/lockdep.c:3952 [inline]
 __lock_acquire+0x164c/0x2de0 kernel/locking/lockdep.c:5288
 lock_acquire+0x115/0x350 kernel/locking/lockdep.c:5942
 __mutex_lock_common kernel/locking/mutex.c:646 [inline]
 __mutex_lock+0x197/0x15a0 kernel/locking/mutex.c:821
 uvcg_streaming_class_drop_link+0x70/0x540 drivers/usb/gadget/function/uvc_configfs.c:3502
 configfs_unlink+0x44f/0x6b0 fs/configfs/symlink.c:258
 vfs_unlink+0x279/0x710 fs/namei.c:5667
 filename_unlinkat+0x297/0x5c0 fs/namei.c:5737
 __do_sys_unlink fs/namei.c:5772 [inline]
 __se_sys_unlink+0x2e/0x140 fs/namei.c:5769
 do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
 do_syscall_64+0x171/0x540 arch/x86/entry/syscall_64.c:89
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fb28793a6c9
Code: c0 79 93 eb d5 48 8d 7c 1d 00 eb 99 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 d8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fffe9611a58 EFLAGS: 00000246 ORIG_RAX: 0000000000000057
RAX: ffffffffffffffda RBX: 0000200000000500 RCX: 00007fb28793a6c9
RDX: 0000000000000000 RSI: 00002000000002c0 RDI: 0000200000000500
RBP: 0000000000000001 R08: 0000000000000006 R09: 0000000000000006
R10: 0000000000000006 R11: 0000000000000246 R12: 00007fffe9611bc8
R13: 431bde82d7b634db R14: 00007fb2879cdc40 R15: 0000000000000002
 </TASK>

      reply	other threads:[~2026-11-16 18:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 16:22 [syzbot] [fs?] possible deadlock in uvcg_streaming_class_drop_link syzbot
2026-11-16 18:37 ` syzbot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6afb4d69.27ea6653.1a0e84.0001.GAE@google.com \
    --to=syzbot+8277294f653f005e64d8@syzkaller.appspotmail.com \
    --cc=a.hindborg@kernel.org \
    --cc=leitao@debian.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox