Re: [PATCH v3 0/2] Add driver support for Eswin EIC7700 SoC PCIe controller

[zhangsenchuan <zhangsenchuan@eswincomputing.com>]

Hi Bjorn, frank

I haven't received your feedback on the issue of pm usage yet.
Please help review the pm's issue again.

Looking forward to your reply. Thank you very much!

Kind regards
Senchuan Zhang

> -----Original Messages-----
> From: zhangsenchuan@eswincomputing.com
> Send time:Tuesday, 23/09/2025 20:09:45
> To: bhelgaas@google.com, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, johan+linaro@kernel.org, quic_schintav@quicinc.com, shradha.t@samsung.com, cassel@kernel.org, thippeswamy.havalige@amd.com, mayank.rana@oss.qualcomm.com, inochiama@gmail.com
> Cc: ningyu@eswincomputing.com, linmin@eswincomputing.com, pinkesh.vaghela@einfochips.com, "Senchuan Zhang" <zhangsenchuan@eswincomputing.com>
> Subject: [PATCH v3 0/2] Add driver support for Eswin EIC7700 SoC PCIe controller
> 
> From: Senchuan Zhang <zhangsenchuan@eswincomputing.com>
> 
> Changes in v3:
> - Updates: eswin,eic7700-pcie.yaml
>   - Based on the last patch yaml file, devicetree separates the root port
>     node, changing it significantly. Therefore, "Reviewed-by: Krzysztof
>     Kozlowski <krzysztof.kozlowski@linaro.org>" is not added.
>   - Clock and reset drivers are under review. In yaml, macro definitions
>     used in clock and reset can only be replaced by constant values.
>   - Move the num-lanes and perst resets to the PCIe Root Port node, make
>     it easier to support multiple Root Ports in future versions of the
>     hardware.
>   - Update the num-lanes attribute and modify define num-lanes as decimal.
>   - Optimize the ranges attribute and clear the relocatable flag (bit 31)
>     for any regions.
>   - Update comment: inte~inth are actual interrupts and these names align
>     with the interrupt names in the hardware IP, inte~inth interrupts
>     corresponds to Deassert_INTA~Deassert_INTD.
>   - Add Signed-off-by: Yanghui Ou <ouyanghui@eswincomputing.com>.
> 
> - Updates: pcie-eic7700.c
>   - Update the submission comment and add DWC IP revision, data rate, lane
>     information.
>   - Optimize the "config PCIE_EIC7700" configuration.
>   - Optimize the macro definition, add bitfield definition for the mask,
>     and remove redundant comments. optimize comments, make use of 80
>     columns for comments.
>   - Use the dw_pcie_find_capability function to obtain the offset by
>     traversing the function list.
>   - Remove the sets MPS code and configure it by PCI core.
>   - Alphabetize so the menuconfig entries remain sorted by vendor.
>   - Configure ESWIN VID:DID for Root Port as the default values are
> 	invalid,and remove the redundant lane config.
>   - Use reverse Xmas order for all local variables in this driver
>   - Hardware doesn't support MSI-X but it advertises MSI-X capability, set
>     a flag and clear it conditionally.
>   - Resets are all necessary, Update the interface function for resets.
>   - Since driver does not depend on any parent to power on any resource,
>     the pm runtime related functions are removed.
>   - Remove "eswin_pcie_shutdown" function, our comment on the shutdown
>     function is incorrect. Moreover, when the host powers reboots,it will
>     enter the shutdown function, we are using host reset and do not need
>     to assert perst. Therefore, the shutdown function is not necessary.
>   - remove "eswin_pcie_remove", because it is not safe to remove it during
>     runtime, and this driver has been modified to builtin_platform_driver
>     and does not support hot plugging, therefore, the remove function is
>     not needed.
>   - The Suspend function adds link state judgment, and for controllers
>     with active devices, resources cannot be turned off.
>   - Add Signed-off-by: Yanghui Ou <ouyanghui@eswincomputing.com>.
> - Link to V2: https://lore.kernel.org/linux-pci/20250829082021.49-1-zhangsenchuan@eswincomputing.com/
> 
> Changes in v2:
> - Updates: eswin,eic7700-pcie.yaml
>   - Optimize the naming of "clock-names" and "reset-names".
>   - Add a reference to "$ref: /schemas/pci/pci-host-bridge.yaml#".
>     (The name of the reset attribute in the "snps,dw-pcie-common.yaml"
>     file is different from our reset attribute and "snps,dw-pcie.yaml"
>     file cannot be directly referenced)
>   - Follow DTS coding style to optimize yaml attributes.
>   - Remove status = "disabled" from yaml.
> 
> - Updates: pcie-eic7700.c
>   - Remove unnecessary imported header files.
>   - Use dev_err instead of pr_err and remove the WARN_ON function.
>   - The eswin_evb_socket_power_on function is removed and not supported.
>   - The eswin_pcie_remove function is placed after the probe function.
>   - Optimize function alignment.
>   - Manage the clock using the devm_clk_bulk_get_all_enabled function.
>   - Handle the release of resources after the dw_pcie_host_init function
>     call fails.
>   - Remove the dev_dbg function and remove __exit_p.
>   - Add support for the system pm function.
> - Link to V1: https://lore.kernel.org/all/20250516094057.1300-1-zhangsenchuan@eswincomputing.com/
> 
> Senchuan Zhang (2):
>   dt-bindings: PCI: EIC7700: Add Eswin PCIe host controller
>   PCI: EIC7700: Add Eswin PCIe host controller driver
> 
>  .../bindings/pci/eswin,eic7700-pcie.yaml      | 173 +++++++
>  drivers/pci/controller/dwc/Kconfig            |  11 +
>  drivers/pci/controller/dwc/Makefile           |   1 +
>  drivers/pci/controller/dwc/pcie-eic7700.c     | 446 ++++++++++++++++++
>  4 files changed, 631 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml
>  create mode 100644 drivers/pci/controller/dwc/pcie-eic7700.c
> 
> --
> 2.25.1