The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Vignesh Raghavendra <vigneshr@ti.com>
To: Jayesh Choudhary <j-choudhary@ti.com>,
	<linux-kernel@vger.kernel.org>, <nm@ti.com>, <j-luthra@ti.com>
Cc: <kristo@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
	<conor+dt@kernel.org>, <linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <u-kumar1@ti.com>
Subject: Re: [PATCH 3/3] arm64: dts: ti: k3-j784s4-evm: Enable analog audio support
Date: Sat, 22 Jun 2024 12:14:39 +0530	[thread overview]
Message-ID: <6b13bb6a-4378-4764-9a60-d25ee2914176@ti.com> (raw)
In-Reply-To: <20240619095253.290552-4-j-choudhary@ti.com>



On 19/06/24 15:22, Jayesh Choudhary wrote:
> &wkup_pmx2 {
> @@ -881,6 +917,14 @@ exp1: gpio@20 {
>  				  "PCIE0_4L_RC_RSTZ", "PCIE0_4L_EP_RST_EN", "PCIE1_4L_PRSNT#",
>  				  "PCIE0_4L_PRSNT#", "CDCI1_OE1/OE4", "CDCI1_OE2/OE3",
>  				  "AUDIO_MUX_SEL", "EXP_MUX2", "EXP_MUX3", "GESI_EXP_PHY_RSTZ";
> +
> +		p12-hog {
> +			/* P12 - AUDIO_MUX_SEL */
> +			gpio-hog;
> +			gpios = <12 GPIO_ACTIVE_HIGH>;
> +			output-low;
> +			line-name = "AUDIO_MUX_SEL";
> +		};
>  	};
>  
>  	exp2: gpio@22 {
> @@ -896,6 +940,22 @@ exp2: gpio@22 {
>  				  "CANUART_MUX1_SEL1", "ENET1_EXP_PWRDN", "ENET1_EXP_RESETZ",
>  				  "ENET1_I2CMUX_SEL", "ENET1_EXP_SPARE2", "ENET2_EXP_RESETZ",
>  				  "USER_INPUT1", "USER_LED1", "USER_LED2";
> +
> +		p13-hog {
> +			/* P13 - CANUART_MUX_SEL0 */
> +			gpio-hog;
> +			gpios = <13 GPIO_ACTIVE_HIGH>;
> +			output-high;
> +			line-name = "CANUART_MUX_SEL0";
> +		};
> +
> +		p15-hog {
> +			/* P15 - CANUART_MUX1_SEL1 */
> +			gpio-hog;
> +			gpios = <15 GPIO_ACTIVE_HIGH>;
> +			output-high;
> +			line-name = "CANUART_MUX1_SEL1";
> +		};
>  	};
>  };


Does this break CAN instances already enabled in the dts? If you
consider making this a overlay as defaults seem to be set for CAN

-- 
Regards
Vignesh

  reply	other threads:[~2024-06-22  6:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-19  9:52 [PATCH 0/3] Enable audio for J784S4-EVM platform Jayesh Choudhary
2024-06-19  9:52 ` [PATCH 1/3] arm64: dts: ti: k3-j784s4-main: Add McASP nodes Jayesh Choudhary
2024-06-25  8:31   ` Vignesh Raghavendra
2024-06-25  9:57     ` Jayesh Choudhary
2024-06-19  9:52 ` [PATCH 2/3] arm64: dts: ti: k3-j784s4-main: Add audio_refclk node Jayesh Choudhary
2024-06-19  9:52 ` [PATCH 3/3] arm64: dts: ti: k3-j784s4-evm: Enable analog audio support Jayesh Choudhary
2024-06-22  6:44   ` Vignesh Raghavendra [this message]
2024-06-24  7:52     ` Jayesh Choudhary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6b13bb6a-4378-4764-9a60-d25ee2914176@ti.com \
    --to=vigneshr@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=j-choudhary@ti.com \
    --cc=j-luthra@ti.com \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=u-kumar1@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox