From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8C143B7744 for ; Tue, 14 Apr 2026 09:09:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776157744; cv=none; b=KIxlyvgIr9kb36nuCjPt74+1msGN70q5dK8n14cmSwPJ0qaLcLt8vNv22rb9T+oUOPsBUUEbTjb+Ybitt33ZkD+es/5//tJMGd7pGtSyV0s0I19tiGRgbT0ifbg4o8XfI0Lp4KqZ1+UPU02mO8IWmGYqlMtHEfPw7LFTmM1IMY8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776157744; c=relaxed/simple; bh=KHwVwvdW8+/51wnJjG3RP3NUzvq0DnMcvlt8hTAVStw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=l7VAuHte+rmGgHkG5vZz96dRHXgISDKsKeBpZjSHiPac6hQK7JEZBtF2toJqDra9E0NcrjFhxkkDu5A5pHkP2gJU4ZxUBXUE1HmFmda3PIHaPFlAmyvxNctRn1mkk//YjspmqbXmtWasjPTZLDkW7GSSqqqIxvvohlr1L8XwoO8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XHBi74Tj; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=trukhHo7; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XHBi74Tj"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="trukhHo7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776157741; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WkPnqRGl1gXZbEvB1A+stpFWNQBl4kOwSYgNSHlYul0=; b=XHBi74Tju+M0xPlNG5Ps1ilPWB2omf5qCA69sMy5I2qmPbRiq/H5mfa6H3ezYDygOHNLdP o4O5vYioUru1Gd3Goh0ILkcyRWAfGgzRA9Zy4NbIKJrsuvOPJSYGK5Ze/Jydy9EsKkODui W3m2WOgUc6DrO1rwSvWsUIWD7r2byuU= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-570-bV3X313EMGSTfsxPwpceFw-1; Tue, 14 Apr 2026 05:09:00 -0400 X-MC-Unique: bV3X313EMGSTfsxPwpceFw-1 X-Mimecast-MFC-AGG-ID: bV3X313EMGSTfsxPwpceFw_1776157739 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-43d03db814eso5474357f8f.2 for ; Tue, 14 Apr 2026 02:09:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776157739; x=1776762539; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WkPnqRGl1gXZbEvB1A+stpFWNQBl4kOwSYgNSHlYul0=; b=trukhHo7ToUrLsQlJGHUpMzXkV0j86zm3SP5ZEPi7KRyfNoGLf0NxIIJAbT1a1oBL5 L/liApKE5PbXS+TepVKrNR6ck9jJZXoEOnRqLcAncP3u3A/2B8LFCWcHxgMo5L1uKUWb z3tkVFfSmA+ahZQpD7I/S1dSwRH4MhutbW5TeXWJlYl/79WW/l65mDnneYvOKZT9+E46 WqTmBZbXfxm4AJalX+yAoq3GWsdL0tUYIW2GKChEj+Y0iZxOYZzn/7zB6la4MWAvadWZ Ka1QBTvBHtqTonfZ2Q58ppFf3+yWRPV0s9wjtbiLIsABxMGL+r4asfF8ksAAIstKdm5l BuSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776157739; x=1776762539; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WkPnqRGl1gXZbEvB1A+stpFWNQBl4kOwSYgNSHlYul0=; b=T5MUSNswILAYWwHVkrzc1iou84bEk1usS6bJN19HQ9MsdYOfWoBQVw8Jn1aqH7TbBH 5OogH7zClrcMzPvtSZnW+176irevInMIILYxxc+y8Wx+YcIHUZe4hyyERFkRE5yGkG7J GU79BB0Xx7L3fIf3gsqzcz+BMhEmI7VJypnsADAuEMyDylh5JUuPQs0E1cV2IlRXQa4t +zy5dOWy2kF261oF7juwARApeKD2dxhmQ/TRGV8+wI92kFSbgvtK3uY8aAmTupSt7yJ9 UBKZl0bk2pdEbjd+2sdfN49s4QLrwTrtpfNccP0VXNfPFLz3x4/b94SdynkQPlI35+Dj Kv4w== X-Forwarded-Encrypted: i=1; AFNElJ9i5HHNnGcPdN9jaVHd+lqZbBlinTfX7og9A9Dqy1KCDcD8C7Uwv2mjn9QoA0mKpkdENTkwrhyGiLN3rxw=@vger.kernel.org X-Gm-Message-State: AOJu0YwZFX3NBMrLolgbnwV+9fwql0yic0D6WhT0mx+0I5fekA4Erg6u iSYfsSfRQrjR9Jw5M/WEvrT3Nn9jSSyicJOIW38p8rMOM/F2ROl/T+aneUtGHwwzqpHPin2r3JA e0yELDIvTMxBuANBCYB/CvBlF/8+oX3NccJz9ZycIRcTEfK0uCvUEJe4jGFo6PXm4KA== X-Gm-Gg: AeBDievqTSYcgFCOrWG3FaBvfIijxtp0xU0wb+L/gpPClJVjbEJA8gPK7AXz0munSgY bdv9iHB/aAe1DlKSS/6D2MDZA/NS8Mpslf65XXdU4quVhu1rUghHfCweyoE4VLxxXklDSmuhjfx 2vJgo7tZqammXxAWJGS3rLpVp6HbN1lmVzm5+DmBB4H024mcbwxnhMqW8+GoAueXGtYmdmusuEV dIRkV6+CJ/L3Cu1Fyk2Pv9A1cSNr5tdGETxo/HD4125e5kGQs7X2c67J8xkgj7W4aNscvSTvtla xUhGtwTZ79VZL6WW80CVozQF4EUZECLs5CexYMCyqp0w+c9X9NcCc3D07OC4CGdX+1oZ2Gr+koR F7/s2OZyePkUDPzyYo+/QJa9gf0K/tktbI6DpM7Yl5cTxA6e48GFazTcJ X-Received: by 2002:a05:6000:24c3:b0:43d:77a8:3bb6 with SMTP id ffacd0b85a97d-43d77a83df5mr11097043f8f.47.1776157739311; Tue, 14 Apr 2026 02:08:59 -0700 (PDT) X-Received: by 2002:a05:6000:24c3:b0:43d:77a8:3bb6 with SMTP id ffacd0b85a97d-43d77a83df5mr11096988f8f.47.1776157738818; Tue, 14 Apr 2026 02:08:58 -0700 (PDT) Received: from [192.168.88.32] ([216.128.11.125]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d63e5061fsm41420908f8f.30.2026.04.14.02.08.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Apr 2026 02:08:58 -0700 (PDT) Message-ID: <6b22a595-cd65-42ec-b332-c835273bc174@redhat.com> Date: Tue, 14 Apr 2026 11:08:56 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 2/2] selftests/bpf: verify syncookie statistics in tcp_custom_syncookie To: Kuniyuki Iwashima , Jiayuan Chen Cc: netdev@vger.kernel.org, Eric Dumazet , Neal Cardwell , "David S. Miller" , Jakub Kicinski , Simon Horman , David Ahern , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Shuah Khan , linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org References: <20260411013211.225834-1-jiayuan.chen@linux.dev> <20260411013211.225834-2-jiayuan.chen@linux.dev> Content-Language: en-US From: Paolo Abeni In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 4/14/26 7:50 AM, Kuniyuki Iwashima wrote: > On Fri, Apr 10, 2026 at 6:32 PM Jiayuan Chen wrote: >> >> Add read_tcpext_snmp() helper to network_helpers which reads a >> TcpExt SNMP counter via nstat, and use it in the tcp_custom_syncookie >> test to verify that LINUX_MIB_SYNCOOKIESRECV is incremented and >> LINUX_MIB_SYNCOOKIESFAILED stays unchanged across a successful >> BPF custom syncookie validation. >> >> The delta is captured between start_server() and accept(), which >> covers the full SYN/ACK/cookie-check path for one connection. >> >> Signed-off-by: Jiayuan Chen >> --- >> tools/testing/selftests/bpf/network_helpers.c | 22 +++++++++++++++++++ >> tools/testing/selftests/bpf/network_helpers.h | 1 + >> .../bpf/prog_tests/tcp_custom_syncookie.c | 20 +++++++++++++++++ > > As you touch bpf selftest helper files, please rebase on bpf-next > to avoid possible conflicts and tag bpf-next in the Subject. To hopefully minimize the conflicts handling I'm going to apply patch 1/2 to net-next. Please resubmit patch 2/2 to bpf-next after the relevant net core reach there. /P