public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Liang He" <windhl@126.com>
To: "Heiko Stuebner" <heiko@sntech.de>
Cc: linux@armlinux.org.uk, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Subject: Re:Re: [PATCH v2] arm: mach-rockchip: (pm) Add missing of_node_put()
Date: Sat, 18 Jun 2022 10:43:12 +0800 (CST)	[thread overview]
Message-ID: <6b387941.aed.18174b16871.Coremail.windhl@126.com> (raw)
In-Reply-To: <165548567344.3407211.15518569345867067474.b4-ty@sntech.de>



At 2022-06-18 01:10:28, "Heiko Stuebner" <heiko@sntech.de> wrote:
>On Thu, 16 Jun 2022 10:17:13 +0800, Liang He wrote:
>> In rockchip_suspend_init(), of_find_matching_node_and_match() will
>> return a node pointer with refcount incremented. We should use
>> of_node_put() in fail path or when it is not used anymore.
>
>Applied, thanks!
>
>[1/1] arm: mach-rockchip: (pm) Add missing of_node_put()
>      commit f4470dbfb5ff92804650bc71d115c3f150d430f6
>
>There was an unneeded tab in the blank line above out_put
>and a completely unneeded blank line added at the end of
>the function. I dropped both.

Thanks very much for your effort.

I am learning the coding style for kernel code.

>
>Best regards,
>-- 
>Heiko Stuebner <heiko@sntech.de>

  reply	other threads:[~2022-06-18  2:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-16  2:17 [PATCH v2] arm: mach-rockchip: (pm) Add missing of_node_put() Liang He
2022-06-17 17:10 ` Heiko Stuebner
2022-06-18  2:43   ` Liang He [this message]
2022-06-22  9:00 ` Krzysztof Kozlowski
2022-06-22 13:10   ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6b387941.aed.18174b16871.Coremail.windhl@126.com \
    --to=windhl@126.com \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox